diff --git a/API/Controllers/PersonController.cs b/API/Controllers/PersonController.cs index 4e994cb37..bf3cc1814 100644 --- a/API/Controllers/PersonController.cs +++ b/API/Controllers/PersonController.cs @@ -80,7 +80,7 @@ public class PersonController : BaseApiController /// /// [HttpPost("all")] - public async Task>> GetAuthorsForBrowse(BrowsePersonFilterDto filter, [FromQuery] UserParams? userParams) + public async Task>> GetPeopleForBrowse(BrowsePersonFilterDto filter, [FromQuery] UserParams? userParams) { userParams ??= UserParams.Default; @@ -90,17 +90,6 @@ public class PersonController : BaseApiController return Ok(list); } - // [HttpPost("all-v2")] - // public async Task>> GetAuthorsForBrowse(FilterV2Dto filter, [FromQuery] UserParams? userParams) - // { - // userParams ??= UserParams.Default; - // - // // var list = await _unitOfWork.PersonRepository.GetBrowsePersonDtos(User.GetUserId(), filter, userParams); - // // Response.AddPaginationHeader(list.CurrentPage, list.PageSize, list.TotalCount, list.TotalPages); - // - // return Ok([]); - // } - /// /// Updates the Person /// diff --git a/API/Data/Repositories/PersonRepository.cs b/API/Data/Repositories/PersonRepository.cs index 86d2f5a06..6954ccf03 100644 --- a/API/Data/Repositories/PersonRepository.cs +++ b/API/Data/Repositories/PersonRepository.cs @@ -267,7 +267,7 @@ public class PersonRepository : IPersonRepository PersonFilterField.Role => query.HasPersonRole(true, statement.Comparison, (IList)value), PersonFilterField.SeriesCount => query.HasPersonSeriesCount(true, statement.Comparison, (int)value), PersonFilterField.ChapterCount => query.HasPersonChapterCount(true, statement.Comparison, (int)value), - _ => throw new ArgumentOutOfRangeException() + _ => throw new ArgumentOutOfRangeException(nameof(statement.Field), $"Unexpected value for field: {statement.Field}") }; } diff --git a/API/Data/Repositories/SeriesRepository.cs b/API/Data/Repositories/SeriesRepository.cs index 83678ecaf..e2eab0976 100644 --- a/API/Data/Repositories/SeriesRepository.cs +++ b/API/Data/Repositories/SeriesRepository.cs @@ -1290,7 +1290,7 @@ public class SeriesRepository : ISeriesRepository FilterField.ReadingDate => query.HasReadingDate(true, statement.Comparison, (DateTime) value, userId), FilterField.ReadLast => query.HasReadLast(true, statement.Comparison, (int) value, userId), FilterField.AverageRating => query.HasAverageRating(true, statement.Comparison, (float) value), - _ => throw new ArgumentOutOfRangeException() + _ => throw new ArgumentOutOfRangeException(nameof(statement.Field), $"Unexpected value for field: {statement.Field}") }; } diff --git a/API/Helpers/Converters/PersonFilterFieldValueConverter.cs b/API/Helpers/Converters/PersonFilterFieldValueConverter.cs index 4165be4c4..822ce105a 100644 --- a/API/Helpers/Converters/PersonFilterFieldValueConverter.cs +++ b/API/Helpers/Converters/PersonFilterFieldValueConverter.cs @@ -22,7 +22,7 @@ public static class PersonFilterFieldValueConverter private static IList ParsePersonRoles(string value) { - if (string.IsNullOrEmpty(value)) return new List(); + if (string.IsNullOrEmpty(value)) return []; return value.Split(',', StringSplitOptions.RemoveEmptyEntries) .Select(v => Enum.Parse(v.Trim()))