Manga Reader Shakeout (#1142)

* Fixed a unit test in ArchiveService

* Image scaling fixes

* removing test

* Added new layout mode (enum only) and cleaned up manga reader and wrote extra documentation

* Aligned code with cleanup

* Adding reverse classes for manga reading

* Disable options for layout modes that doesn't make sense.

* Cleaned up manga reader menu items to link to preferences options directly

* Work in progress, but rendering the correct page numbers for double. Need to rework caching logic so we can use existing image objects

* Pagination logic is now properly increasing page number an extra when double layout mode

* I can't figure out cachedImages to work properly with double pages, but doing it in a way where it handles downloading the image (and etag cache) + rendering the url, seems to work really well

* Double original fix, also flex squish fix

* Implemented last page on double which will load next chapter.

Fixed a bug where if GetImage from ReaderController threw an error, the chapter directory would be emptied, but the folder itself wasn't deleted.

* Fixed a bad if for double manga

* double class fix

* Cleanup up some console.logs

* Adjusted the caching for images in a reading session so they cache for 2 mins

* fixing webtoon image issue

* Tweaked the caching of images to 10 mins for reading. Fixed a bug where after webtoon, single image layout would be selected. Tweaked logic for handling prev/next pages on chapter boundaries.

* Fixed an issue where 2nd page would be skipped

* Fixed an issue where 2nd page would be skipped

* Fixed a skip page issue

* Misc css fixes

Co-authored-by: Robbie Davis <robbie@therobbiedavis.com>

API/Controllers/ReaderController.cs

@@ -63,7 +63,7 @@ namespace API.Controllers
                 if (string.IsNullOrEmpty(path) || !System.IO.File.Exists(path)) return BadRequest($"No such image for page {page}");
                 var format = Path.GetExtension(path).Replace(".", "");
 
-                Response.AddCacheHeader(path);
+                Response.AddCacheHeader(path, TimeSpan.FromMinutes(10).Seconds);
                 return PhysicalFile(path, "image/" + format, Path.GetFileName(path));
             }
             catch (Exception)

API/Entities/Enums/LayoutMode.cs

@@ -7,5 +7,7 @@ public enum LayoutMode
     [Description("Single")]
     Single = 1,
     [Description("Double")]
-    Double = 2
+    Double = 2,
+    [Description("Double (manga)")]
+    DoubleReversed = 3
 }

API/Extensions/HttpExtensions.cs

@@ -1,4 +1,5 @@
-using System.IO;
+using System;
+using System.IO;
 using System.Linq;
 using System.Security.Cryptography;
 using System.Text;
@@ -41,12 +42,17 @@ namespace API.Extensions
         /// </summary>
         /// <param name="response"></param>
         /// <param name="filename"></param>
-        public static void AddCacheHeader(this HttpResponse response, string filename)
+        /// <param name="maxAge">Maximum amount of seconds to set for Cache-Control</param>
+        public static void AddCacheHeader(this HttpResponse response, string filename, int maxAge = 10)
         {
-            if (filename == null || filename.Length <= 0) return;
+            if (filename is not {Length: > 0}) return;
             var hashContent = filename + File.GetLastWriteTimeUtc(filename);
             using var sha1 = SHA256.Create();
             response.Headers.Add("ETag", string.Concat(sha1.ComputeHash(Encoding.UTF8.GetBytes(hashContent)).Select(x => x.ToString("X2"))));
+            if (maxAge != 10)
+            {
+                response.Headers.CacheControl =  $"max-age={maxAge}";
+            }
         }
 
     }

API/Services/CacheService.cs

@@ -142,7 +142,7 @@ namespace API.Services
         {
             foreach (var chapter in chapterIds)
             {
-                _directoryService.ClearDirectory(GetCachePath(chapter));
+                _directoryService.ClearAndDeleteDirectory(GetCachePath(chapter));
             }
         }