AZEN-SGG/Kavita
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Took care of SonarCloud code issues (#1041)

Browse source
This commit is contained in:
Joseph Milazzo 2022-02-07 05:30:28 -08:00 • committed by GitHub
parent 5b32a958dc
commit 0e2fafe396
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 27 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

23
API/Parser/Parser.cs
View file

@ -659,20 +659,17 @@ namespace API.Parser
private static string FormatValue(string value, bool hasPart)
{
if (!value.Contains("-"))
if (!value.Contains('-'))
{
return RemoveLeadingZeroes(hasPart ? AddChapterPart(value) : value);
}
var tokens = value.Split("-");
var from = RemoveLeadingZeroes(tokens[0]);
if (tokens.Length == 2)
{
var to = RemoveLeadingZeroes(hasPart ? AddChapterPart(tokens[1]) : tokens[1]);
return $"{@from}-{to}";
}
if (tokens.Length != 2) return from;
return @from;
var to = RemoveLeadingZeroes(hasPart ? AddChapterPart(tokens[1]) : tokens[1]);
return $"{from}-{to}";
}
public static string ParseChapter(string filename)
@ -696,7 +693,7 @@ namespace API.Parser
private static string AddChapterPart(string value)
{
if (value.Contains("."))
if (value.Contains('.'))
{
return value;
}
@ -876,13 +873,10 @@ namespace API.Parser
/// <returns>A zero padded number</returns>
public static string PadZeros(string number)
{
if (number.Contains("-"))
{
var tokens = number.Split("-");
return $"{PerformPadding(tokens[0])}-{PerformPadding(tokens[1])}";
}
if (!number.Contains('-')) return PerformPadding(number);
return PerformPadding(number);
var tokens = number.Split("-");
return $"{PerformPadding(tokens[0])}-{PerformPadding(tokens[1])}";
}
private static string PerformPadding(string number)
@ -964,7 +958,6 @@ namespace API.Parser
public static string Normalize(string name)
{
// TODO: This can eat upto 100MB on a file scan. Look into optimizing
var normalized = NormalizeRegex.Replace(name, string.Empty).ToLower();
return string.IsNullOrEmpty(normalized) ? name : normalized;
}