From 17955eb9f64b8b3589788b59ee81becb772f96d9 Mon Sep 17 00:00:00 2001 From: Joseph Milazzo Date: Sat, 26 Apr 2025 07:39:22 -0500 Subject: [PATCH] SonarCube stuff --- API/Helpers/PersonHelper.cs | 1 - API/Services/Plus/ExternalMetadataService.cs | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/API/Helpers/PersonHelper.cs b/API/Helpers/PersonHelper.cs index fe437daa8..07161e418 100644 --- a/API/Helpers/PersonHelper.cs +++ b/API/Helpers/PersonHelper.cs @@ -80,7 +80,6 @@ public static class PersonHelper // If not, create a new Person entity using the real name dbPerson = new PersonBuilder(personName).Build(); peopleToAttach.Add(dbPerson); // Add new person to the list to be attached - modification = true; } // Add the person to the SeriesMetadataPeople collection diff --git a/API/Services/Plus/ExternalMetadataService.cs b/API/Services/Plus/ExternalMetadataService.cs index eb7151047..aef97bdda 100644 --- a/API/Services/Plus/ExternalMetadataService.cs +++ b/API/Services/Plus/ExternalMetadataService.cs @@ -113,7 +113,7 @@ public class ExternalMetadataService : IExternalMetadataService public async Task FetchExternalDataTask() { // Find all Series that are eligible and limit - var ids = await _unitOfWork.ExternalSeriesMetadataRepository.GetSeriesThatNeedExternalMetadata(25, false); + var ids = await _unitOfWork.ExternalSeriesMetadataRepository.GetSeriesThatNeedExternalMetadata(25); if (ids.Count == 0) return; ids = await _unitOfWork.ExternalSeriesMetadataRepository.GetSeriesThatNeedExternalMetadata(25, true); @@ -444,7 +444,7 @@ public class ExternalMetadataService : IExternalMetadataService { if (errorMessage.Contains("Too many Requests")) { - _logger.LogInformation("Hit rate limit, will retry in 3 seconds"); + _logger.LogDebug("Hit rate limit, will retry in 3 seconds"); await Task.Delay(3000); result = await (Configuration.KavitaPlusApiUrl + "/api/metadata/v2/series-detail") @@ -673,7 +673,7 @@ public class ExternalMetadataService : IExternalMetadataService foreach (var relation in externalMetadataRelations.Where(r => r.Relation != RelationKind.Parent)) { - var names = new [] {relation.SeriesName.PreferredTitle, relation.SeriesName.RomajiTitle, relation.SeriesName.EnglishTitle, relation.SeriesName.NativeTitle}; + List names = new [] {relation.SeriesName.PreferredTitle, relation.SeriesName.RomajiTitle, relation.SeriesName.EnglishTitle, relation.SeriesName.NativeTitle}.Where(s => !string.IsNullOrEmpty(s)).ToList()!; var relatedSeries = await _unitOfWork.SeriesRepository.GetSeriesByAnyName( names, relation.PlusMediaFormat.GetMangaFormats(), @@ -1232,7 +1232,7 @@ public class ExternalMetadataService : IExternalMetadataService .DistinctBy(p => Parser.Normalize(p.Name)) .ToList(); - await PersonHelper.UpdateChapterPeopleAsync(chapter, staff, role, _unitOfWork); + await PersonHelper.UpdateChapterPeopleAsync(chapter, staff ?? [], role, _unitOfWork); foreach (var person in chapter.People.Where(p => p.Role == role)) {