Bugfixes (#1177)

* Fixed an underline on hover of pagination link

* Ensure title of companion bar eats full width if there is no filter

* If a user doesn't have the Download role, they will not be able to download over OPDS.

* Fixed a bug where after going into webtoon reader mode then leaving, the bookmark effect would continue using the webtoon mode styling

* Fixed a bug where continuous reader wasn't being triggered due to moving scrollbar to body and a floating point percision error on scroll top

* Fixed how continuous trigger is shown so that we properly adjust scroll on the top (for prev chapter)

* Fixed a bad merge that broke saving any edits to series metadata

* When a epub key is not correct, even after we correct it, ignore the inlining of the style so the book is at least still readable.

* Disabled double rendering (this feature is being postponed to a later release)

* Disabled user setting and forced it to Single on any save

* Removed cache directory from UpdateSettings validation as we don't allow changing it.

* Fix security issue with url parse

* After all migrations run, update the installed version in the Database. Send that installed version on the stat service.

* Dependency bot to update some security stuff

* Some misc code cleanup and fixes on the typeahead (still broken)

API/Services/BookService.cs

@@ -150,7 +150,7 @@ namespace API.Services
         {
             // @Import statements will be handled by browser, so we must inline the css into the original file that request it, so they can be
             // Scoped
-            var prepend = filename.Length > 0 ? filename.Replace(Path.GetFileName(filename), "") : string.Empty;
+            var prepend = filename.Length > 0 ? filename.Replace(Path.GetFileName(filename), string.Empty) : string.Empty;
             var importBuilder = new StringBuilder();
             foreach (Match match in Parser.Parser.CssImportUrlRegex.Matches(stylesheetHtml))
             {
@@ -343,7 +343,7 @@ namespace API.Services
             {
                 foreach (var styleLinks in styleNodes)
                 {
-                    var key = BookService.CleanContentKeys(styleLinks.Attributes["href"].Value);
+                    var key = CleanContentKeys(styleLinks.Attributes["href"].Value);
                     // Some epubs are malformed the key in content.opf might be: content/resources/filelist_0_0.xml but the actual html links to resources/filelist_0_0.xml
                     // In this case, we will do a search for the key that ends with
                     if (!book.Content.Css.ContainsKey(key))
@@ -358,11 +358,20 @@ namespace API.Services
                         key = correctedKey;
                     }
 
-                    var styleContent = await ScopeStyles(await book.Content.Css[key].ReadContentAsync(), apiBase,
-                        book.Content.Css[key].FileName, book);
-                    if (styleContent != null)
+                    try
                     {
-                        body.PrependChild(HtmlNode.CreateNode($"<style>{styleContent}</style>"));
+                        var cssFile = book.Content.Css[key];
+
+                        var styleContent = await ScopeStyles(await cssFile.ReadContentAsync(), apiBase,
+                            cssFile.FileName, book);
+                        if (styleContent != null)
+                        {
+                            body.PrependChild(HtmlNode.CreateNode($"<style>{styleContent}</style>"));
+                        }
+                    }
+                    catch (Exception ex)
+                    {
+                        _logger.LogError(ex, "There was an error reading css file for inlining likely due to a key mismatch in metadata");
                     }
                 }
             }
@@ -460,7 +469,7 @@ namespace API.Services
         }
 
         /// <summary>
-        /// Removes the leading ../
+        /// Removes all leading ../
         /// </summary>
         /// <param name="key"></param>
         /// <returns></returns>

API/Services/DirectoryService.cs

@@ -84,6 +84,8 @@ namespace API.Services
            ConfigDirectory = FileSystem.Path.Join(FileSystem.Directory.GetCurrentDirectory(), "config");
            BookmarkDirectory = FileSystem.Path.Join(FileSystem.Directory.GetCurrentDirectory(), "config", "bookmarks");
            SiteThemeDirectory = FileSystem.Path.Join(FileSystem.Directory.GetCurrentDirectory(), "config", "themes");
+
+           ExistOrCreate(SiteThemeDirectory);
        }
 
        /// <summary>

API/Services/DownloadService.cs

@@ -2,7 +2,9 @@
 using System.IO;
 using System.Linq;
 using System.Threading.Tasks;
+using API.Constants;
 using API.Entities;
+using Microsoft.AspNetCore.Identity;
 using Microsoft.AspNetCore.StaticFiles;
 
 namespace API.Services;
@@ -11,15 +13,18 @@ public interface IDownloadService
 {
     Task<(byte[], string, string)> GetFirstFileDownload(IEnumerable<MangaFile> files);
     string GetContentTypeFromFile(string filepath);
+    Task<bool> HasDownloadPermission(AppUser user);
 }
 public class DownloadService : IDownloadService
 {
     private readonly IDirectoryService _directoryService;
+    private readonly UserManager<AppUser> _userManager;
     private readonly FileExtensionContentTypeProvider _fileTypeProvider = new FileExtensionContentTypeProvider();
 
-    public DownloadService(IDirectoryService directoryService)
+    public DownloadService(IDirectoryService directoryService, UserManager<AppUser> userManager)
     {
         _directoryService = directoryService;
+        _userManager = userManager;
     }
 
     /// <summary>
@@ -53,4 +58,10 @@ public class DownloadService : IDownloadService
 
         return contentType;
     }
+
+    public async Task<bool> HasDownloadPermission(AppUser user)
+    {
+        var roles = await _userManager.GetRolesAsync(user);
+        return roles.Contains(PolicyConstants.DownloadRole) || roles.Contains(PolicyConstants.AdminRole);
+    }
 }

API/Services/Tasks/StatsService.cs

@@ -99,11 +99,12 @@ public class StatsService : IStatsService
     public async Task<ServerInfoDto> GetServerInfo()
     {
         var installId = await _unitOfWork.SettingsRepository.GetSettingAsync(ServerSettingKey.InstallId);
+        var installVersion = await _unitOfWork.SettingsRepository.GetSettingAsync(ServerSettingKey.InstallVersion);
         var serverInfo = new ServerInfoDto
         {
             InstallId = installId.Value,
             Os = RuntimeInformation.OSDescription,
-            KavitaVersion = BuildInfo.Version.ToString(),
+            KavitaVersion = installVersion.Value,
             DotnetVersion = Environment.Version.ToString(),
             IsDocker = new OsInfo(Array.Empty<IOsVersionAdapter>()).IsDocker,
             NumOfCores = Math.Max(Environment.ProcessorCount, 1),