From 2f5743d2ae23ef09d4a144d6fbb2db71a5775dbd Mon Sep 17 00:00:00 2001 From: Joseph Milazzo Date: Sun, 11 May 2025 12:50:45 -0500 Subject: [PATCH] Some fixes around empty year --- API/Services/Plus/ExternalMetadataService.cs | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/API/Services/Plus/ExternalMetadataService.cs b/API/Services/Plus/ExternalMetadataService.cs index cd6fbce25..435727bda 100644 --- a/API/Services/Plus/ExternalMetadataService.cs +++ b/API/Services/Plus/ExternalMetadataService.cs @@ -216,12 +216,16 @@ public class ExternalMetadataService : IExternalMetadataService var potentialMalId = ScrobblingService.ExtractId(dto.Query, ScrobblingService.MalWeblinkWebsite); var format = series.Library.Type.ConvertToPlusMediaFormat(series.Format); - var otherNames = ExtractAlternativeNames(dto, series); + var otherNames = ExtractAlternativeNames(series); var year = series.Metadata.ReleaseYear; - if (year == 0 && format == PlusMediaFormat.Comic) + if (year == 0 && format == PlusMediaFormat.Comic && !string.IsNullOrWhiteSpace(series.Name)) { - year = int.Parse(Parser.ParseYear(series.Name)); + var potentialYear = Parser.ParseYear(series.Name); + if (!string.IsNullOrEmpty(potentialYear)) + { + year = int.Parse(potentialYear); + } } var matchRequest = new MatchSeriesRequestDto() @@ -260,16 +264,10 @@ public class ExternalMetadataService : IExternalMetadataService return ArraySegment.Empty; } - private static List ExtractAlternativeNames(MatchSeriesDto dto, Series series) + private static List ExtractAlternativeNames(Series series) { List altNames = [series.LocalizedName, series.OriginalName]; - // if (potentialAnilistId == null && potentialMalId == null && !string.IsNullOrEmpty(dto.Query)) - // { - // altNames.Add(dto.Query); - // } - - var otherNames = altNames.Where(s => !string.IsNullOrEmpty(s)).Distinct().ToList(); - return otherNames; + return altNames.Where(s => !string.IsNullOrEmpty(s)).Distinct().ToList(); }