AZEN-SGG/Kavita
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix Genre/Tag with spaces getting normalized (#3731)

Browse source
This commit is contained in:
Joe Milazzo 2025-04-13 08:19:42 -06:00 • committed by GitHub
parent 55966f0b2a
commit 33221fee2b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 104 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

22
API/Helpers/TagHelper.cs
View file

@ -20,7 +20,13 @@ public static class TagHelper
public static async Task UpdateChapterTags(Chapter chapter, IEnumerable<string> tagNames, IUnitOfWork unitOfWork)
{
// Normalize tag names once and store them in a hash set for quick lookups
var normalizedTagsToAdd = new HashSet<string>(tagNames.Select(t => t.ToNormalized()));
// Create a dictionary: normalized => original
var normalizedToOriginal = tagNames
.Select(t => new { Original = t, Normalized = t.ToNormalized() })
.GroupBy(x => x.Normalized) // in case of duplicates
.ToDictionary(g => g.Key, g => g.First().Original);
var normalizedTagsToAdd = new HashSet<string>(normalizedToOriginal.Keys);
var existingTagsSet = new HashSet<string>(chapter.Tags.Select(t => t.NormalizedTitle));
var isModified = false;
@ -30,7 +36,7 @@ public static class TagHelper
.Where(t => !normalizedTagsToAdd.Contains(t.NormalizedTitle))
.ToList();
if (tagsToRemove.Any())
if (tagsToRemove.Count != 0)
{
foreach (var tagToRemove in tagsToRemove)
{
@ -47,7 +53,7 @@ public static class TagHelper
// Find missing tags that are not already in the database
var missingTags = normalizedTagsToAdd
.Where(nt => !existingTagTitles.ContainsKey(nt))
.Select(title => new TagBuilder(title).Build())
.Select(nt => new TagBuilder(normalizedToOriginal[nt]).Build())
.ToList();
// Add missing tags to the database if any
@ -67,13 +73,11 @@ public static class TagHelper
// Add the new or existing tags to the chapter
foreach (var normalizedTitle in normalizedTagsToAdd)
{
var tag = existingTagTitles[normalizedTitle];
if (existingTagsSet.Contains(normalizedTitle)) continue;
if (!existingTagsSet.Contains(normalizedTitle))
{
chapter.Tags.Add(tag);
isModified = true;
}
var tag = existingTagTitles[normalizedTitle];
chapter.Tags.Add(tag);
isModified = true;
}
// Commit changes if modifications were made to the chapter's tags