From 4411d749b0ef76a4149e97b34dbcb33413701270 Mon Sep 17 00:00:00 2001 From: Amelia <77553571+Fesaa@users.noreply.github.com> Date: Fri, 20 Jun 2025 20:55:59 +0200 Subject: [PATCH] Test correct behaviour, fix that behaviour Change misleading comment --- API.Tests/Services/ScrobblingServiceTests.cs | 14 ++++++++++++-- API/Services/Plus/ScrobblingService.cs | 1 + 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/API.Tests/Services/ScrobblingServiceTests.cs b/API.Tests/Services/ScrobblingServiceTests.cs index 71d6cc804..9245c8ecd 100644 --- a/API.Tests/Services/ScrobblingServiceTests.cs +++ b/API.Tests/Services/ScrobblingServiceTests.cs @@ -286,7 +286,7 @@ public class ScrobblingServiceTests : AbstractDbTest await _readerService.MarkChaptersAsRead(user, 1, new List() {volume.Chapters[0]}); await UnitOfWork.CommitAsync(); - // Call Scrobble without having any progress + // Call Scrobble while having some progress await _service.ScrobbleReadingUpdate(user.Id, 1); var events = await UnitOfWork.ScrobbleRepository.GetAllEventsForSeries(1); Assert.Single(events); @@ -334,14 +334,24 @@ public class ScrobblingServiceTests : AbstractDbTest var user = await UnitOfWork.UserRepository.GetUserByIdAsync(1); Assert.NotNull(user); + var volume = await UnitOfWork.VolumeRepository.GetVolumeAsync(1, VolumeIncludes.Chapters); + Assert.NotNull(volume); + + await _readerService.MarkChaptersAsRead(user, 1, new List() {volume.Chapters[0]}); + await UnitOfWork.CommitAsync(); + await _service.ScrobbleReadingUpdate(1, 1); var events = await UnitOfWork.ScrobbleRepository.GetAllEventsForSeries(1); - Assert.Empty(events); + Assert.Single(events); + + var readEvent = events.First(); + Assert.False(readEvent.IsProcessed); await _hookedUpReaderService.MarkSeriesAsUnread(user, 1); await UnitOfWork.CommitAsync(); // Existing event is deleted + await _service.ScrobbleReadingUpdate(1, 1); events = await UnitOfWork.ScrobbleRepository.GetAllEventsForSeries(1); Assert.Empty(events); diff --git a/API/Services/Plus/ScrobblingService.cs b/API/Services/Plus/ScrobblingService.cs index 347b49c13..f9c3fdb09 100644 --- a/API/Services/Plus/ScrobblingService.cs +++ b/API/Services/Plus/ScrobblingService.cs @@ -427,6 +427,7 @@ public class ScrobblingService : IScrobblingService _unitOfWork.ScrobbleRepository.Remove(existingEvt); await _unitOfWork.CommitAsync(); _logger.LogDebug("Removed scrobble event for {Series} as there is no reading progress", series.Name); + return; } // We need to just update Volume/Chapter number