Change Detection: On Push aka UI Smoothness (#1369)

* Updated Series Info Cards to use OnPush and hooked in progress events when we do a mark as read/unread on entities. These events update progress bars but also will now trigger a re-calculation on Read Time Left.

* Removed Library Card Component

* Refactored manga reader title and subtitle calculation to the backend.

* Coverted card actionables to onPush

* Series Card on push cleanup

* Updated edit collection tags for on push

* Update cover image chooser for on push

* Cleaned up carsouel reel

* Updated cover image to allow for uploading gif and webp files

* Bulk add to collection on push

* Updated bulk operation to use on push. Updated bulk operation to have mark as unread and read buttons explicitly. Updated so add to collection is visible and delete.

Fixed a bug where manage library component wasn't invoking the trackBy function

* Updating entity title for on push

* Removed file info component

* Updated Mange Library for on push

* Entity info cards on push

* List item on push

* Updated icon and title for on push and fixed some missing change detection on series detail

* Restricted the typeahead interface to simplify the design

* Edit Series Relation now shows a value in the dropdown for Parent relationships and disables the field.

* Updated edit series relation to focus on new typeahead when adding a new relationship

* Added some documentation and when Scanning a library, don't allow the user to enqueue the same job multiple times.

* Applied the No-enqueue if already enqueued logic to other tasks

* Library detail on push

* Updated events widget to onpush

* Card detail drawer on push. Card detail cover chooser now will show all chapter's covers for selection in cover chooser.

* Chapter metadata detail on push

* Removed Card Detail modal

* All collections on push

* Removed some comments

* Updated bulk selection to use an observable rather than function calls so new on push strategy works

* collection detail now uses on push and scroller is placed on correct element

* Updated library recommended to on push. Ensure that when mark as read occurs, the appropriate streams are refreshed.

* Updated library detail to on push

* Update metadata fiter to onpush. Bugs found and reported to Project

* person badge on push

* Read more on push

* Updated tag badge to on push

* User login on push

* When initing side nav, don't call an authenticated api until we are sure a user is logged in

* Updated splash container to on push

* Dashboard on push

* Side nav slight refactor around some api calls

* Cleaned up series card on push to use same cdRef naming convention

* Updated Static Files to use caching

* Added width and height to logo image

* shortcuts modal on push

* reading lists on push

* Reading list detail on push

* draggable ordered list on push

* Refactored reading-list-detail to use a new item which drastically reduces renders on operations

* series format on push

* circular loader on push

* Badge Expander on push

* update notification modal on push

* drawer on push

* Edit Series Modal on push

* reset password on push

* review series modal on push

* series metadata detail on push

* theme manager on push

* confirm reset password on push

* register on push

* confirm migration email on push

* confirm email on push

* add email to account migration on push

* user preferences on push. Made global settings default open

* edit series relation on push

* Fixed an edge case bug for next chapter where if the current volume had a single chapter of 1 and the next volume had a chapter number of 0, it would say there are no more chapters.

* Updated infinite scroller with on push support

* Moved some animations over to typeahead, not integrated yet.

* Manga reader is now on push

* Reader settings on push

* refactored how we close the book

* Updated table of contents for on push

* Updated book reader for on push. Fixed a bug where table of contents wasn't showing current page anchor due to a scroll calulation bug

* Small code tweak

* Icon and title on push

* nav header on push

* grouped typeahead on push

* typeahead on push and added a new trackby identity function to allow even faster rendering of big lists

* pdf reader on push

* code cleanup

API/Services/TaskScheduler.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 using API.Data;
@@ -162,8 +163,12 @@ public class TaskScheduler : ITaskScheduler
 
     public void ScanLibrary(int libraryId)
     {
+        if (HasAlreadyEnqueuedTask("ScannerService","ScanLibrary",  new object[] {libraryId}))
+        {
+            _logger.LogInformation("A duplicate request to scan library for library occured. Skipping");
+            return;
+        }
         _logger.LogInformation("Enqueuing library scan for: {LibraryId}", libraryId);
-        // TODO: If a library scan is already queued up for libraryId, don't do anything
         BackgroundJob.Enqueue(() => _scannerService.ScanLibrary(libraryId));
         // When we do a scan, force cache to re-unpack in case page numbers change
         BackgroundJob.Enqueue(() => _cleanupService.CleanupCacheDirectory());
@@ -176,24 +181,48 @@ public class TaskScheduler : ITaskScheduler
 
     public void RefreshMetadata(int libraryId, bool forceUpdate = true)
     {
+        if (HasAlreadyEnqueuedTask("MetadataService","RefreshMetadata",  new object[] {libraryId, forceUpdate}))
+        {
+            _logger.LogInformation("A duplicate request to refresh metadata for library occured. Skipping");
+            return;
+        }
+
         _logger.LogInformation("Enqueuing library metadata refresh for: {LibraryId}", libraryId);
         BackgroundJob.Enqueue(() => _metadataService.RefreshMetadata(libraryId, forceUpdate));
     }
 
     public void RefreshSeriesMetadata(int libraryId, int seriesId, bool forceUpdate = false)
     {
+        if (HasAlreadyEnqueuedTask("MetadataService","RefreshMetadataForSeries",  new object[] {libraryId, seriesId, forceUpdate}))
+        {
+            _logger.LogInformation("A duplicate request to refresh metadata for library occured. Skipping");
+            return;
+        }
+
         _logger.LogInformation("Enqueuing series metadata refresh for: {SeriesId}", seriesId);
         BackgroundJob.Enqueue(() => _metadataService.RefreshMetadataForSeries(libraryId, seriesId, forceUpdate));
     }
 
     public void ScanSeries(int libraryId, int seriesId, bool forceUpdate = false)
     {
+        if (HasAlreadyEnqueuedTask("ScannerService", "ScanSeries", new object[] {libraryId, seriesId, forceUpdate}))
+        {
+            _logger.LogInformation("A duplicate request to scan series occured. Skipping");
+            return;
+        }
+
         _logger.LogInformation("Enqueuing series scan for: {SeriesId}", seriesId);
         BackgroundJob.Enqueue(() => _scannerService.ScanSeries(libraryId, seriesId, CancellationToken.None));
     }
 
     public void AnalyzeFilesForSeries(int libraryId, int seriesId, bool forceUpdate = false)
     {
+        if (HasAlreadyEnqueuedTask("WordCountAnalyzerService", "ScanSeries", new object[] {libraryId, seriesId, forceUpdate}))
+        {
+            _logger.LogInformation("A duplicate request to scan series occured. Skipping");
+            return;
+        }
+
         _logger.LogInformation("Enqueuing analyze files scan for: {SeriesId}", seriesId);
         BackgroundJob.Enqueue(() => _wordCountAnalyzerService.ScanSeries(libraryId, seriesId, forceUpdate));
     }
@@ -212,4 +241,21 @@ public class TaskScheduler : ITaskScheduler
         var update = await _versionUpdaterService.CheckForUpdate();
         await _versionUpdaterService.PushUpdate(update);
     }
+
+    /// <summary>
+    /// Checks if this same invocation is already enqueued
+    /// </summary>
+    /// <param name="methodName">Method name that was enqueued</param>
+    /// <param name="className">Class name the method resides on</param>
+    /// <param name="args">object[] of arguments in the order they are passed to enqueued job</param>
+    /// <param name="queue">Queue to check against. Defaults to "default"</param>
+    /// <returns></returns>
+    private static bool HasAlreadyEnqueuedTask(string className, string methodName, object[] args, string queue = "default")
+    {
+        var enqueuedJobs =  JobStorage.Current.GetMonitoringApi().EnqueuedJobs(queue, 0, int.MaxValue);
+        return enqueuedJobs.Any(j => j.Value.InEnqueuedState &&
+                                     j.Value.Job.Method.DeclaringType != null && j.Value.Job.Args.SequenceEqual(args) &&
+                                     j.Value.Job.Method.Name.Equals(methodName) &&
+                                     j.Value.Job.Method.DeclaringType.Name.Equals(className));
+    }
 }