More Polishing (#428)

# Added
- Added: Added a new button on admin dashboard to clear cache for the whole server

# Changed
- Changed: Moved the download logs to the new System page
- Changed: Tag Badges now show the correct cursor to help indication actions. For example, Collection badges on series detail page can be clicked, while type cannot.

# Fixed
- Fixed: Fixed an issue in develop builds where Pagination no longer worked due to Header not being exposed
- Fixed: After Scanning a series, clear out any cached chapters

=======================================================
* After Scanning a series, clear out any cached chapters.


* Implemented cursor overrides for tag badges

* Fixed pagination no longer working due to Pagination header not being able to be read from the UI.

* Fixed some css things with icons within tagbadges not taking the selection mode styling

* Moved download logs button to the system page

* Implemented the ability to clear cache for the whole server from admin dashboard

* Removed debug code

* Up the Regex Timeout for the Github Build System

API/Controllers/ServerController.cs

@@ -22,15 +22,17 @@ namespace API.Controllers
         private readonly IConfiguration _config;
         private readonly IBackupService _backupService;
         private readonly IArchiveService _archiveService;
+        private readonly ICacheService _cacheService;
 
         public ServerController(IHostApplicationLifetime applicationLifetime, ILogger<ServerController> logger, IConfiguration config,
-            IBackupService backupService, IArchiveService archiveService)
+            IBackupService backupService, IArchiveService archiveService, ICacheService cacheService)
         {
             _applicationLifetime = applicationLifetime;
             _logger = logger;
             _config = config;
             _backupService = backupService;
             _archiveService = archiveService;
+            _cacheService = cacheService;
         }
 
         [HttpPost("restart")]
@@ -42,6 +44,15 @@ namespace API.Controllers
             return Ok();
         }
 
+        [HttpPost("clear-cache")]
+        public ActionResult ClearCache()
+        {
+            _logger.LogInformation("{UserName} is clearing cache of server from admin dashboard", User.GetUsername());
+            _cacheService.Cleanup();
+
+            return Ok();
+        }
+
         /// <summary>
         /// Returns non-sensitive information about the current system
         /// </summary>

API/Extensions/DirectoryInfoExtensions.cs

@@ -79,7 +79,6 @@ namespace API.Extensions
 
             foreach (var subDirectory in directory.EnumerateDirectories())
             {
-                Console.WriteLine($"Flattening {subDirectory}");
                 FlattenDirectory(root, subDirectory, ref directoryIndex);
             }
         }

API/Interfaces/Services/ICacheService.cs

@@ -1,4 +1,5 @@
-using System.Threading.Tasks;
+using System.Collections.Generic;
+using System.Threading.Tasks;
 using API.Entities;
 
 namespace API.Interfaces.Services
@@ -22,11 +23,11 @@ namespace API.Interfaces.Services
         /// Clears cache directory of all volumes. This can be invoked from deleting a library or a series.
         /// </summary>
         /// <param name="chapterIds">Volumes that belong to that library. Assume the library might have been deleted before this invocation.</param>
-        void CleanupChapters(int[] chapterIds);
-        
+        void CleanupChapters(IEnumerable<int> chapterIds);
+
 
         /// <summary>
-        /// Returns the absolute path of a cached page. 
+        /// Returns the absolute path of a cached page.
         /// </summary>
         /// <param name="chapter">Chapter entity with Files populated.</param>
         /// <param name="page">Page number to look for</param>
@@ -35,4 +36,4 @@ namespace API.Interfaces.Services
 
         void EnsureCacheDirectory();
     }
-}
+}

API/Parser/Parser.cs

@@ -11,7 +11,7 @@ namespace API.Parser
     {
         public const string DefaultChapter = "0";
         public const string DefaultVolume = "0";
-        private static readonly TimeSpan RegexTimeout = TimeSpan.FromMilliseconds(250);
+        private static readonly TimeSpan RegexTimeout = TimeSpan.FromMilliseconds(500);
 
         public const string ImageFileExtensions = @"^(\.png|\.jpeg|\.jpg)";
         public const string ArchiveFileExtensions = @"\.cbz|\.zip|\.rar|\.cbr|\.tar.gz|\.7zip|\.7z|\.cb7|\.cbt";
@@ -507,7 +507,8 @@ namespace API.Parser
         // If SP\d+ is in the filename, we force treat it as a special regardless if volume or chapter might have been found.
         private static readonly Regex SpecialMarkerRegex = new Regex(
             @"(?<Special>SP\d+)",
-            RegexOptions.IgnoreCase | RegexOptions.Compiled
+            RegexOptions.IgnoreCase | RegexOptions.Compiled,
+            RegexTimeout
         );
 
 

API/Services/ArchiveService.cs

@@ -301,7 +301,6 @@ namespace API.Services
                     entry.WriteTo(ms);
                     ms.Position = 0;
 
-
                     var serializer = new XmlSerializer(typeof(ComicInfo));
                     var info = (ComicInfo) serializer.Deserialize(ms);
                     return info;

API/Services/BookService.cs

@@ -379,7 +379,6 @@ namespace API.Services
             using var stream = StreamManager.GetStream("BookService.GetPdfPage");
             for (var pageNumber = 0; pageNumber < pages; pageNumber++)
             {
-                // IDEA! Move stream out and use the same stream
                 GetPdfPage(docReader, pageNumber, stream);
                 File.WriteAllBytes(Path.Combine(targetDirectory, "Page-" + pageNumber + ".png"), stream.ToArray());
             }

API/Services/CacheService.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections.Generic;
 using System.IO;
 using System.Linq;
 using System.Threading.Tasks;
@@ -113,7 +114,7 @@ namespace API.Services
             _logger.LogInformation("Cache directory purged");
         }
 
-        public void CleanupChapters(int[] chapterIds)
+        public void CleanupChapters(IEnumerable<int> chapterIds)
         {
             _logger.LogInformation("Running Cache cleanup on Volumes");
 

API/Services/Tasks/ScannerService.cs

@@ -26,16 +26,18 @@ namespace API.Services.Tasks
        private readonly IArchiveService _archiveService;
        private readonly IMetadataService _metadataService;
        private readonly IBookService _bookService;
+       private readonly ICacheService _cacheService;
        private readonly NaturalSortComparer _naturalSort = new ();
 
        public ScannerService(IUnitOfWork unitOfWork, ILogger<ScannerService> logger, IArchiveService archiveService,
-          IMetadataService metadataService, IBookService bookService)
+          IMetadataService metadataService, IBookService bookService, ICacheService cacheService)
        {
           _unitOfWork = unitOfWork;
           _logger = logger;
           _archiveService = archiveService;
           _metadataService = metadataService;
           _bookService = bookService;
+          _cacheService = cacheService;
        }
 
        [DisableConcurrentExecution(timeoutInSeconds: 360)]
@@ -46,6 +48,7 @@ namespace API.Services.Tasks
            var series = await _unitOfWork.SeriesRepository.GetSeriesByIdAsync(seriesId);
            var library = await _unitOfWork.LibraryRepository.GetFullLibraryForIdAsync(libraryId, seriesId);
            var dirs = FindHighestDirectoriesFromFiles(library, files);
+           var chapterIds = await _unitOfWork.SeriesRepository.GetChapterIdsForSeriesAsync(new []{ seriesId });
 
            _logger.LogInformation("Beginning file scan on {SeriesName}", series.Name);
            var scanner = new ParseScannedFiles(_bookService, _logger);
@@ -71,6 +74,7 @@ namespace API.Services.Tasks
                     totalFiles, parsedSeries.Keys.Count, sw.ElapsedMilliseconds + scanElapsedTime, series.Name);
                 CleanupUserProgress();
                 BackgroundJob.Enqueue(() => _metadataService.RefreshMetadata(libraryId, forceUpdate));
+                BackgroundJob.Enqueue(() => _cacheService.CleanupChapters(chapterIds));
             }
             else
             {

API/Startup.cs

@@ -101,7 +101,11 @@ namespace API
             // Ordering is important. Cors, authentication, authorization
             if (env.IsDevelopment())
             {
-                app.UseCors(policy => policy.AllowAnyHeader().AllowAnyMethod().WithOrigins("http://localhost:4200").WithExposedHeaders("Content-Disposition"));
+                app.UseCors(policy => policy
+                    .AllowAnyHeader()
+                    .AllowAnyMethod()
+                    .WithOrigins("http://localhost:4200")
+                    .WithExposedHeaders("Content-Disposition", "Pagination"));
             }
 
             app.UseResponseCaching();