Misc Bugfixes and Cleanup (#1144)

* Moved libraryType into chapter info

* Fixed a bug where you could not reset cover on a series

* Patched in relevant changes from another polish branch

* Refactored invite user setup to shift the checking for accessibility to the backend and always show the link. This will help with users who have some unique setups in docker.

* Refactored invite user to always print the url to setup a new account.

* Single page renderer uses canvasImage rather than re-requesting and relying on cache

* Fixed a rendering issue where fit to split on single on a cover wouldn't force width scaling just for that image

* Fixed a rendering bug with split image functionality

* Added title to copy button

* Fixed a bug in GetContinuePoint when a chapter is added to an already read volume and a new chapter is added loose leaf. The loose leaf would be prioritized over the volume chapter.

Refactored 2 methods from controller into service and unit tested.

* Fixed a bug on opening a volume in series detail that had a chapter added to it after the volume (0 chapter) was read would cause a loose leaf chapter to be opened.

* Added mark as read/actionables on Files in volume detail modal. Fixed a bug where we were showing the wrong page count in a volume detail modal.

* Removed OnDeck page and replaced it with a pre-filtered All-Series. Hooked up the ability to pass read state to the filter via query params. Fixed some spacing on filter post bootstrap update.

* Fixed up some poor documentation on FilterDto.

UI/Web/src/app/admin/invite-user/invite-user.component.html

@@ -9,13 +9,7 @@
         Invite a user to your server. Enter their email in and we will send them an email to create an account.
     </p>
 
-    <p *ngIf="!checkedAccessibility">
-        <span class="spinner-border text-primary" style="width: 1.5rem; height: 1.5rem;" role="status" aria-hidden="true"></span>
-        &nbsp;Checking accessibility of server...
-    </p>
-    
-
-    <form [formGroup]="inviteForm">
+    <form [formGroup]="inviteForm" *ngIf="emailLink === ''">
         <div class="row g-0">
             <div class="mb-3" style="width:100%">
                 <label for="email" class="form-label">Email</label>
@@ -28,11 +22,6 @@
             </div>
         </div>
 
-        <ng-container *ngIf="emailLink !== '' && checkedAccessibility && !accessible">
-            <p>Use this link to finish setting up the user account due to your server not being accessible outside your local network.</p>
-            <a class="email-link" href="{{emailLink}}" target="_blank">{{emailLink}}</a>
-        </ng-container>
-    
         <div class="row g-0">
             <div class="col-md-6">
                 <app-role-selector (selected)="updateRoleSelection($event)" [allowAdmin]="true"></app-role-selector>
@@ -44,12 +33,21 @@
         </div>
     </form>
 
+    <ng-container *ngIf="emailLink !== ''">
+        <h4>User invited</h4>
+        <p>You can use the following link below to setup the account for your user or use the copy button. You may need to log out before using the link to register a new user.
+            If your server is externallyaccessible, an email will have been sent to the user and the links can be used by them to finish setting up their account.
+        </p>
+        <a class="email-link" href="{{emailLink}}" target="_blank">Setup user's account</a>
+        <app-api-key title="Invite Url" tooltipText="Copy this and paste in a new tab. You may need to log out." [showRefresh]="false" [transform]="makeLink"></app-api-key>
+    </ng-container>
+
 </div>
 <div class="modal-footer">
     <button type="button" class="btn btn-secondary" (click)="close()">
         Cancel
     </button>
-    <button type="button" class="btn btn-primary" (click)="invite()" [disabled]="isSending || !inviteForm.valid || !checkedAccessibility || emailLink !== ''">
+    <button type="button" class="btn btn-primary" (click)="invite()" [disabled]="isSending || !inviteForm.valid  || emailLink !== ''">
         <span *ngIf="isSending" class="spinner-border spinner-border-sm" role="status" aria-hidden="true"></span>
         <span>{{isSending ? 'Inviting...' : 'Invite'}}</span>
     </button>

UI/Web/src/app/admin/invite-user/invite-user.component.ts

@@ -3,6 +3,7 @@ import { FormControl, FormGroup, Validators } from '@angular/forms';
 import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap';
 import { ToastrService } from 'ngx-toastr';
 import { ConfirmService } from 'src/app/shared/confirm.service';
+import { InviteUserResponse } from 'src/app/_models/invite-user-response';
 import { Library } from 'src/app/_models/library';
 import { AccountService } from 'src/app/_services/account.service';
 import { ServerService } from 'src/app/_services/server.service';
@@ -19,15 +20,12 @@ export class InviteUserComponent implements OnInit {
    */
   isSending: boolean = false;
   inviteForm: FormGroup = new FormGroup({});
-  /**
-   * If a user would be able to load this server up externally
-   */
-  accessible: boolean = true;
-  checkedAccessibility: boolean = false;
   selectedRoles: Array<string> = [];
   selectedLibraries: Array<number> = [];
   emailLink: string = '';
 
+  makeLink: (val: string) => string = (val: string) => {return this.emailLink};
+
   public get email() { return this.inviteForm.get('email'); }
 
   constructor(public modal: NgbActiveModal, private accountService: AccountService, private serverService: ServerService, 
@@ -35,14 +33,6 @@ export class InviteUserComponent implements OnInit {
 
   ngOnInit(): void {
     this.inviteForm.addControl('email', new FormControl('', [Validators.required]));
-
-    this.serverService.isServerAccessible().subscribe(async (accessibile) => {
-      if (!accessibile) {
-        await this.confirmService.alert('This server is not accessible outside the network. You cannot invite via Email. You wil be given a link to finish registration with instead.');
-        this.accessible = accessibile;
-      }
-      this.checkedAccessibility = true;
-    });
   }
 
   close() {
@@ -57,11 +47,10 @@ export class InviteUserComponent implements OnInit {
       email,
       libraries: this.selectedLibraries,
       roles: this.selectedRoles,
-      sendEmail: this.accessible
-    }).subscribe(emailLink => {
-      this.emailLink = emailLink;
+    }).subscribe((data: InviteUserResponse) => {
+      this.emailLink = data.emailLink;
       this.isSending = false;
-      if (this.accessible) {
+      if (data.emailSent) {
         this.toastr.info('Email sent to ' + email);
         this.modal.close(true);
       }