Misc Polish (#1569)

* Introduced a lock for DB work during the scan to hopefully reduce the concurrency issues

* Don't allow multiple theme scans to occur

* Fixed bulk actions not having all actions due to nested actionable menu changes

* Refactored the Scan loop to be synchronous to avoid any issues. After first loop, no real performance issues.

* Updated the LibraryWatcher when under many internal buffer full issues, to suspend watching for a full hour, to allow whatever downloading to complete.

* Removed Semaphore as it's not needed anymore

* Updated the output for logger to explicitly say from Kavita (if you're pushing to Seq)

* Fixed a broken test

* Fixed ReleaseYear not populating due to a change from a contributor around how to populate ReleaseYear.

* Ensure when scan folder runs, that we don't double enqueue the same tasks.

* Fixed user settings not loading the correct tab

* Changed the Release Year -> Release

* Added more refresh hooks in reader to hopefully ensure faster refreshes

* Reset images between chapter loads to help flush image faster. Don't show broken image icon when an image is still loading.

* Fixed the prefetcher not properly loading the correct images and hence, allowing a bit of lag between chapter loads.

* Code smells

UI/Web/src/app/cards/bulk-operations/bulk-operations.component.ts

@@ -1,6 +1,6 @@
 import { ChangeDetectionStrategy, ChangeDetectorRef, Component, Input, OnDestroy, OnInit } from '@angular/core';
 import { Subject, takeUntil } from 'rxjs';
-import { Action, ActionItem } from 'src/app/_services/action-factory.service';
+import { Action, ActionFactoryService, ActionItem } from 'src/app/_services/action-factory.service';
 import { BulkSelectionService } from '../bulk-selection.service';
 
 @Component({
@@ -24,14 +24,15 @@ export class BulkOperationsComponent implements OnInit, OnDestroy {
     return Action;
   }
 
-  constructor(public bulkSelectionService: BulkSelectionService, private readonly cdRef: ChangeDetectorRef) { }
+  constructor(public bulkSelectionService: BulkSelectionService, private readonly cdRef: ChangeDetectorRef,
+    private actionFactoryService: ActionFactoryService) { }
 
   ngOnInit(): void {
     this.bulkSelectionService.actions$.pipe(takeUntil(this.onDestory)).subscribe(actions => {
-      actions.forEach(a => a.callback = this.actionCallback.bind(this));
-      this.actions = actions;
-      this.hasMarkAsRead = this.actions.filter(act => act.action === Action.MarkAsRead).length > 0;
-      this.hasMarkAsUnread = this.actions.filter(act => act.action === Action.MarkAsUnread).length > 0;
+      // We need to do a recursive callback apply
+      this.actions = this.actionFactoryService.applyCallbackToList(actions, this.actionCallback.bind(this));
+      this.hasMarkAsRead = this.actionFactoryService.hasAction(this.actions, Action.MarkAsRead);
+      this.hasMarkAsUnread = this.actionFactoryService.hasAction(this.actions, Action.MarkAsUnread);
       this.cdRef.markForCheck();
     });
   }
@@ -46,9 +47,7 @@ export class BulkOperationsComponent implements OnInit, OnDestroy {
   }
 
   performAction(action: ActionItem<any>) {
-    if (typeof action.callback === 'function') {
-      action.callback(action, null);
-    }
+    this.actionCallback(action, null);
   }
 
   executeAction(action: Action) {

UI/Web/src/app/cards/bulk-selection.service.ts

@@ -142,16 +142,17 @@ export class BulkSelectionService {
   getActions(callback: (action: ActionItem<any>, data: any) => void) {
     // checks if series is present. If so, returns only series actions
     // else returns volume/chapter items
-    const allowedActions = [Action.AddToReadingList, Action.MarkAsRead, Action.MarkAsUnread, Action.AddToCollection, Action.Delete, Action.AddToWantToReadList, Action.RemoveFromWantToReadList];
+    const allowedActions = [Action.AddToReadingList, Action.MarkAsRead, Action.MarkAsUnread, Action.AddToCollection, 
+      Action.Delete, Action.AddToWantToReadList, Action.RemoveFromWantToReadList];
     if (Object.keys(this.selectedCards).filter(item => item === 'series').length > 0) {
-      return this.actionFactory.getSeriesActions(callback).filter(item => allowedActions.includes(item.action));
+      return this.applyFilterToList(this.actionFactory.getSeriesActions(callback), allowedActions);
     }
 
     if (Object.keys(this.selectedCards).filter(item => item === 'bookmark').length > 0) {
       return this.actionFactory.getBookmarkActions(callback);
     }
 
-    return this.actionFactory.getVolumeActions(callback).filter(item => allowedActions.includes(item.action));
+    return this.applyFilterToList(this.actionFactory.getVolumeActions(callback), allowedActions);
   }
 
   private debugLog(message: string, extraData?: any) {
@@ -163,4 +164,29 @@ export class BulkSelectionService {
       console.log(message);
     }
   }
+
+  private applyFilter(action: ActionItem<any>, allowedActions: Array<Action>) {
+    
+    var ret = false;
+    if (action.action === Action.Submenu || allowedActions.includes(action.action)) {
+      // Do something
+      ret = true;
+    }
+
+    if (action.children === null || action.children?.length === 0) return ret;
+
+    action.children = action.children.filter((childAction) => this.applyFilter(childAction, allowedActions));
+
+    // action.children?.forEach((childAction) => {
+    //   this.applyFilter(childAction, allowedActions);
+    // });
+    return ret;
+  }
+
+	private applyFilterToList(list: Array<ActionItem<any>>, allowedActions: Array<Action>): Array<ActionItem<any>> {
+		const actions = list.map((a) => {
+			return { ...a };
+		});
+    return actions.filter(action => this.applyFilter(action, allowedActions));
+	}
 }

UI/Web/src/app/cards/series-info-cards/series-info-cards.component.html

@@ -1,7 +1,7 @@
 <div class="row g-0 mb-4 mt-3">
     <ng-container *ngIf="seriesMetadata.releaseYear > 0">
         <div class="col-lg-1 col-md-4 col-sm-4 col-4 mb-3">
-            <app-icon-and-title label="Release Year" [clickable]="false" fontClasses="fa-regular fa-calendar" title="Release Year">
+            <app-icon-and-title label="Release" [clickable]="false" fontClasses="fa-regular fa-calendar" title="Release Year">
                 {{seriesMetadata.releaseYear}}
             </app-icon-and-title>
         </div>