From 5c8b124b70c0abe637c8306cff42c07524382ca2 Mon Sep 17 00:00:00 2001
From: Amelia <77553571+Fesaa@users.noreply.github.com>
Date: Fri, 20 Jun 2025 12:13:33 +0200
Subject: [PATCH] Fix empty filters after clicking on know for, don't filter on
 roles for known for Fixes #3858

---
 API/Data/Repositories/PersonRepository.cs               | 3 +--
 UI/Web/src/app/person-detail/person-detail.component.ts | 5 ++---
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/API/Data/Repositories/PersonRepository.cs b/API/Data/Repositories/PersonRepository.cs
index 6954ccf03..541865c9b 100644
--- a/API/Data/Repositories/PersonRepository.cs
+++ b/API/Data/Repositories/PersonRepository.cs
@@ -315,10 +315,9 @@ public class PersonRepository : IPersonRepository
 
     public async Task<IEnumerable<SeriesDto>> GetSeriesKnownFor(int personId)
     {
-        List<PersonRole> notValidRoles = [PersonRole.Location, PersonRole.Team, PersonRole.Other, PersonRole.Publisher, PersonRole.Translator];
         return await _context.Person
             .Where(p => p.Id == personId)
-            .SelectMany(p => p.SeriesMetadataPeople.Where(smp => !notValidRoles.Contains(smp.Role)))
+            .SelectMany(p => p.SeriesMetadataPeople)
             .Select(smp => smp.SeriesMetadata)
             .Select(sm => sm.Series)
             .Distinct()
diff --git a/UI/Web/src/app/person-detail/person-detail.component.ts b/UI/Web/src/app/person-detail/person-detail.component.ts
index ab3c486bd..3e980555d 100644
--- a/UI/Web/src/app/person-detail/person-detail.component.ts
+++ b/UI/Web/src/app/person-detail/person-detail.component.ts
@@ -187,9 +187,8 @@ export class PersonDetailComponent implements OnInit {
     filter.combination = FilterCombination.Or;
     filter.limitTo = 20;
 
-    // I might want to use roles$ to do all this
-    allPeople.forEach(f => {
-      filter.statements.push({comparison: FilterComparison.Contains, value: this.person!.id + '', field: f});
+    roles.forEach(pr => {
+      filter.statements.push({comparison: FilterComparison.Contains, value: this.person!.id + '', field: personRoleForFilterField(pr)});
     });
 
     return filter;