.NET 7 + Spring Cleaning (#1677)

* Updated to net7.0

* Updated GA to .net 7

* Updated System.IO.Abstractions to use New factory.

* Converted Regex into SourceGenerator in Parser.

* Updated more regex to source generators.

* Enabled Nullability and more regex changes throughout codebase.

* Parser is 100% GeneratedRegexified

* Lots of nullability code

* Enabled nullability for all repositories.

* Fixed another unit test

* Refactored some code around and took care of some todos.

* Updating code for nullability and cleaning up methods that aren't used anymore. Refctored all uses of Parser.Normalize() to use new extension

* More nullability exercises. 500 warnings to go.

* Fixed a bug where custom file uploads for entities wouldn't save in webP.

* Nullability is done for all DTOs

* Fixed all unit tests and nullability for the project. Only OPDS is left which will be done with an upcoming OPDS enhancement.

* Use localization in book service after validating

* Code smells

* Switched to preview build of swashbuckle for .net7 support

* Fixed up merge issues

* Disable emulate comic book when on single page reader

* Fixed a regression where double page renderer wouldn't layout the images correctly

* Updated to swashbuckle which support .net 7

* Fixed a bad GA action

* Some code cleanup

* More code smells

* Took care of most of nullable issues

* Fixed a broken test due to having more than one test run in parallel

* I'm really not sure why the unit tests are failing or are so extremely slow on .net 7

* Updated all dependencies

* Fixed up build and removed hardcoded framework from build scripts. (this merge removes Regex Source generators). Unit tests are completely busted.

* Unit tests and code cleanup. Needs shakeout now.

* Adjusted Series model since a few fields are not-nullable. Removed dead imports on the project.

* Refactored to use Builder pattern for all unit tests.

* Switched nullability down to warnings. It wasn't possible to switch due to constraint issues in DB Migration.

API/DTOs/Reader/BookChapterItem.cs

@@ -7,14 +7,14 @@ public class BookChapterItem
     /// <summary>
     /// Name of the Chapter
     /// </summary>
-    public string Title { get; set; }
+    public string Title { get; set; } = default!;
     /// <summary>
     /// A part represents the id of the anchor so we can scroll to it. 01_values.xhtml#h_sVZPaxUSy/
     /// </summary>
-    public string Part { get; set; }
+    public string Part { get; set; } = default!;
     /// <summary>
     /// Page Number to load for the chapter
     /// </summary>
     public int Page { get; set; }
-    public ICollection<BookChapterItem> Children { get; set; }
+    public ICollection<BookChapterItem> Children { get; set; } = default!;
 }

API/DTOs/Reader/BookInfoDto.cs

@@ -4,15 +4,15 @@ namespace API.DTOs.Reader;
 
 public class BookInfoDto : IChapterInfoDto
 {
-    public string BookTitle { get; set; }
+    public string BookTitle { get; set; } = default! ;
     public int SeriesId { get; set; }
     public int VolumeId { get; set; }
     public MangaFormat SeriesFormat { get; set; }
-    public string SeriesName { get; set; }
-    public string ChapterNumber { get; set; }
-    public string VolumeNumber { get; set; }
+    public string SeriesName { get; set; } = default! ;
+    public string ChapterNumber { get; set; } = default! ;
+    public string VolumeNumber { get; set; } = default! ;
     public int LibraryId { get; set; }
     public int Pages { get; set; }
     public bool IsSpecial { get; set; }
-    public string ChapterTitle { get; set; }
+    public string ChapterTitle { get; set; } = default! ;
 }

API/DTOs/Reader/BookmarkInfoDto.cs

@@ -4,7 +4,7 @@ namespace API.DTOs.Reader;
 
 public class BookmarkInfoDto
 {
-    public string SeriesName { get; set; }
+    public string SeriesName { get; set; } = default!;
     public MangaFormat SeriesFormat { get; set; }
     public int SeriesId { get; set; }
     public int LibraryId { get; set; }

API/DTOs/Reader/BulkRemoveBookmarkForSeriesDto.cs

@@ -4,5 +4,5 @@ namespace API.DTOs.Reader;
 
 public class BulkRemoveBookmarkForSeriesDto
 {
-    public ICollection<int> SeriesIds { get; init; }
+    public ICollection<int> SeriesIds { get; init; } = default!;
 }

API/DTOs/Reader/ChapterInfoDto.cs

@@ -11,11 +11,11 @@ public class ChapterInfoDto : IChapterInfoDto
     /// <summary>
     /// The Chapter Number
     /// </summary>
-    public string ChapterNumber { get; set; }
+    public string ChapterNumber { get; set; } = default! ;
     /// <summary>
     /// The Volume Number
     /// </summary>
-    public string VolumeNumber { get; set; }
+    public string VolumeNumber { get; set; } = default! ;
     /// <summary>
     /// Volume entity Id
     /// </summary>
@@ -23,7 +23,7 @@ public class ChapterInfoDto : IChapterInfoDto
     /// <summary>
     /// Series Name
     /// </summary>
-    public string SeriesName { get; set; }
+    public string SeriesName { get; set; } = null!;
     /// <summary>
     /// Series Format
     /// </summary>
@@ -51,7 +51,7 @@ public class ChapterInfoDto : IChapterInfoDto
     /// <summary>
     /// File name of the chapter
     /// </summary>
-    public string FileName { get; set; }
+    public string? FileName { get; set; }
     /// <summary>
     /// If this is marked as a special in Kavita
     /// </summary>
@@ -59,21 +59,22 @@ public class ChapterInfoDto : IChapterInfoDto
     /// <summary>
     /// The subtitle to render on the reader
     /// </summary>
-    public string Subtitle { get; set; }
+    public string? Subtitle { get; set; }
     /// <summary>
     /// Series Title
     /// </summary>
     /// <remarks>Usually just series name, but can include chapter title</remarks>
-    public string Title { get; set; }
+    public string Title { get; set; } = default!;
+
     /// <summary>
     /// List of all files with their inner archive structure maintained in filename and dimensions
     /// </summary>
     /// <remarks>This is optionally returned by includeDimensions</remarks>
-    public IEnumerable<FileDimensionDto> PageDimensions { get; set; }
+    public IEnumerable<FileDimensionDto>? PageDimensions { get; set; }
     /// <summary>
     /// For Double Page reader, this will contain snap points to ensure the reader always resumes on correct page
     /// </summary>
     /// <remarks>This is optionally returned by includeDimensions</remarks>
-    public IDictionary<int, int> DoublePairs { get; set; }
+    public IDictionary<int, int>? DoublePairs { get; set; }
 
 }

API/DTOs/Reader/MarkMultipleSeriesAsReadDto.cs

@@ -4,5 +4,5 @@ namespace API.DTOs.Reader;
 
 public class MarkMultipleSeriesAsReadDto
 {
-    public IReadOnlyList<int> SeriesIds { get; init; }
+    public IReadOnlyList<int> SeriesIds { get; init; } = default!;
 }

API/DTOs/Reader/MarkVolumesReadDto.cs

@@ -11,9 +11,9 @@ public class MarkVolumesReadDto
     /// <summary>
     /// A list of Volumes to mark read
     /// </summary>
-    public IReadOnlyList<int> VolumeIds { get; set; }
+    public IReadOnlyList<int> VolumeIds { get; set; } = default!;
     /// <summary>
     /// A list of additional Chapters to mark as read
     /// </summary>
-    public IReadOnlyList<int> ChapterIds { get; set; }
+    public IReadOnlyList<int> ChapterIds { get; set; } = default!;
 }