.NET 7 + Spring Cleaning (#1677)

* Updated to net7.0

* Updated GA to .net 7

* Updated System.IO.Abstractions to use New factory.

* Converted Regex into SourceGenerator in Parser.

* Updated more regex to source generators.

* Enabled Nullability and more regex changes throughout codebase.

* Parser is 100% GeneratedRegexified

* Lots of nullability code

* Enabled nullability for all repositories.

* Fixed another unit test

* Refactored some code around and took care of some todos.

* Updating code for nullability and cleaning up methods that aren't used anymore. Refctored all uses of Parser.Normalize() to use new extension

* More nullability exercises. 500 warnings to go.

* Fixed a bug where custom file uploads for entities wouldn't save in webP.

* Nullability is done for all DTOs

* Fixed all unit tests and nullability for the project. Only OPDS is left which will be done with an upcoming OPDS enhancement.

* Use localization in book service after validating

* Code smells

* Switched to preview build of swashbuckle for .net7 support

* Fixed up merge issues

* Disable emulate comic book when on single page reader

* Fixed a regression where double page renderer wouldn't layout the images correctly

* Updated to swashbuckle which support .net 7

* Fixed a bad GA action

* Some code cleanup

* More code smells

* Took care of most of nullable issues

* Fixed a broken test due to having more than one test run in parallel

* I'm really not sure why the unit tests are failing or are so extremely slow on .net 7

* Updated all dependencies

* Fixed up build and removed hardcoded framework from build scripts. (this merge removes Regex Source generators). Unit tests are completely busted.

* Unit tests and code cleanup. Needs shakeout now.

* Adjusted Series model since a few fields are not-nullable. Removed dead imports on the project.

* Refactored to use Builder pattern for all unit tests.

* Switched nullability down to warnings. It wasn't possible to switch due to constraint issues in DB Migration.

API/SignalR/EventHub.cs

@@ -1,4 +1,5 @@
 using System.Linq;
+using System;
 using System.Threading.Tasks;
 using API.Data;
 using API.SignalR.Presence;
@@ -54,8 +55,8 @@ public class EventHub : IEventHub
     /// <returns></returns>
     public async Task SendMessageToAsync(string method, SignalRMessage message, int userId)
     {
-        var user = await _unitOfWork.UserRepository.GetUserByIdAsync(userId);
-        await _messageHub.Clients.User(user.UserName).SendAsync(method, message);
+        var user = await _unitOfWork.UserRepository.GetUserByIdAsync(userId) ?? throw new InvalidOperationException();
+        await _messageHub.Clients.User(user.UserName!).SendAsync(method, message);
     }
 
 }

API/SignalR/LogHub.cs

@@ -26,13 +26,13 @@ public class LogHub : Hub<ILogHub>
 
     public override async Task OnConnectedAsync()
     {
-        await _tracker.UserConnected(Context.User.GetUserId(), Context.ConnectionId);
+        await _tracker.UserConnected(Context.User!.GetUserId(), Context.ConnectionId);
         await base.OnConnectedAsync();
     }
 
-    public override async Task OnDisconnectedAsync(Exception exception)
+    public override async Task OnDisconnectedAsync(Exception? exception)
     {
-        await _tracker.UserDisconnected(Context.User.GetUserId(), Context.ConnectionId);
+        await _tracker.UserDisconnected(Context.User!.GetUserId(), Context.ConnectionId);
         await base.OnDisconnectedAsync(exception);
     }
 

API/SignalR/MessageFactory.cs

@@ -1,9 +1,5 @@
 using System;
-using System.Diagnostics;
-using System.IO;
-using System.Threading;
 using API.DTOs.Update;
-using API.Entities;
 using API.Extensions;
 
 namespace API.SignalR;

API/SignalR/MessageHub.cs

@@ -22,7 +22,7 @@ public class MessageHub : Hub
 
     public override async Task OnConnectedAsync()
     {
-        await _tracker.UserConnected(Context.User.GetUserId(), Context.ConnectionId);
+        await _tracker.UserConnected(Context.User!.GetUserId(), Context.ConnectionId);
 
         var currentUsers = await PresenceTracker.GetOnlineUsers();
         await Clients.All.SendAsync(MessageFactory.OnlineUsers, currentUsers);
@@ -31,9 +31,9 @@ public class MessageHub : Hub
         await base.OnConnectedAsync();
     }
 
-    public override async Task OnDisconnectedAsync(Exception exception)
+    public override async Task OnDisconnectedAsync(Exception? exception)
     {
-        await _tracker.UserDisconnected(Context.User.GetUserId(), Context.ConnectionId);
+        await _tracker.UserDisconnected(Context.User!.GetUserId(), Context.ConnectionId);
 
         var currentUsers = await PresenceTracker.GetOnlineUsers();
         await Clients.All.SendAsync(MessageFactory.OnlineUsers, currentUsers);

API/SignalR/Presence/PresenceTracker.cs

@@ -1,5 +1,4 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
 using API.Data;
@@ -18,7 +17,7 @@ public interface IPresenceTracker
 internal class ConnectionDetail
 {
     public string UserName { get; set; }
-    public List<string> ConnectionIds { get; set; }
+    public List<string> ConnectionIds { get; set; } = new List<string>();
     public bool IsAdmin { get; set; }
 }
 
@@ -43,9 +42,9 @@ public class PresenceTracker : IPresenceTracker
         var isAdmin = await _unitOfWork.UserRepository.IsUserAdminAsync(user);
         lock (OnlineUsers)
         {
-            if (OnlineUsers.ContainsKey(userId))
+            if (OnlineUsers.TryGetValue(userId, out var detail))
             {
-                OnlineUsers[userId].ConnectionIds.Add(connectionId);
+                detail.ConnectionIds.Add(connectionId);
             }
             else
             {
@@ -104,7 +103,7 @@ public class PresenceTracker : IPresenceTracker
 
     public Task<List<string>> GetConnectionsForUser(int userId)
     {
-        List<string> connectionIds;
+        List<string>? connectionIds;
         lock (OnlineUsers)
         {
             connectionIds = OnlineUsers.GetValueOrDefault(userId)?.ConnectionIds;

API/SignalR/SignalRMessage.cs

@@ -10,8 +10,8 @@ public class SignalRMessage
     /// <summary>
     /// Body of the event type
     /// </summary>
-    public object Body { get; set; }
-    public string Name { get; set; }
+    public object? Body { get; set; }
+    public required string Name { get; set; }
     /// <summary>
     /// User friendly Title of the Event
     /// </summary>