Misc Cleanup (#977)

* Fixed Day not getting set when reading from epubs.

* Fixed typo for "On Going" to "Ongoing"

* Removed filtering on Reading List page since it doesn't make sense
This commit is contained in:
Joseph Milazzo 2022-01-21 08:08:38 -08:00 committed by GitHub
parent 334221ba88
commit 5f5c24564f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 11 additions and 4 deletions

View file

@ -9,12 +9,13 @@
<span class="badge badge-primary badge-pill" attr.aria-label="{{pagination.totalItems}} total items" *ngIf="pagination != undefined">{{pagination.totalItems}}</span>
</h2>
</div>
<button class="btn btn-secondary btn-small" (click)="collapse.toggle()" [attr.aria-expanded]="!filteringCollapsed" placement="left" ngbTooltip="{{filteringCollapsed ? 'Open' : 'Close'}} Filtering and Sorting" attr.aria-label="{{filteringCollapsed ? 'Open' : 'Close'}} Filtering and Sorting">
<button *ngIf="!filteringDisabled" class="btn btn-secondary btn-small" (click)="collapse.toggle()" [attr.aria-expanded]="!filteringCollapsed" placement="left" ngbTooltip="{{filteringCollapsed ? 'Open' : 'Close'}} Filtering and Sorting" attr.aria-label="{{filteringCollapsed ? 'Open' : 'Close'}} Filtering and Sorting">
<i class="fa fa-filter" aria-hidden="true"></i>
<span class="sr-only">Sort / Filter</span>
</button>
</div>
<div class="phone-hidden">
<div #collapse="ngbCollapse" [(ngbCollapse)]="filteringCollapsed">
<ng-container [ngTemplateOutlet]="filterSection"></ng-container>

View file

@ -57,6 +57,10 @@ export class CardDetailLayoutComponent implements OnInit, OnDestroy {
@Input() isLoading: boolean = false;
@Input() items: any[] = [];
@Input() pagination!: Pagination;
/**
* Should filtering be shown on the page
*/
@Input() filteringDisabled: boolean = false;
/**
* Any actions to exist on the header for the parent collection (library, collection)
*/

View file

@ -8,7 +8,7 @@ export class PublicationStatusPipe implements PipeTransform {
transform(value: PublicationStatus): string {
switch (value) {
case PublicationStatus.OnGoing: return 'On Going';
case PublicationStatus.OnGoing: return 'Ongoing';
case PublicationStatus.Hiatus: return 'Hiatus';
case PublicationStatus.Completed: return 'Completed';

View file

@ -3,6 +3,7 @@
[items]="lists"
[actions]="actions"
[pagination]="pagination"
[filteringDisabled]="true"
(pageChange)="onPageChange($event)"
>
<ng-template #cardItem let-item let-position="idx">