From 85b3187f3faa497b1e51e1eac138cff901974f46 Mon Sep 17 00:00:00 2001 From: Joseph Milazzo Date: Wed, 7 May 2025 16:58:39 -0500 Subject: [PATCH] Added some notes --- API/Services/Plus/ExternalMetadataService.cs | 1 + API/Services/SeriesService.cs | 1 + 2 files changed, 2 insertions(+) diff --git a/API/Services/Plus/ExternalMetadataService.cs b/API/Services/Plus/ExternalMetadataService.cs index f9af923a2..3f44f56d3 100644 --- a/API/Services/Plus/ExternalMetadataService.cs +++ b/API/Services/Plus/ExternalMetadataService.cs @@ -752,6 +752,7 @@ public class ExternalMetadataService : IExternalMetadataService { Name = w.Name, AniListId = ScrobblingService.ExtractId(w.Url, ScrobblingService.AniListCharacterWebsite), + // Can I tag links to resolve favicon? Need to parse html, rewrite the urls, then have a Description = StringHelper.CorrectUrls(StringHelper.RemoveSourceInDescription(StringHelper.SquashBreaklines(w.Description))), }) .Concat(series.Metadata.People diff --git a/API/Services/SeriesService.cs b/API/Services/SeriesService.cs index 805b3b06f..34c55e6ce 100644 --- a/API/Services/SeriesService.cs +++ b/API/Services/SeriesService.cs @@ -633,6 +633,7 @@ public class SeriesService : ISeriesService public async Task FormatChapterTitle(int userId, bool isSpecial, LibraryType libraryType, string chapterRange, string? chapterTitle, bool withHash) { + // TODO: Refactor so this is unit testable if (string.IsNullOrEmpty(chapterTitle) && (isSpecial || libraryType == LibraryType.Book)) throw new ArgumentException("Chapter Title cannot be null"); if (isSpecial)