AZEN-SGG/Kavita
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

A few reading list bug fixes (#3663)

Browse source
This commit is contained in:
Fesaa 2025-03-22 20:39:09 +01:00 • committed by GitHub
parent 0785d4afab
commit a7e1386bad
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 164 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

3
API.Tests/Extensions/SeriesFilterTests.cs
View file

@ -932,7 +932,8 @@ public class SeriesFilterTests : AbstractDbTest
var seriesService = new SeriesService(_unitOfWork, Substitute.For<IEventHub>(),
Substitute.For<ITaskScheduler>(), Substitute.For<ILogger<SeriesService>>(),
Substitute.For<IScrobblingService>(), Substitute.For<ILocalizationService>());
Substitute.For<IScrobblingService>(), Substitute.For<ILocalizationService>(),
Substitute.For<IReadingListService>());
// Select 0 Rating
var zeroRating = await _unitOfWork.SeriesRepository.GetSeriesByIdAsync(2);

87
API.Tests/Services/ReadingListServiceTests.cs
View file

@ -583,6 +583,93 @@ public class ReadingListServiceTests
Assert.Equal(AgeRating.G, readingList.AgeRating);
}
[Fact]
public async Task UpdateReadingListAgeRatingForSeries()
{
await ResetDb();
var spiceAndWolf = new SeriesBuilder("Spice and Wolf")
.WithMetadata(new SeriesMetadataBuilder().Build())
.WithVolumes([
new VolumeBuilder("1")
.WithChapters([
new ChapterBuilder("1").Build(),
new ChapterBuilder("2").Build(),
]).Build()
]).Build();
spiceAndWolf.Metadata.AgeRating = AgeRating.Everyone;
var othersidePicnic = new SeriesBuilder("Otherside Picnic ")
.WithMetadata(new SeriesMetadataBuilder().Build())
.WithVolumes([
new VolumeBuilder("1")
.WithChapters([
new ChapterBuilder("1").Build(),
new ChapterBuilder("2").Build(),
]).Build()
]).Build();
othersidePicnic.Metadata.AgeRating = AgeRating.Everyone;
_context.AppUser.Add(new AppUser()
{
UserName = "Amelia",
ReadingLists = new List<ReadingList>(),
Libraries = new List<Library>
{
new LibraryBuilder("Test Library", LibraryType.LightNovel)
.WithSeries(spiceAndWolf)
.WithSeries(othersidePicnic)
.Build(),
},
});
await _context.SaveChangesAsync();
var user = await _unitOfWork.UserRepository.GetUserByUsernameAsync("Amelia", AppUserIncludes.ReadingLists);
Assert.NotNull(user);
var myTestReadingList = new ReadingListBuilder("MyReadingList").Build();
var mySecondTestReadingList = new ReadingListBuilder("MySecondReadingList").Build();
var myThirdTestReadingList = new ReadingListBuilder("MyThirdReadingList").Build();
user.ReadingLists = new List<ReadingList>()
{
myTestReadingList,
mySecondTestReadingList,
myThirdTestReadingList,
};
await _readingListService.AddChaptersToReadingList(spiceAndWolf.Id, new List<int> {1, 2}, myTestReadingList);
await _readingListService.AddChaptersToReadingList(othersidePicnic.Id, new List<int> {3, 4}, myTestReadingList);
await _readingListService.AddChaptersToReadingList(spiceAndWolf.Id, new List<int> {1, 2}, myThirdTestReadingList);
await _readingListService.AddChaptersToReadingList(othersidePicnic.Id, new List<int> {3, 4}, mySecondTestReadingList);
_unitOfWork.UserRepository.Update(user);
await _unitOfWork.CommitAsync();
await _readingListService.CalculateReadingListAgeRating(myTestReadingList);
await _readingListService.CalculateReadingListAgeRating(mySecondTestReadingList);
Assert.Equal(AgeRating.Everyone, myTestReadingList.AgeRating);
Assert.Equal(AgeRating.Everyone, mySecondTestReadingList.AgeRating);
Assert.Equal(AgeRating.Everyone, myThirdTestReadingList.AgeRating);
await _readingListService.UpdateReadingListAgeRatingForSeries(othersidePicnic.Id, AgeRating.Mature);
await _unitOfWork.CommitAsync();
// Reading lists containing Otherside Picnic are updated
myTestReadingList = await _unitOfWork.ReadingListRepository.GetReadingListByIdAsync(1);
Assert.NotNull(myTestReadingList);
Assert.Equal(AgeRating.Mature, myTestReadingList.AgeRating);
mySecondTestReadingList = await _unitOfWork.ReadingListRepository.GetReadingListByIdAsync(2);
Assert.NotNull(mySecondTestReadingList);
Assert.Equal(AgeRating.Mature, mySecondTestReadingList.AgeRating);
// Unrelated reading list is not updated
myThirdTestReadingList = await _unitOfWork.ReadingListRepository.GetReadingListByIdAsync(3);
Assert.NotNull(myThirdTestReadingList);
Assert.Equal(AgeRating.Everyone, myThirdTestReadingList.AgeRating);
}
#endregion
#region CalculateStartAndEndDates

2
API.Tests/Services/SeriesServiceTests.cs
View file

@ -57,7 +57,7 @@ public class SeriesServiceTests : AbstractDbTest
_seriesService = new SeriesService(_unitOfWork, Substitute.For<IEventHub>(),
Substitute.For<ITaskScheduler>(), Substitute.For<ILogger<SeriesService>>(),
Substitute.For<IScrobblingService>(), locService);
Substitute.For<IScrobblingService>(), locService, Substitute.For<IReadingListService>());
}
#region Setup