AZEN-SGG/Kavita
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Metadata Performance Scan (#921)

Browse source 
* Refactored updating chapter metadata from ComicInfo into the Scan loop. This let's us avoid an additional N file reads (expensive) in the metadata service, as we already have to read them in the scan loop.

* Refactored Series level metadata aggregation into the scan loop. This allows for the batching of DB updates to be much smaller, thus faster without much overhead of GC.

* Refactored some of the code for ProcessFile to remove a few redundant if statements
This commit is contained in:
Joseph Milazzo 2022-01-09 10:36:24 -08:00 • committed by GitHub
parent 7d5694c767
commit ab8c762830
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 308 additions and 284 deletions
Download patch file Download diff file Expand all files Collapse all files

21
API/Services/ReadingItemService.cs
View file

@ -7,7 +7,7 @@ namespace API.Services;
public interface IReadingItemService
{
ComicInfo GetComicInfo(string filePath, MangaFormat format);
ComicInfo GetComicInfo(string filePath);
int GetNumberOfPages(string filePath, MangaFormat format);
string GetCoverImage(string fileFilePath, string fileName, MangaFormat format);
void Extract(string fileFilePath, string targetDirectory, MangaFormat format, int imageCount = 1);
@ -34,13 +34,17 @@ public class ReadingItemService : IReadingItemService
/// Gets the ComicInfo for the file if it exists. Null otherewise.
/// </summary>
/// <param name="filePath">Fully qualified path of file</param>
/// <param name="format">Format of the file determines how we open it (epub vs comicinfo.xml)</param>
/// <returns></returns>
public ComicInfo? GetComicInfo(string filePath, MangaFormat format)
public ComicInfo? GetComicInfo(string filePath)
{
if (format is MangaFormat.Archive or MangaFormat.Epub)
if (Parser.Parser.IsEpub(filePath))
{
return Parser.Parser.IsEpub(filePath) ? _bookService.GetComicInfo(filePath) : _archiveService.GetComicInfo(filePath);
return _bookService.GetComicInfo(filePath);
}
if (Parser.Parser.IsComicInfoExtension(filePath))
{
return _archiveService.GetComicInfo(filePath);
}
return null;
@ -120,6 +124,13 @@ public class ReadingItemService : IReadingItemService
}
}
/// <summary>
/// Parses information out of a file. If file is a book (epub), it will use book metadata regardless of LibraryType
/// </summary>
/// <param name="path"></param>
/// <param name="rootPath"></param>
/// <param name="type"></param>
/// <returns></returns>
public ParserInfo Parse(string path, string rootPath, LibraryType type)
{
return Parser.Parser.IsEpub(path) ? _bookService.ParseInfo(path) : _defaultParser.Parse(path, rootPath, type);