Release Shakeout Day 1 (#1591)

* Fixed an issue where reading list were not able to update their summary due to a duplicate title check.

* Misc code smell cleanup

* Updated .net dependencies and removed unneeded ones

* Fixed an issue where removing a series from want to read list page wouldn't update the page correctly

* Fixed age restriction not applied to Recommended page

* Ensure that Genres and Tags are age restricted gated

* Persons are now age gated as well

* When you choose a cover, the new cover will properly be selected and will focus on it, in the cases there are many other covers available.

* Fixed caching profiles

* Added in a special hook when deleting a library to clear all series Relations before we delete

API/Services/MetadataService.cs

@@ -8,6 +8,7 @@ using API.Data;
 using API.Data.Metadata;
 using API.Data.Repositories;
 using API.Data.Scanner;
+using API.DTOs.Metadata;
 using API.Entities;
 using API.Entities.Enums;
 using API.Extensions;

API/Services/Tasks/Scanner/ParseScannedFiles.cs

@@ -68,6 +68,7 @@ public class ParseScannedFiles
     /// This will Scan all files in a folder path. For each folder within the folderPath, FolderAction will be invoked for all files contained
     /// </summary>
     /// <param name="scanDirectoryByDirectory">Scan directory by directory and for each, call folderAction</param>
+    /// <param name="seriesPaths">A dictionary mapping a normalized path to a list of <see cref="SeriesModified"/> to help scanner skip I/O</param>
     /// <param name="folderPath">A library folder or series folder</param>
     /// <param name="folderAction">A callback async Task to be called once all files for each folder path are found</param>
     /// <param name="forceCheck">If we should bypass any folder last write time checks on the scan and force I/O</param>
@@ -215,6 +216,7 @@ public class ParseScannedFiles
     /// Using a normalized name from the passed ParserInfo, this checks against all found series so far and if an existing one exists with
     /// same normalized name, it merges into the existing one. This is important as some manga may have a slight difference with punctuation or capitalization.
     /// </summary>
+    /// <param name="scannedSeries"></param>
     /// <param name="info"></param>
     /// <returns>Series Name to group this info into</returns>
     private string MergeName(ConcurrentDictionary<ParsedSeries, List<ParserInfo>> scannedSeries, ParserInfo info)

API/Services/Tasks/Scanner/Parser/Parser.cs

@@ -749,12 +749,12 @@ public static class Parser
         foreach (var regex in MangaChapterRegex)
         {
             var matches = regex.Matches(filename);
-            foreach (Match match in matches)
+            foreach (var groups in matches.Select(match => match.Groups))
             {
-                if (!match.Groups["Chapter"].Success || match.Groups["Chapter"] == Match.Empty) continue;
+                if (!groups["Chapter"].Success || groups["Chapter"] == Match.Empty) continue;
 
-                var value = match.Groups["Chapter"].Value;
-                var hasPart = match.Groups["Part"].Success;
+                var value = groups["Chapter"].Value;
+                var hasPart = groups["Part"].Success;
 
                 return FormatValue(value, hasPart);
             }
@@ -778,11 +778,11 @@ public static class Parser
         foreach (var regex in ComicChapterRegex)
         {
             var matches = regex.Matches(filename);
-            foreach (Match match in matches)
+            foreach (var groups in matches.Select(match => match.Groups))
             {
-                if (!match.Groups["Chapter"].Success || match.Groups["Chapter"] == Match.Empty) continue;
-                var value = match.Groups["Chapter"].Value;
-                var hasPart = match.Groups["Part"].Success;
+                if (!groups["Chapter"].Success || groups["Chapter"] == Match.Empty) continue;
+                var value = groups["Chapter"].Value;
+                var hasPart = groups["Part"].Success;
                 return FormatValue(value, hasPart);
 
             }

API/Services/Tasks/ScannerService.cs

@@ -428,7 +428,7 @@ public class ScannerService : IScannerService
     /// <param name="forceUpdate">Defaults to false</param>
     [Queue(TaskScheduler.ScanQueue)]
     [DisableConcurrentExecution(60 * 60 * 60)]
-    [AutomaticRetry(Attempts = 0, OnAttemptsExceeded = AttemptsExceededAction.Delete)]
+    [AutomaticRetry(Attempts = 3, OnAttemptsExceeded = AttemptsExceededAction.Delete)]
     public async Task ScanLibrary(int libraryId, bool forceUpdate = false)
     {
         var sw = Stopwatch.StartNew();

API/Services/TokenService.cs

@@ -75,7 +75,7 @@ public class TokenService : ITokenService
         var username = tokenContent.Claims.FirstOrDefault(q => q.Type == JwtRegisteredClaimNames.NameId)?.Value;
         var user = await _userManager.FindByNameAsync(username);
         if (user == null) return null; // This forces a logout
-        var isValid = await _userManager.VerifyUserTokenAsync(user, TokenOptions.DefaultProvider, "RefreshToken", request.RefreshToken);
+        await _userManager.VerifyUserTokenAsync(user, TokenOptions.DefaultProvider, "RefreshToken", request.RefreshToken);
 
         await _userManager.UpdateSecurityStampAsync(user);