AZEN-SGG/Kavita
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Misc Polishing (#413)

Browse source 
* Ensure that after we assign a role to a user, we show it immediately

* Cached libraryType api as that is not going to change in a viewing session. Moved some components around to tighten bundles.

* Cleaned up more TODOs
* Refactored Configuration to use getter and setters so that the interface is a lot cleaner. Updated HashUtil to use JWT Secret instead of Machine name (as docker machine name is random each boot).
This commit is contained in:
Joseph Milazzo 2021-07-20 21:39:44 -05:00 • committed by GitHub
parent ef5b22b585
commit b8165b311c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
29 changed files with 408 additions and 307 deletions
Download patch file Download diff file Expand all files Collapse all files

2
UI/Web/src/app/admin/_modals/directory-picker/directory-picker.component.ts
View file

@ -42,7 +42,6 @@ export class DirectoryPickerComponent implements OnInit {
}
goBack() {
// BUG: When Going back to initial listing, this code gets stuck on first drive
this.routeStack.pop();
const stackPeek = this.routeStack.peek();
if (stackPeek !== undefined) {
@ -53,7 +52,6 @@ export class DirectoryPickerComponent implements OnInit {
this.currentRoot = '';
this.loadChildren(this.currentRoot);
}
}
loadChildren(path: string) {

6
UI/Web/src/app/admin/_modals/edit-rbs-modal/edit-rbs-modal.component.ts
View file

@ -30,7 +30,7 @@ export class EditRbsModalComponent implements OnInit {
}
close() {
this.modal.close(false);
this.modal.close(undefined);
}
save() {
@ -42,8 +42,10 @@ export class EditRbsModalComponent implements OnInit {
this.memberService.updateMemberRoles(this.member?.username, selectedRoles).subscribe(() => {
if (this.member) {
this.member.roles = selectedRoles;
this.modal.close(this.member);
return;
}
this.modal.close(true);
this.modal.close(undefined);
});
}