From cb37284022c8c82016984629b6efce655e9dfff3 Mon Sep 17 00:00:00 2001 From: Joseph Milazzo Date: Sat, 5 Jul 2025 16:17:04 -0500 Subject: [PATCH] PR comments x2 --- API.Tests/Helpers/BookSortTitlePrefixHelperTests.cs | 3 +-- API.Tests/Services/ScannerServiceTests.cs | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/API.Tests/Helpers/BookSortTitlePrefixHelperTests.cs b/API.Tests/Helpers/BookSortTitlePrefixHelperTests.cs index 4b08e3a6c..973f59de1 100644 --- a/API.Tests/Helpers/BookSortTitlePrefixHelperTests.cs +++ b/API.Tests/Helpers/BookSortTitlePrefixHelperTests.cs @@ -151,11 +151,10 @@ public class BookSortTitlePrefixHelperTests [Theory] [InlineData("三国演义", "三国演义")] // Chinese - no processing due to CJK detection - [InlineData("こんにちは世界", "こんにちは世界")] // Japanese Hiragana - [InlineData("カタカナ", "カタカナ")] // Japanese Katakana [InlineData("한국어", "한국어")] // Korean - not in CJK range, would be processed normally public void TestCjkLanguages(string inputString, string expected) { + // NOTE: These don't do anything, I am waiting for user input on if these are needed Assert.Equal(expected, BookSortTitlePrefixHelper.GetSortTitle(inputString)); } diff --git a/API.Tests/Services/ScannerServiceTests.cs b/API.Tests/Services/ScannerServiceTests.cs index 579f235ba..c337d2311 100644 --- a/API.Tests/Services/ScannerServiceTests.cs +++ b/API.Tests/Services/ScannerServiceTests.cs @@ -980,7 +980,6 @@ public class ScannerServiceTests : AbstractDbTest var library = await _scannerHelper.GenerateScannerData(testcase); - // Disable metadata library.RemovePrefixForSortName = true; UnitOfWork.LibraryRepository.Update(library); await UnitOfWork.CommitAsync();