From d027094f4676658d2f1b3cba2bebcb184c9605f3 Mon Sep 17 00:00:00 2001 From: Joseph Milazzo Date: Sat, 28 Jun 2025 08:00:22 -0500 Subject: [PATCH] Sanitize Koreader progress data in logs --- API/Controllers/KoreaderController.cs | 3 ++- API/Services/KoreaderService.cs | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/API/Controllers/KoreaderController.cs b/API/Controllers/KoreaderController.cs index 566b190ce..8c4c41585 100644 --- a/API/Controllers/KoreaderController.cs +++ b/API/Controllers/KoreaderController.cs @@ -6,6 +6,7 @@ using API.Data; using API.Data.Repositories; using API.DTOs.Koreader; using API.Entities; +using API.Extensions; using API.Services; using Kavita.Common; using Microsoft.AspNetCore.Identity; @@ -94,7 +95,7 @@ public class KoreaderController : BaseApiController { var userId = await GetUserId(apiKey); var response = await _koreaderService.GetProgress(ebookHash, userId); - _logger.LogDebug("Koreader response progress for User ({UserId}): {Progress}", userId, response.Progress); + _logger.LogDebug("Koreader response progress for User ({UserId}): {Progress}", userId, response.Progress.Sanitize()); return Ok(response); } diff --git a/API/Services/KoreaderService.cs b/API/Services/KoreaderService.cs index db8522b25..a38e8c468 100644 --- a/API/Services/KoreaderService.cs +++ b/API/Services/KoreaderService.cs @@ -2,6 +2,7 @@ using System.Threading.Tasks; using API.Data; using API.DTOs.Koreader; using API.DTOs.Progress; +using API.Extensions; using API.Helpers; using API.Helpers.Builders; using Kavita.Common; @@ -39,7 +40,7 @@ public class KoreaderService : IKoreaderService /// public async Task SaveProgress(KoreaderBookDto koreaderBookDto, int userId) { - _logger.LogDebug("Saving Koreader progress for User ({UserId}): {KoreaderProgress}", userId, koreaderBookDto.Progress); + _logger.LogDebug("Saving Koreader progress for User ({UserId}): {KoreaderProgress}", userId, koreaderBookDto.Progress.Sanitize()); var file = await _unitOfWork.MangaFileRepository.GetByKoreaderHash(koreaderBookDto.Document); if (file == null) throw new KavitaException(await _localizationService.Translate(userId, "file-missing"));