Performance, Scan Loop, Specials, and cleanup (#150)

* More cases for parsing regex

* Fixed a bug where chapter cover images weren't being updated due to a missed not.

* Removed a piece of code that was needed for upgrading, since all beta users agreed to wipe db.

* Fixed InProgress to properly respect order and show more recent activity first. Issue is with IEntityDate LastModified not updating in DataContext.

* Updated dependencies to lastest stable.

* LastModified on Volumes wasn't updating, validated it does update when data is changed.

* Rewrote a check to avoid a small heap object warning.

* Ensure UpdateSeries checks all libraries for unique name.

* Took care of some todos, removed unused imports, on dev go ahead and schedule reoocuring jobs since LiteDB caused the locking issue.

* No Tracking when we aren't using entities.

* Added code to remove abandoned progress rows after a chapter gets deleted.

* RefreshMetadata uses one large query rather than many trips to DB for updating metadata. Significantly faster.

* Fixed a bug where UpdateSeries would always complain about a unique name even when we weren't updating name.

* Files that are linked to a series but can't parse out Vol/Chapter information are properly grouped like other Specials.

* Refresh metadata on UI should call the task directly

* Fixed a bug on updating series to make sure we don't complain if we aren't trying to update the name to an existing name.

* Fixed #142 - Library cards should be sorted.

* Refactored the name of some variables to be more agnostic to comics.

* Implemented ScanLibrary but abandoning it.

* Code Cleanup & removing ScanSeries code.

* Some more tests and new Comparators for natural sorting.

* Fixed #137 - When performing I/O on archives, ignore __MACOSX folders completely.

* Fixed #137 - When performing I/O on archives, ignore __MACOSX folders completely.

* All entities that will show under specials tab should be marked special, rather than just what has a special keyword.

* Don't let specials generate cover images

* Don't let specials generate cover images

* SearchResults should send LocalizedName back since we are searching against it.

* Added some tests around macosx folders found from my actual server.

* Put extra notes about a case where duplicates come about, logger will now tell user about this issue.

* Missed a build issue somehow...

* Some code smells

API.Tests/Comparers/ChapterSortComparerTest.cs

@@ -2,7 +2,7 @@
 using API.Comparators;
 using Xunit;
 
-namespace API.Tests
+namespace API.Tests.Comparers
 {
     public class ChapterSortComparerTest
     {

API.Tests/Comparers/NaturalSortComparerTest.cs

@@ -0,0 +1,31 @@
+using System;
+using API.Comparators;
+using Xunit;
+
+namespace API.Tests.Comparers
+{
+    public class NaturalSortComparerTest
+    {
+        [Theory]
+        [InlineData(
+            new[] {"x1.jpg", "x10.jpg", "x3.jpg", "x4.jpg", "x11.jpg"}, 
+            new[] {"x1.jpg", "x3.jpg", "x4.jpg", "x10.jpg", "x11.jpg"}
+        )]
+        [InlineData(
+            new[] {"Beelzebub_153b_RHS.zip", "Beelzebub_01_[Noodles].zip",}, 
+            new[] {"Beelzebub_01_[Noodles].zip", "Beelzebub_153b_RHS.zip"}
+        )]
+        public void TestNaturalSortComparer(string[] input, string[] expected)
+        {
+            NaturalSortComparer nc = new NaturalSortComparer();
+            Array.Sort(input, nc);
+
+            var i = 0;
+            foreach (var s in input)
+            {
+                Assert.Equal(s, expected[i]);
+                i++;
+            }
+        }
+    }
+}

API.Tests/Comparers/StringLogicalComparerTest.cs

@@ -2,7 +2,7 @@
 using API.Comparators;
 using Xunit;
 
-namespace API.Tests.Services
+namespace API.Tests.Comparers
 {
     public class StringLogicalComparerTest
     {

API.Tests/ParserTest.cs

@@ -59,6 +59,7 @@ namespace API.Tests
         [InlineData("Volume 12 - Janken Boy is Coming!.cbz", "12")]
         [InlineData("[dmntsf.net] One Piece - Digital Colored Comics Vol. 20 Ch. 177 - 30 Million vs 81 Million.cbz", "20")]
         [InlineData("Gantz.V26.cbz", "26")]
+        [InlineData("NEEDLESS_Vol.4_-Simeon_6_v2[SugoiSugoi].rar", "4")]
         public void ParseVolumeTest(string filename, string expected)
         {
             Assert.Equal(expected, ParseVolume(filename));
@@ -176,6 +177,8 @@ namespace API.Tests
         [InlineData("Umineko no Naku Koro ni - Episode 3 - Banquet of the Golden Witch #02.cbz", "2")]
         [InlineData("To Love Ru v09 Uncensored (Ch.071-079).cbz", "71-79")]
         [InlineData("Corpse Party -The Anthology- Sachikos game of love Hysteric Birthday 2U Extra Chapter.rar", "0")]
+        [InlineData("Beelzebub_153b_RHS.zip", "153.5")]
+        [InlineData("Beelzebub_150-153b_RHS.zip", "150-153.5")]
         public void ParseChaptersTest(string filename, string expected)
         {
             Assert.Equal(expected, ParseChapter(filename));
@@ -284,6 +287,7 @@ namespace API.Tests
         [InlineData("Teen Titans v1 001 (1966-02) (digital) (OkC.O.M.P.U.T.O.-Novus)", "Teen Titans")]
         [InlineData("Scott Pilgrim 02 - Scott Pilgrim vs. The World (2005)", "Scott Pilgrim")]
         [InlineData("Wolverine - Origins 003 (2006) (digital) (Minutemen-PhD)", "Wolverine - Origins")]
+        [InlineData("Invincible Vol 01 Family matters (2005) (Digital).cbr", "Invincible")]
         public void ParseComicSeriesTest(string filename, string expected)
         {
             Assert.Equal(expected, ParseComicSeries(filename));

API.Tests/Services/ArchiveServiceTests.cs

@@ -58,6 +58,9 @@ namespace API.Tests.Services
         [InlineData("file in folder in folder.zip", 1)]
         [InlineData("file in folder.zip", 1)]
         [InlineData("file in folder_alt.zip", 1)]
+        [InlineData("macos_none.zip", 0)]
+        [InlineData("macos_one.zip", 1)]
+        [InlineData("macos_native.zip", 21)]
         public void GetNumberOfPagesFromArchiveTest(string archivePath, int expected)
         {
             var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/ArchiveService/Archives");
@@ -118,6 +121,7 @@ namespace API.Tests.Services
         [InlineData("v10 - with folder.cbz", "v10 - with folder.expected.jpg")]
         [InlineData("v10 - nested folder.cbz", "v10 - nested folder.expected.jpg")]
         //[InlineData("png.zip", "png.PNG")]
+        [InlineData("macos_native.zip", "macos_native.jpg")]
         public void GetCoverImageTest(string inputFile, string expectedOutputFile)
         {
             var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/ArchiveService/CoverImages");
@@ -128,10 +132,11 @@ namespace API.Tests.Services
         }
 
         [Theory]
-        [InlineData("06_v01[DMM].zip")]
+        [InlineData("Archives/macos_native.zip")]
+        [InlineData("Formats/One File with DB_Supported.zip")]
         public void CanParseCoverImage(string inputFile)
         {
-            var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/ArchiveService/Archives");
+            var testDirectory = Path.Join(Directory.GetCurrentDirectory(), "../../../Services/Test Data/ArchiveService/");
             Assert.NotEmpty(_archiveService.GetCoverImage(Path.Join(testDirectory, inputFile)));
         }