Release Testing Day 1 (#1491)

* Fixed a bug where typeahead wouldn't automatically show results on relationship screen without an additional click.

* Tweaked the code which checks if a modification occured to check on seconds rather than minutes

* Clear cache will now clear temp/ directory as well.

* Fixed an issue where Chrome was caching api responses when it shouldn't had.

* Added a cleanup temp code

* Ensure genres get removed during series scan when removed from metadata.

* Fixed a bug where all epubs with a volume would show as Volume 0 in reading list

* When a scan is in progress, don't let the user delete the library.

API/Services/Tasks/CleanupService.cs

@@ -20,6 +20,7 @@ namespace API.Services.Tasks
         Task DeleteChapterCoverImages();
         Task DeleteTagCoverImages();
         Task CleanupBackups();
+        void CleanupTemp();
     }
     /// <summary>
     /// Cleans up after operations on reoccurring basis
@@ -127,16 +128,18 @@ namespace API.Services.Tasks
         }
 
         /// <summary>
-        /// Removes all files and directories in the cache directory
+        /// Removes all files and directories in the cache and temp directory
         /// </summary>
         public void CleanupCacheDirectory()
         {
             _logger.LogInformation("Performing cleanup of Cache directory");
             _directoryService.ExistOrCreate(_directoryService.CacheDirectory);
+            _directoryService.ExistOrCreate(_directoryService.TempDirectory);
 
             try
             {
                 _directoryService.ClearDirectory(_directoryService.CacheDirectory);
+                _directoryService.ClearDirectory(_directoryService.TempDirectory);
             }
             catch (Exception ex)
             {
@@ -175,5 +178,22 @@ namespace API.Services.Tasks
             }
             _logger.LogInformation("Finished cleanup of Database backups at {Time}", DateTime.Now);
         }
+
+        public void CleanupTemp()
+        {
+            _logger.LogInformation("Performing cleanup of Temp directory");
+            _directoryService.ExistOrCreate(_directoryService.TempDirectory);
+
+            try
+            {
+                _directoryService.ClearDirectory(_directoryService.TempDirectory);
+            }
+            catch (Exception ex)
+            {
+                _logger.LogError(ex, "There was an issue deleting one or more folders/files during cleanup");
+            }
+
+            _logger.LogInformation("Temp directory purged");
+        }
     }
 }

API/Services/Tasks/Scanner/ParseScannedFiles.cs

@@ -289,12 +289,19 @@ namespace API.Services.Tasks.Scanner
             await _eventHub.SendMessageAsync(MessageFactory.NotificationProgress, MessageFactory.FileScanProgressEvent("File Scan Done", libraryName, ProgressEventType.Ended));
         }
 
+        /// <summary>
+        /// Checks against all folder paths on file if the last scanned is >= the directory's last write down to the second
+        /// </summary>
+        /// <param name="seriesPaths"></param>
+        /// <param name="normalizedFolder"></param>
+        /// <param name="forceCheck"></param>
+        /// <returns></returns>
         private bool HasSeriesFolderNotChangedSinceLastScan(IDictionary<string, IList<SeriesModified>> seriesPaths, string normalizedFolder, bool forceCheck = false)
         {
             if (forceCheck) return false;
 
-            return seriesPaths.ContainsKey(normalizedFolder) && seriesPaths[normalizedFolder].All(f => f.LastScanned.Truncate(TimeSpan.TicksPerMinute) >=
-                _directoryService.GetLastWriteTime(normalizedFolder).Truncate(TimeSpan.TicksPerMinute));
+            return seriesPaths.ContainsKey(normalizedFolder) && seriesPaths[normalizedFolder].All(f => f.LastScanned.Truncate(TimeSpan.TicksPerSecond) >=
+                _directoryService.GetLastWriteTime(normalizedFolder).Truncate(TimeSpan.TicksPerSecond));
         }
 
         /// <summary>

API/Services/Tasks/Scanner/ProcessSeries.cs

@@ -375,6 +375,13 @@ public class ProcessSeries : IProcessSeries
             }
         }
 
+        var genres = chapters.SelectMany(c => c.Genres).ToList();
+        GenreHelper.KeepOnlySameGenreBetweenLists(series.Metadata.Genres.ToList(), genres, genre =>
+        {
+            if (series.Metadata.GenresLocked) return;
+            series.Metadata.Genres.Remove(genre);
+        });
+
         // NOTE: The issue here is that people is just from chapter, but series metadata might already have some people on it
         // I might be able to filter out people that are in locked fields?
         var people = chapters.SelectMany(c => c.People).ToList();