Filtering Bugfixes (#1220)

* Cleaned up random strings and unified them in one place.

* Implemented the ability to disable typeaheads

* Refactored disable state to disable controls on filter

* Fixed an overflow regression on title

* Updated ComicInfo DTO which had some bad properties on it

* Cleaned up some code around disabled typeaheads/filters

* Fixed typeaheads causing resets to state and mucking up filter presets

* Fixed state not refreshing between page loads

* Fixed a bad parsing for My Charms Are Wasted on Kuroiwa Medaka - Ch. 37.5 - Volume Extras

* Cleanup within the metadata filter to reuse logic and minimize extra loops.

* Fixed a timing issue with typeahead and first load for people

* Fixed a bug in Publication Status for a given library, which would fail due to not performing some of the query in memory. Removed a custom index on Series table that wasn't used and potentially caused constraint issues.

* Added a wiki link for stats collections

* Security bump

* Fixed the regex

API/Data/Metadata/ComicInfo.cs

@@ -47,11 +47,11 @@ namespace API.Data.Metadata
         /// </summary>
         public float UserRating { get; set; }
 
-        public string AlternateSeries { get; set; } = string.Empty;
         public string StoryArc { get; set; } = string.Empty;
         public string SeriesGroup { get; set; } = string.Empty;
-        public string AlternativeSeries { get; set; } = string.Empty;
-        public string AlternativeNumber { get; set; } = string.Empty;
+        public string AlternateNumber { get; set; } = string.Empty;
+        public int AlternateCount { get; set; } = 0;
+        public string AlternateSeries { get; set; } = string.Empty;
 
         /// <summary>
         /// This is Epub only: calibre:title_sort

API/Data/Migrations/20220416211340_RemoveCustomIndex.cs

@@ -0,0 +1,25 @@
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace API.Data.Migrations
+{
+    public partial class RemoveCustomIndex : Migration
+    {
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropIndex(
+                name: "IX_Series_Name_NormalizedName_LocalizedName_LibraryId_Format",
+                table: "Series");
+        }
+
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.CreateIndex(
+                name: "IX_Series_Name_NormalizedName_LocalizedName_LibraryId_Format",
+                table: "Series",
+                columns: new[] { "Name", "NormalizedName", "LocalizedName", "LibraryId", "Format" },
+                unique: true);
+        }
+    }
+}

API/Data/Migrations/DataContextModelSnapshot.cs

@@ -744,9 +744,6 @@ namespace API.Data.Migrations
 
                     b.HasIndex("LibraryId");
 
-                    b.HasIndex("Name", "NormalizedName", "LocalizedName", "LibraryId", "Format")
-                        .IsUnique();
-
                     b.ToTable("Series");
                 });
 

API/Data/Repositories/SeriesRepository.cs

@@ -94,7 +94,7 @@ public interface ISeriesRepository
     Task<IList<SeriesMetadata>> GetSeriesMetadataForIdsAsync(IEnumerable<int> seriesIds);
     Task<IList<AgeRatingDto>> GetAllAgeRatingsDtosForLibrariesAsync(List<int> libraryIds);
     Task<IList<LanguageDto>> GetAllLanguagesForLibrariesAsync(List<int> libraryIds);
-    Task<IList<PublicationStatusDto>> GetAllPublicationStatusesDtosForLibrariesAsync(List<int> libraryIds);
+    IEnumerable<PublicationStatusDto> GetAllPublicationStatusesDtosForLibrariesAsync(List<int> libraryIds);
     Task<IEnumerable<GroupedSeriesDto>> GetRecentlyUpdatedSeries(int userId, int pageSize = 30);
 }
 
@@ -884,19 +884,19 @@ public class SeriesRepository : ISeriesRepository
             .ToList();
     }
 
-    public async Task<IList<PublicationStatusDto>> GetAllPublicationStatusesDtosForLibrariesAsync(List<int> libraryIds)
+    public IEnumerable<PublicationStatusDto> GetAllPublicationStatusesDtosForLibrariesAsync(List<int> libraryIds)
     {
-        return await _context.Series
+        return  _context.Series
             .Where(s => libraryIds.Contains(s.LibraryId))
             .Select(s => s.Metadata.PublicationStatus)
             .Distinct()
+            .AsEnumerable()
             .Select(s => new PublicationStatusDto()
             {
                 Value = s,
                 Title = s.ToDescription()
             })
-            .OrderBy(s => s.Title)
-            .ToListAsync();
+            .OrderBy(s => s.Title);
     }