Address PR comments

This commit is contained in:
Amelia 2025-06-14 16:14:11 +02:00
parent 21fc91262c
commit ea2549fdf2
No known key found for this signature in database
GPG key ID: D6D0ECE365407EAA
5 changed files with 18 additions and 18 deletions

View file

@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.ComponentModel;
using API.Entities.Enums;
using API.Entities.Enums.UserPreferences;
@ -6,9 +7,13 @@ namespace API.Entities;
public enum BreakPoint
{
[Description("Never")]
Never = 0,
[Description("Mobile")]
Mobile = 1,
[Description("Tablet")]
Tablet = 2,
[Description("Desktop")]
Desktop = 3,
}

View file

@ -11,13 +11,13 @@ export class BreakpointPipe implements PipeTransform {
const v = parseInt(value + '', 10) as UserBreakpoint;
switch (v) {
case UserBreakpoint.Never:
return translate('preferences.breakpoints.never');
return translate('breakpoint-pipe.never');
case UserBreakpoint.Mobile:
return translate('preferences.breakpoints.mobile');
return translate('breakpoint-pipe.mobile');
case UserBreakpoint.Tablet:
return translate('preferences.breakpoints.tablet');
return translate('breakpoint-pipe.tablet');
case UserBreakpoint.Desktop:
return translate('preferences.breakpoints.desktop');
return translate('breakpoint-pipe.desktop');
}
throw new Error("unknown breakpoint value: " + value);
}

View file

@ -10,7 +10,7 @@
</div>
<p class="ps-2">{{t('description')}}</p>
<p class="ps-2 text-muted">{{t('extra-tip')}} <a target="_blank" [href]="WikiLink.ReadingProfiles">{{t('wiki-title')}}</a></p>
<p class="ps-2 text-muted">{{t('extra-tip')}} <a target="_blank" rel="noopener noreferrer" [href]="WikiLink.ReadingProfiles">{{t('wiki-title')}}</a></p>
<div class="row g-0 ">
@ -46,7 +46,7 @@
<div class="mb-2 d-flex justify-content-between align-items-center">
<app-setting-item [title]="''" [showEdit]="false" [canEdit]="selectedProfile.kind !== ReadingProfileKind.Default">
<ng-template #view>
<span [class.cursor-click]="selectedProfile.kind !== ReadingProfileKind.Default">
<span [class.clickable]="selectedProfile.kind !== ReadingProfileKind.Default">
{{readingProfileForm.get('name')!.value}}
</span>
</ng-template>

View file

@ -1,10 +1,5 @@
@use '../../../series-detail-common';
.cursor-click {
cursor: pointer;
}
.group-item {
background-color: transparent;

View file

@ -2820,13 +2820,13 @@
"pdf-odd": "Odd",
"pdf-even": "Even",
"pdf-light": "Light",
"pdf-dark": "Dark",
"breakpoints": {
"never": "Never",
"mobile": "Mobile",
"tablet": "Tablet",
"desktop": "Desktop"
}
"pdf-dark": "Dark"
},
"breakpoint-pipe": {
"never": "Never",
"mobile": "Mobile",
"tablet": "Tablet",
"desktop": "Desktop"
},
"manage-reading-profiles": {