Account Email Support (#1000)

* Moved the Server Settings out into a button on nav header

* Refactored Mange Users page to the new design (skeleton). Implemented skeleton code for Invite User.

* Hashed out more of the code, but need to move all the email code to a Kavita controlled API server due to password credentials.

* Cleaned up some warnings

* When no user exists for an api key in Plugin controller, throw 401.

* Hooked in the ability to check if the Kavita instance can be accessed externally so we can determine if the user can invite or not.

* Hooked up some logic if the user's server isn't accessible, then default to old flow

* Basic flow is working for confirm email. Needs validation, error handling, etc.

* Refactored Password validation to account service

* Cleaned up the code in confirm-email to work much better.

* Refactored the login page to have a container functionality, so we can reuse the styles on multiple pages (registration pages). Hooked up the code for confirm email.

* Messy code, but making progress. Refactored Register to be used only for first time user registration. Added a new register component to handle first time flow only.

* Invite works much better, still needs a bit of work for non-accessible server setup. Started work on underlying manage users page to meet new design.

* Changed (you) to a star to indicate who you're logged in as.

* Inviting a user is now working and tested fully.

* Removed the register member component as we now have invite and confirm components.

* Editing a user is now working. Username change and Role/Library access from within one screen. Email changing is on hold.

* Cleaned up code for edit user and disabled email field for now.

* Cleaned up the code to indicate changing a user's email is not possible.

* Implemented a migration for existing accounts so they can validate their emails and still login.

* Change url for email server

* Implemented the ability to resend an email confirmation code (or regenerate for non accessible servers). Fixed an overflow on the confirm dialog.

* Took care of some code cleanup

* Removed 3 db calls from cover refresh and some misc cleanup

* Fixed a broken test

API/Data/MigrateConfigFiles.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.IO.Abstractions;
 using System.Linq;
 using API.Services;
 using Kavita.Common;

API/Data/Repositories/LibraryRepository.cs

@@ -1,4 +1,5 @@
 using System;
+using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
@@ -36,6 +37,7 @@ public interface ILibraryRepository
     Task<bool> DeleteLibrary(int libraryId);
     Task<IEnumerable<Library>> GetLibrariesForUserIdAsync(int userId);
     Task<LibraryType> GetLibraryTypeAsync(int libraryId);
+    Task<IEnumerable<Library>> GetLibraryForIdsAsync(IList<int> libraryIds);
 }
 
 public class LibraryRepository : ILibraryRepository
@@ -108,6 +110,13 @@ public class LibraryRepository : ILibraryRepository
             .SingleAsync();
     }
 
+    public async Task<IEnumerable<Library>> GetLibraryForIdsAsync(IList<int> libraryIds)
+    {
+        return await _context.Library
+            .Where(x => libraryIds.Contains(x.Id))
+            .ToListAsync();
+    }
+
     public async Task<IEnumerable<LibraryDto>> GetLibraryDtosAsync()
     {
         return await _context.Library

API/Data/Repositories/TagRepository.cs

@@ -50,13 +50,13 @@ public class TagRepository : ITagRepository
 
     public async Task RemoveAllTagNoLongerAssociated(bool removeExternal = false)
     {
-        var TagsWithNoConnections = await _context.Tag
+        var tagsWithNoConnections = await _context.Tag
             .Include(p => p.SeriesMetadatas)
             .Include(p => p.Chapters)
             .Where(p => p.SeriesMetadatas.Count == 0 && p.Chapters.Count == 0 && p.ExternalTag == removeExternal)
             .ToListAsync();
 
-        _context.Tag.RemoveRange(TagsWithNoConnections);
+        _context.Tag.RemoveRange(tagsWithNoConnections);
 
         await _context.SaveChangesAsync();
     }

API/Data/Repositories/UserRepository.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.ComponentModel.DataAnnotations;
 using System.Linq;
 using System.Threading.Tasks;
 using API.Constants;
@@ -20,7 +21,8 @@ public enum AppUserIncludes
     Progress = 2,
     Bookmarks = 4,
     ReadingLists = 8,
-    Ratings = 16
+    Ratings = 16,
+    UserPreferences = 32
 }
 
 public interface IUserRepository
@@ -29,7 +31,8 @@ public interface IUserRepository
     void Update(AppUserPreferences preferences);
     void Update(AppUserBookmark bookmark);
     public void Delete(AppUser user);
-    Task<IEnumerable<MemberDto>>  GetMembersAsync();
+    Task<IEnumerable<MemberDto>>  GetEmailConfirmedMemberDtosAsync();
+    Task<IEnumerable<MemberDto>> GetPendingMemberDtosAsync();
     Task<IEnumerable<AppUser>> GetAdminUsersAsync();
     Task<IEnumerable<AppUser>> GetNonAdminUsersAsync();
     Task<bool> IsUserAdminAsync(AppUser user);
@@ -48,6 +51,7 @@ public interface IUserRepository
     Task<int> GetUserIdByUsernameAsync(string username);
     Task<AppUser> GetUserWithReadingListsByUsernameAsync(string username);
     Task<IList<AppUserBookmark>> GetAllBookmarksByIds(IList<int> bookmarkIds);
+    Task<AppUser> GetUserByEmailAsync(string email);
 }
 
 public class UserRepository : IUserRepository
@@ -156,6 +160,13 @@ public class UserRepository : IUserRepository
             query = query.Include(u => u.Ratings);
         }
 
+        if (includeFlags.HasFlag(AppUserIncludes.UserPreferences))
+        {
+            query = query.Include(u => u.UserPreferences);
+        }
+
+
+
         return query;
     }
 
@@ -198,6 +209,11 @@ public class UserRepository : IUserRepository
             .ToListAsync();
     }
 
+    public async Task<AppUser> GetUserByEmailAsync(string email)
+    {
+        return await _context.AppUser.SingleOrDefaultAsync(u => u.Email.Equals(email));
+    }
+
     public async Task<IEnumerable<AppUser>> GetAdminUsersAsync()
     {
         return await _userManager.GetUsersInRoleAsync(PolicyConstants.AdminRole);
@@ -280,9 +296,10 @@ public class UserRepository : IUserRepository
     }
 
 
-    public async Task<IEnumerable<MemberDto>> GetMembersAsync()
+    public async Task<IEnumerable<MemberDto>> GetEmailConfirmedMemberDtosAsync()
     {
         return await _context.Users
+            .Where(u => u.EmailConfirmed)
             .Include(x => x.Libraries)
             .Include(r => r.UserRoles)
             .ThenInclude(r => r.Role)
@@ -291,6 +308,7 @@ public class UserRepository : IUserRepository
             {
                 Id = u.Id,
                 Username = u.UserName,
+                Email = u.Email,
                 Created = u.Created,
                 LastActive = u.LastActive,
                 Roles = u.UserRoles.Select(r => r.Role.Name).ToList(),
@@ -305,4 +323,42 @@ public class UserRepository : IUserRepository
             .AsNoTracking()
             .ToListAsync();
     }
+
+    public async Task<IEnumerable<MemberDto>> GetPendingMemberDtosAsync()
+    {
+        return await _context.Users
+            .Where(u => !u.EmailConfirmed)
+            .Include(x => x.Libraries)
+            .Include(r => r.UserRoles)
+            .ThenInclude(r => r.Role)
+            .OrderBy(u => u.UserName)
+            .Select(u => new MemberDto
+            {
+                Id = u.Id,
+                Username = u.UserName,
+                Email = u.Email,
+                Created = u.Created,
+                LastActive = u.LastActive,
+                Roles = u.UserRoles.Select(r => r.Role.Name).ToList(),
+                Libraries =  u.Libraries.Select(l => new LibraryDto
+                {
+                    Name = l.Name,
+                    Type = l.Type,
+                    LastScanned = l.LastScanned,
+                    Folders = l.Folders.Select(x => x.Path).ToList()
+                }).ToList()
+            })
+            .AsNoTracking()
+            .ToListAsync();
+    }
+
+    public async Task<bool> ValidateUserExists(string username)
+    {
+        if (await _userManager.Users.AnyAsync(x => x.NormalizedUserName == username.ToUpper()))
+        {
+            throw new ValidationException("Username is taken.");
+        }
+
+        return true;
+    }
 }

API/Data/Repositories/VolumeRepository.cs

@@ -1,7 +1,6 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
-using API.Comparators;
 using API.DTOs;
 using API.Entities;
 using API.Extensions;