Foundational Rework (Round 2) (#2767)

API/Services/Tasks/Scanner/ParseScannedFiles.cs

@@ -336,7 +336,7 @@ public class ParseScannedFiles
                 MessageFactory.FileScanProgressEvent($"{files.Count} files in {folder}", library.Name, ProgressEventType.Updated));
             if (files.Count == 0)
             {
-                _logger.LogInformation("[ScannerService] {Folder} is empty or is no longer in this location", folder);
+                _logger.LogInformation("[ScannerService] {Folder} is empty, no longer in this location, or has no file types that match Library File Types", folder);
                 return;
             }
 
@@ -416,6 +416,12 @@ public class ParseScannedFiles
                     }
                     else
                     {
+                        // TODO: I think I need to bump by 0.1f as if the prevIssue matches counter
+                        if (!string.IsNullOrEmpty(prevIssue) && prevIssue == counter + "")
+                        {
+                            // Bump by 0.1
+                            counter += 0.1f;
+                        }
                         chapter.IssueOrder = counter;
                         counter++;
                         prevIssue = chapter.Chapters;

API/Services/Tasks/Scanner/Parser/Parser.cs

@@ -1130,4 +1130,15 @@ public static class Parser
 
         return null;
     }
+
+    public static string RemoveExtensionIfSupported(string? filename)
+    {
+        if (string.IsNullOrEmpty(filename)) return filename;
+
+        if (Regex.IsMatch(filename, SupportedExtensions))
+        {
+            return Regex.Replace(filename, SupportedExtensions, string.Empty);
+        }
+        return filename;
+    }
 }

API/Services/Tasks/Scanner/ProcessSeries.cs

@@ -246,6 +246,7 @@ public class ProcessSeries : IProcessSeries
         catch (Exception ex)
         {
             _logger.LogError(ex, "[ScannerService] There was an exception updating series for {SeriesName}", series.Name);
+            return;
         }
 
         var settings = await _unitOfWork.SettingsRepository.GetSettingsDtoAsync();
@@ -661,7 +662,7 @@ public class ProcessSeries : IProcessSeries
         {
             if (existingChapter.Files.Count == 0 || !parsedInfos.HasInfo(existingChapter))
             {
-                _logger.LogDebug("[ScannerService] Removed chapter {Chapter} for Volume {VolumeNumber} on {SeriesName}", existingChapter.GetNumberTitle(), volume.Name, parsedInfos[0].Series);
+                _logger.LogDebug("[ScannerService] Removed chapter {Chapter} for Volume {VolumeNumber} on {SeriesName}", existingChapter.Range, volume.Name, parsedInfos[0].Series);
                 volume.Chapters.Remove(existingChapter);
             }
             else