* New Scan Loop (#1447)
* Staging the code for the new scan loop.
* Implemented a basic idea of changes on drives triggering scan loop. Issues: 1. Scan by folder does not work, 2. Queuing system is very hacky and needs a separate thread, 3. Performance degregation could be very real.
* Started writing unit test for new loop code
* Implemented a basic method to scan a folder path with ignore support (not implemented, code in place)
* Added some code to the parser to build out the idea of processing series in batches based on some top level folder.
* Scan Series now uses the new code (folder based parsing) and now handles the LocalizedSeries issue.
* Got library scan working with the new folder-based scan loop. Updated code to set FolderPath (for improved scan times and partial scan support).
* Wrote some notes on update library scan loop.
* Removed migration for merge
* Reapplied the SeriesFolder migration after merge
* Refactored a check that used multiple db calls into one.
* Made lots of progress on ignore support, but some confusion on underlying library. Ticket created. On hold till then.
* Updated Scan Library and Scan Series to exit early if no changes are on the underlying folders that need to be scanned.
* Implemented the ability to have .kavitaignore files within your directories and Kavita will parse them and ignore files and directories based on rules within them.
* Fixed an issue where ignore files nested wouldn't stack with higher level ignores
* Wrote out some basic code that showcases how we can scan series or library based on file events on the underlying system. Very buggy, needs lots of edge case testing and logging and dupplication checking.
* Things are working kinda. I'm getting lost in my own code and complexity. I'm not sure it's worth it.
* Refactored ScanFiles out to Directory Service.
* Refactored more code out to keep the code clean.
* More unit tests
* Refactored the signature of ParsedSeries to use IList. Started writing unit tests and reworked the UpdateLibrary to work how it used to with new scan loop code (note: using async update library/series does not work).
* Fixed the bug where processSeriesInfos was being invoked twice per series and made the code work very similar to old code (except loose leaf files dont work) but with folder based scanning.
* Prep for unit tests (updating broken ones with new implementations)
* Just some notes. Not sure I want to finish this work.
* Refactored the LibraryWatcher with some comments and state variables.
* Undid the migrations in case I don't move forward with this branch
* Started to clean the code and prepare for finishing this work.
* Fixed a bad merge
* Updated signatures to cleanup the code and commit to the new strategy for scanning.
* Swapped out the code with async processing of series on a small library
* The new scan loop is working in both Sync and Async methods. The code is slow and not optimized. This represents a good point to start polling and applying optimizations.
* Refactored UpdateSeries out of Scanner and into a dedicated file.
* Refactored how ProcessTasks are awaited to allow more async
* Fixed an issue where side nav item wouldn't show correct highlight and migrated to OnPush
* Moved where we start to stopwatch to encapsulate the full scan
* Cleaned up SignalR events to report correctly (still needs a redesign)
* Remove the "remove" code until I figure it out
* Put in extremely expensive series deletion code for library scan.
* Have Genre and Tag update the DB immediately to avoid dup issues
* Taking a break
* Moving to a lock with People was successful. Need to apply to others.
* Refactored code for series level and tag and genre with new locking strategy.
* New scan loop works. Next up optimization
* Swapped out the Kavita log with svg for faster load
* Refactored metadata updates to occur when the series are being updated.
* Code cleanup
* Added a new type of generic message (Info) to inform the user.
* Code cleanup
* Implemented an optimization which prevents any I/O (other than an attribute lookup) for Library/Series Scan. This can bring a recently updated library on network storage (650 series) to fully process in 2 seconds.
Fixed a bug where File Analysis was running everytime for each non-epub file.
* Fixed ARM x64 builds not being able to view PDF cover images due to a bad update in DocNet.
* Some code cleanup
* Added experimental signalr update code to have a more natural refresh of library-detail page
* Hooked in ability to send new series events to UI
* Moved all scan (file scan only) tasks into Scan Queue. Made it so scheduled ScanLibraries will now check if any existing task is being run and reschedule for 3 hours, and 10 mins for scan series.
* Implemented the info event in the events widget and added a clear all button to dismiss all infos and errors. Added --event-widget-info-bg-color
* Remove --drawer-background-color since it's not used
* When new series added, inject directly into the view.
* Some debug code cleanup
* Fixed up the unit tests
* Ensure all config directories exist on startup
* Disabled Library Watching (that will go in next build)
* Ensure update for series is admin only
* Lots of code changes, scan series kinda works, specials are splitting, optimizations are failing. Demotivated on this work again.
* Removed SeriesFolder migration
* Added the SeriesFolder migration
* Added a new pipe for dates so we can provide some nicer defaults. Added folder path to the series detail.
* The scan optimizations now work for NTFS systems.
* Removed a TODO
* Migrated all the times to use DateTime.Now and not Utc.
* Refactored some repo calls to use the includes flag pattern
* Implemented a check for the library scan optimization check to validate if the library was updated (type change, library rename, folder change, or series deleted) and let the optimization be bypassed.
* Added another optimization which will use just folder attribute of last write time if the drive is not NTFS.
* Fixed a unit test
* Some code cleanup
* Bump versions by dotnet-bump-version.
* Misc UI Fixes (#1450)
* Fixed collection cover images not rendering
* added a try/catch on sending email, so we fail silently if it doesn't send.
* Fixed Go Back not returning to last scroll position due to layoutmode change resetting, despite nothing changing.
* Fixed a bug where when turning between pages on default mode, the height calculations could get skewed.
* Fixed a missing case for card item where it wouldn't show tooltip title for series.
* Bump versions by dotnet-bump-version.
* New Scan Loop Fixes (#1452)
* Refactored ScanSeries to avoid a lot of extra work and fixed a bug where Scan Series would invoke the processing twice.
Refactored the series selection code during process such that we use Localized Name as well, for cases where the original name was changed.
Undid an optimization around Last Write time, since Linux file systems match how NTFS works.
* Fixed part of the query
* Added a NormalizedLocalizedName for quick searching in which a series needs grouping. Reworked scan loop code a bit to ensure we don't do extra work.
Tweaked the widget logic to help display better and not show "Nothing going on here".
* Fixed a bug where archives with ._ files would be counted as valid files, while they are actually just metadata files on Mac's.
* Fixed a broken unit test
* Bump versions by dotnet-bump-version.
* Simplify parent lookup with Directory.GetParent (#1455)
* Simplify parent lookup with Directory.GetParent
* Address comments
* Bump versions by dotnet-bump-version.
* Scan Loop Fixes (#1459)
* Added Last Folder Scanned time to series info modal.
Tweaked the info event detail modal to have a primary and thus be auto-dismissable
* Added an error event when multiple series are found in processing a series.
* Fixed a bug where a series could get stuck with other series due to a bad select query.
Started adding the force flag hook for the UI and designing the confirm.
Confirm service now also has ability to hide the close button.
Updated error events and logging in the loop, to be more informative
* Fixed a bug where confirm service wasn't showing the proper body content.
* Hooked up force scan series
* refresh metadata now has force update
* Fixed up the messaging with the prompt on scan, hooked it up properly in the scan library to avoid the check if the whole library needs to even be scanned. Fixed a bug where NormalizedLocalizedName wasn't being calculated on new entities.
Started adding unit tests for this problematic repo method.
* Fixed a bug where we updated NormalizedLocalizedName before we set it.
* Send an info to the UI when series are spread between multiple library level folders.
* Added some logger output when there are no files found in a folder. Return early if there are no files found, so we can avoid some small loops of code.
* Fixed an issue where multiple series in a folder with localized series would cause unintended grouping. This is not supported and hence we will warn them and allow the bad grouping.
* Added a case where scan series fails due to the folder being removed. We will now log an error
* Normalize paths when finding the highest directory till root.
* Fixed an issue with Scan Series where changing a series' folder to a different path but the original series folder existed with another series in it, would cause the series to not be deleted.
* Fixed some bugs around specials causing a series merge issue on scan series.
* Removed a bug marker
* Cleaned up some of the scan loop and removed a test I don't need.
* Remove any prompts for force flow, it doesn't work well. Leave the API as is though.
* Fixed up a check for duplicate ScanLibrary calls
* Bump versions by dotnet-bump-version.
* Scroll Resume (#1460)
* When we navigate from a page then back, resume back on the last scroll key (if clicked)
* Resume jump key position when navigating back to a page. Removed some extra blank space on collection detail when a collection doesn't have a summary or cover image.
* Ignore progress events on series cards
* Added a url to swagger for /, which could be reverse proxy url
* Bump versions by dotnet-bump-version.
* Misc UI fixes (#1461)
* Misc fixes
- Fixed modal being stretched when not needed.
- Fixed Logo vertical align
- Fixed drawer content scroll, and from it being squished due to overridden by bootstrap.
* series detail cover image stretch fix
- Fixes: Fixes series detail cover image being stretched on larger resolutions
* fixing empty lists scrollbar
* Fixing want to read error
* fixing unnecessary scrollbar
* Fixing recently updated tooltip
* Bump versions by dotnet-bump-version.
* Folder Watching (#1467)
* Hooked in a server setting to enable/disable folder watching
* Validated the file rename change event
* Validated delete file works
* Tweaked some logic to determine if a change occurs on a folder or a file.
* Added a note for an upcoming branch
* Some minor changes in the loop that just shift where code runs.
* Implemented ScanFolder api
* Ensure we restart watchers when we modify a library folder.
* Fixed a unit test
* Bump versions by dotnet-bump-version.
* More Scan Loop Bugfixes (#1471)
* Updated scan time for watcher to 30 seconds for non-dev. Moved ScanFolder off the Scan queue as it doesn't need to be there. Updated loggers
* Fixed jumpbar missing
* Tweaked the messaging for CoverGen
* When we return early due to nothing being done on library and series scan, make sure we kick off other tasks that need to occur.
* Fixed a foreign constraint issue on Volumes when we were adding to a new series.
* Fixed a case where when picking normalized series, capitalization differences wouldn't stack when they should.
* Reduced the logging output on dev and prod settings.
* Fixed a bug in the code that finds the highest directory from a file, where we were not checking against a normalized path.
* Cleaned up some code
* Fixed broken unit tests
* Bump versions by dotnet-bump-version.
* More Scan Loop Fixes (#1473)
* Added a ToList() to avoid a bug where a person could be removed from a list while iterating over the list.
* When deleting a series, want to read page will now automatically remove that series from the view.
* Fixed a series lookup which was ignoring format
* Ignore XML comment warnings
* Removed a note since it was already working that way
* Fixed unit test
* Bump versions by dotnet-bump-version.
* Misc UI Fixes (#1477)
* Tweaked a Migration to log correctly only if something is going to be done.
* Refactored Reading List Controller code into a dedicated service and cleaned up some methods that aren't needed anymore.
* Fixed a bug where adding a new item to a reading list wasn't adding it at the end.
* Fixed an issue where collection page would re-render the same covers on multiple items.
* Fixed a missing margin-top which made the page extras drawer not render correctly and hence unclosable on small screens.
* Added some timeout on manage users screen to give data time to flush.
Added a dedicated token log for account flows, in case url encoding plays a part (but from testing it doesn't).
* Reverted back to building for ES6 instead of es2020 for old Safari 12.5.5 browsers (10MB difference in build size).
* Cleaned up the logic in removing series not found during scan loop.
* Tweaked the timings for Library Watcher to 1 min and reprocess queue every 30 seconds.
* Bump versions by dotnet-bump-version.
* Added fixes for libvips (#1479)
* Bump versions by dotnet-bump-version.
* Tachiyomi + Fixes (#1481)
* Fixed a bootstrap bug
* Fixed repeating images on collection detail
* Fixed up some logic in library watcher which wasn't processing all of the queue.
* When parsing non-epubs in Book library, use Manga parsing for Volume support to better support Light Novels
* Fixed some bugs with the tachiyomi plugin api's for progress tracking
* Bump versions by dotnet-bump-version.
* Adding Health controller (#1480)
* Adding Health controller
- Added: Added API endpoint for a health check to streamline docker healthy status.
* review comment fixes
* Bump versions by dotnet-bump-version.
* Simplify Folder Watcher (#1484)
* Refactored Library Watcher to use Hangfire under the hood.
* Support .kavitaignore at root level.
* Refactored a lot of the library watching code to process faster and handle when FileSystemWatcher runs out of internal buffer space. It's still not perfect, but good enough for basic use.
* Make folder watching as experimental and default it to off by default.
* Revert #1479
* Tweaked the messaging for OPDS to remove a note about download role.
Moved some code closer to where it's used.
* Cleaned up how the events widget reports
* Fixed a null issue when deleting series in the UI
* Cleaned up some debug code
* Added more information for when we skip a scan
* Cleaned up some logging messages in CoverGen tasks
* More log message tweaks
* Added some debug to help identify a rare issue
* Fixed a bug where save bookmarks as webp could get reset to false when saving other server settings
* Updated some documentation on library watcher.
* Make LibraryWatcher fire every 5 mins
* Bump versions by dotnet-bump-version.
* Sort series by chapter number only when some chapters have no volume (#1487)
* Sort series by chapter number only when some chapters have no volume information
* Implement a Default static instance of ChapterSortComparer
* Further use Default static Comparers
* Add missing ToLit() as per comments
* SQLite Hangfire (#1488)
* Update to use SQLIte for Hangfire to retain information on tasks
* Updated all external links to have noopener noreferrer
* When watching folders, ensure the folders exist before creating watchers.
* Tweaked the messaging for Email Service and added link to the project.
* Bump versions by dotnet-bump-version.
* Bump versions by dotnet-bump-version.
* Fixed typeahead not working correctly (#1490)
* Bump versions by dotnet-bump-version.
* Release Testing Day 1 (#1491)
* Fixed a bug where typeahead wouldn't automatically show results on relationship screen without an additional click.
* Tweaked the code which checks if a modification occured to check on seconds rather than minutes
* Clear cache will now clear temp/ directory as well.
* Fixed an issue where Chrome was caching api responses when it shouldn't had.
* Added a cleanup temp code
* Ensure genres get removed during series scan when removed from metadata.
* Fixed a bug where all epubs with a volume would show as Volume 0 in reading list
* When a scan is in progress, don't let the user delete the library.
* Bump versions by dotnet-bump-version.
* Scan Loop Last Write Time Change (#1492)
* Refactored invite user flow to separate error handling on create user flow and email flow. This should help users that have unique situations.
* Switch to using files to check LastWriteTime. Debug code in for Robbie to test on rclone
* Updated Parser namespace. Changed the LastWriteTime to check all files and folders.
* Bump versions by dotnet-bump-version.
* Release Testing Day 2 (#1493)
* Added a no data section to collection detail.
* Remove an optimization for skipping the whole library scan as it wasn't reliable
* When resetting password, ensure the input is colored correctly
* Fixed setting new password after resetting, throwing an error despite it actually being successful.
Fixed incorrect messaging for Password Reset page.
* Fixed a bug where reset password would show the side nav button and skew the page.
Updated a lot of references to use Typed version for formcontrols.
* Removed a migration from 0.5.0, 6 releases ago.
* Added a null check so we don't throw an exception when connecting with signalR on unauthenticated users.
* Bump versions by dotnet-bump-version.
* Fixed a bug where a series with a relationship couldn't be deleted. (#1495)
* Bump versions by dotnet-bump-version.
* Release Testing Day 3 (#1496)
* Tweaked log messaging for library scan when no files were scanned.
* When a theme that is set gets removed due to a scan, inform the user to refresh.
* Fixed a typo and make Darkness -> Brightness
* Make download theme files allowed to be invoked by non-authenticated users, to allow new users to get the default theme.
* Hide all series side nav item if there are no libraries exposed to the user
* Fixed an API for Tachiyomi when syncing progress
* Fixed dashboard not responding to Series Removed and Added events.
Ensure we send SeriesRemoved events when they are deleted.
* Reverted Hangfire SQLite due to aborted jobs being resumed, when they shouldnt. Fixed some scan loop issues where cover gen wouldn't be invoked always on new libraries.
* Bump versions by dotnet-bump-version.
* Updating series detail cover style (#1498)
# FIxed
- Fixed: Fixed an issue with series detail cover when scaled down.
* Bump versions by dotnet-bump-version.
* Version bump
* v0.5.6 Release (#1499)
Co-authored-by: tjarls <tjarls@gmail.com>
Co-authored-by: Robbie Davis <robbie@therobbiedavis.com>
Co-authored-by: Chris Plaatjes <kizaing@gmail.com>
* Moved the Server Settings out into a button on nav header
* Refactored Mange Users page to the new design (skeleton). Implemented skeleton code for Invite User.
* Hashed out more of the code, but need to move all the email code to a Kavita controlled API server due to password credentials.
* Cleaned up some warnings
* When no user exists for an api key in Plugin controller, throw 401.
* Hooked in the ability to check if the Kavita instance can be accessed externally so we can determine if the user can invite or not.
* Hooked up some logic if the user's server isn't accessible, then default to old flow
* Basic flow is working for confirm email. Needs validation, error handling, etc.
* Refactored Password validation to account service
* Cleaned up the code in confirm-email to work much better.
* Refactored the login page to have a container functionality, so we can reuse the styles on multiple pages (registration pages). Hooked up the code for confirm email.
* Messy code, but making progress. Refactored Register to be used only for first time user registration. Added a new register component to handle first time flow only.
* Invite works much better, still needs a bit of work for non-accessible server setup. Started work on underlying manage users page to meet new design.
* Changed (you) to a star to indicate who you're logged in as.
* Inviting a user is now working and tested fully.
* Removed the register member component as we now have invite and confirm components.
* Editing a user is now working. Username change and Role/Library access from within one screen. Email changing is on hold.
* Cleaned up code for edit user and disabled email field for now.
* Cleaned up the code to indicate changing a user's email is not possible.
* Implemented a migration for existing accounts so they can validate their emails and still login.
* Change url for email server
* Implemented the ability to resend an email confirmation code (or regenerate for non accessible servers). Fixed an overflow on the confirm dialog.
* Took care of some code cleanup
* Removed 3 db calls from cover refresh and some misc cleanup
* Fixed a broken test
* Series Detail Enhancements
# Added
- Added: Volume tab for `Comic` Library Types
- Added: Storyline tab for `Comic` and `Manga` library types. This will show Volumes and Chapters together sorted in order.
# Changed
- Changed: Changed `Chapters/Issues` to show all chapters or issues regardless of if they are in a volume for both `Manga` and `Comic` library types
* Removed 3 loops to speed up load time
* Refactored some library type checks. Reset selection on nav change.
* Refactored hasReadingProgress for a series to the backend and further optimized the series detail page.
* Fixed up the regex for "Annual" special case and added unit tests.
Co-authored-by: Joseph Milazzo <joseph.v.milazzo@gmail.com>
* Fixed a bug in CleanupBookmarks where the Except was deleting all files because the path separators didn't match.
* Added unit tests for ParseScannedFiles.cs.
* Fixed some unit tests. Parser will now clear out multiple spaces in a row and replace with a single.
* Fixed the book reader off by one issue with loading last page
* Fixed a case where scanner would not delete a series if another series with same name but different format was added in that same scan.
* Added some missing tag generation (chapter language and summary)
* Fixed a bug which didn't take sort direction when not changing sort field
* Added foundation for Bookmark refactor
* Code broken, need to take a break. Issue is Getting bookmark image needs authentication but UI doesn't send.
* Implemented the ability to send bookmarked files to the web. Implemented ability to clear bookmarks on disk on a re-occuring basis.
* Updated the bookmark design to have it's own card that is self contained. View bookmarks modal has been updated to better lay out the cards.
* Refactored download bookmark codes to select files from bookmark directory directly rather than open underlying files.
* Wrote the basic logic to kick start the bookmark migration.
Added Installed Version into the DB to allow us to know more accurately when to run migrations
* Implemented the ability to change the bookmarks directory
* Updated all references to BookmarkDirectory to use setting from the DB.
Updated Server Settings page to use 2 col for some rows.
* Refactored some code to DirectoryService (hasWriteAccess) and fixed up some unit tests from a previous PR.
* Treat folders that start with ._ as blacklisted.
* Implemented Reset User preferences. Some extra code to prep for the migration.
* Implemented a migration for existing bookmarks to using new filesystem based bookmarks
* Added a new endpoint to get all Series with Progress info.
* Fixed up some potential NPEs during scan
* Commented out filter code, not ready for it.
* Fixed up a parsing case for european comics
* Refactored FilterDto to allow for specifying multiple formats to return.
* Refactored FilterDto to allow for specifying multiple formats to return.
* Refactored the UI to show OPDS as 3rd Party Clients since Tachiyomi now uses OPDS url scheme for authentication.
* Fixed a case where chapter was being parsed incorrectly when the series title ends in a number.
* Updated Kavita to support Tome/T notation found in French comics
* Added support for identifying European specials and expanded support for cleaning some tags used in European comics. During cleaning, if series starts with - or comma, remove it.
* Fixed an issue where add to collection for a single series wasn't calling the bulk action handler
* Fixed a NPE on AgeRating conversion. Fixed a bug where when looking for cover image, file extensions was throwing off sort code.
* Refactored Natural Sort ordering to better follow how Windows behaves. This is a departure from how the original code executes.
* GetCachedPagePath now uses natural sorting to pick the images for reading in a more correct order.
* Updated parser to handle a case where there was more than one space as a separator
* Refactored all files to have Interfaces within the same file. Started moving over to file-scoped namespaces.
* Refactored common methods for getting underlying file's cover, pages, and extracting into 1 interface.
* More refactoring around removing dependence on explicit filetype testing for getting information.
* Code is buildable, tests are broken. Huge refactor (not completed) which makes most of DirectoryService testable with a mock filesystem (and thus the services that utilize it).
* Finished porting DirectoryService to use mocked filesystem implementation.
* Added a null check
* Added a null check
* Finished all unit tests for DirectoryService.
* Some misc cleanup on the code
* Fixed up some bugs from refactoring scan loop.
* Implemented CleanupService testing and refactored more of DirectoryService to be non-static.
Fixed a bug where cover file cleanup wasn't properly finding files due to a regex bug.
* Fixed an issue in CleanupBackup() where we weren't properly selecting database files older than 30 days. Finished CleanupService Tests.
* Refactored Flatten and RemoveNonImages to directory service to allow CacheService to be testable.
* Finally have CacheService tested. Rewrote GetCachedPagePath() to be much more straightforward & performant.
* Updated DefaultParserTests.cs to contain all existing tests and follow new test layout format.
* All tests fixed up
* Started with some basic plumbing with comic info parsing updating Series/Volume.
* We can now get chapter title from comicInfo.xml
* Hooked in the ability to store people into the chapter metadata.
* Removed no longer used imports, fixed up some foreign key constraints on deleting series with person linked.
* Refactored Summary out of the UI for Series into SeriesMetadata. Updated application to .net 6. There is a bug in metadata code for updating.
* Removed the parallel.ForEach with a normal foreach which lets us use async. For I/O heavy code, shouldn't change much.
* Refactored scan code to only check extensions with comic info, fixed a bug on scan events not using correct method name, removed summary field (still buggy)
* Fixed a bug where on cancelling a metadata request in modal, underlying button would get stuck in a disabled state.
* Changed how metadata selects the first volume to read summary info from. It will now select the first non-special volume rather than Volume 1.
* More debugging and found more bugs to fix
* Redid all the migrations as one single one. Fixed a bug with GetChapterInfo returning null when ChapterMetadata didn't exist for that Chapter.
Fixed an issue with mapper failing on GetChapterMetadata. Started work on adding people and a design for people.
* Fixed a bug where checking if file modified now takes into account if file has been processed at least once. Introduced a bug in saving people to series.
* Just made code compilable again
* Fixed up code. Now people for series and chapters add correctly without any db issues.
* Things are working, but I'm not happy with how the management of Person is. I need to take into account that 1 person needs to map to an image and role is arbitrary.
* Started adding UI code to showcase chapter metadata
* Updated workflow to be .NET 6
* WIP of updating card detail to show the information more clearly and without so many if statements
* Removed ChatperMetadata and store on the Chapter itself. Much easier to use and less joins.
* Implemented Genre on SeriesMetadata level
* Genres and People are now removed from Series level if they are no longer on comicInfo
* PeopleHelper is done with unit tests. Everything is working.
* Unit tests in place for Genre Helper
* Starting on CacheHelper
* Finished tests for ShouldUpdateCoverImage. Fixed and added tests in ArchiveService/ScannerService.
* CacheHelper is fully tested
* Some DI cleanup
* Scanner Service now calls GetComicInfo for books. Added ability to update Series Sort name from metadata files (mainly epub as comicinfo doesn't have a field)
* Forgot to move a line of code
* SortName now populates from metadata (epub only, ComicInfo has no tags)
* Cards now show the chapter title name if it's set on hover, else will default back to title.
* Fixed a major issue with how MangaFiles were being updated with LastModified, which messed up our logic for avoiding refreshes.
* Woohoo, more tests and some refactors to be able to test more services wtih mock filesystem. Fixed an issue where SortName was getting set as first chapter, but the Series was in a group.
* Refactored the MangaFile creation code into the DbFactory where we also setup the first LastModified update.
* Has file changed bug is now finally fixed
* Remove dead genres, refactor genre to use title instead of name.
* Refactored out a directory from ShouldUpdateCoverImage() to keep the code clean
* Unit tests for ComicInfo on BookService.
* Refactored series detail into it's own component
* Series-detail now received refresh metadata events to refresh what's on screen
* Removed references to Artist on PersonRole as it has no metadata mapping
* Security audit
* Fixed a benchmark
* Updated JWT Token generator to use new methods in .NET 6
* Updated all the docker and build commands to use net6.0
* Commented out sonar scan since it's not setup for net6.0 yet.
* Removed some directives
* Removed my test db
* Ignore system and hidden folders when performing directory scan.
* Fixed the comic parser tests not using Comic mode for parsing.
* Accept all forwarded headers and use them.
* Ignore some changes from another branch
* Cleaned up some code. Fixed an issue on books with good table of contents not allowing line tracking (progress) from being saved. Changed Save to Defaults on light mode to be primary.
* Fixed a bug where deleting reading items would not actually delete them
* Fixed a bug where after ordering reading lists then deleting the order would be undone (develop)
* Code cleanup
Sometimes comic-downloader will have filenames like spawn-chapter-123.
Previously we did not support the -chapter- part, this patch adds support
for it.
* Fixed some issues with base url. All Scheduled jobs are now in user's timezone
* Hide Base Url support from UI and removed some code around it on the backend to prevent it from interfering. Patched back in changes from base-href branch like Timezone on scheduled jobs and enhanced logging.
* Added parser support for "2000 AD 0366 [1984-04-28] (flopbie)" and removed for "01 Spiderman 01".
* Adding multiple cases for comic naming conventions
* Changing "Chapter" to "Issue" for comic libraries
* Fixed an issue where the Parse method was using filename with extension to run regex matching, while it should be running on name without extension.
* Refactored to use Getter
* Cleaned up file to use conditional labelling rather than conditional html fragments
* Refactored code to properly check against library type for a given readinglist item
* Cleaned up series detail
* Conditionally remove special tags during parse
* Setup ParseInfoTests for ComicParserTests and also added unit tests from other comic issues created.
* Added more regex cases for naming patterns reported to be common with comics. Some cases added without regex.
* Pushing up changes
Fixed issue with cleanTitleTest.
Tried some patterns for "Cyberpunk 2077" but reverted
* Updated some cases and some spacing on Parser. Cyberpunk 2077 is not implemented as long as there is a # before issue number.
* Fixed the case for Special parsing on TPB. Fixed a piece of code that got deleted that prevented specials from rendering on volumes tab.
* Potential fix for parsing Cyberpunk 2077
- Added a ComicsSeriesSpecialCasesRegex and passed any filename that contains "Cyberpunk 2077" over to it so we can parse it separately. This could be used for any other potential problem series.
* Revert "Potential fix for parsing Cyberpunk 2077"
This reverts commit a14417e640.
* Added more tests
* Refactored all places in Kavita to use Book, Issue, or Chapter depending on the Library type. Updated Volumes/Chapters to remove Volumes to make it cleaner.
* Removed some leftover test code
Co-authored-by: Joseph Milazzo <joseph.v.milazzo@gmail.com>
* Add comics-downloader parser
The utility comics-downloader can be used to download comics
and produces files of the type "seriesname-chapternumberpadded".
This adds support for that format.
For more info https://github.com/Girbons/comics-downloader
* Adjusted the test cases and added .+? to consume less characters.
Co-authored-by: Joseph Milazzo <joseph.v.milazzo@gmail.com>
* Implemented the ability to perform multi-selections on cards. Basic selection code is done, CSS needed and exposing actions.
* Implemented a bulk selection bar. Added logic to the card on when to force show checkboxes.
* Fixed some bad parsing groups and cases for Comic Chapters.
* Hooked up some bulk actions on series detail page. Not hooked up to backend yet.
* Fixes#593. URI Enocde library names as sometimes they can have & in them.
* Implemented the ability to mark volume/chapters as read/unread.
* Hooked up mark as unread with specials as well.
* Add to reading list hooked up for Series Detail
* Implemented ability to add multiple series to a reading list.
* Implemented bulk selection for series cards
* Added comments to the new code in ReaderService.cs
* Implemented proper styling on bulk operation bar and integrated for collections.
* Fixed an issue with shift clicking
* Cleaned up css of bulk operations bar
* Code cleanup
* Added volume migrations. Added parser case for "Chapter 63 - The Promise Made for 520 Cenz.cbr"
* Added some info statements for when full library scans occur. For image apis, return the name of the file to aid in caching.
* When managing users, show the current logged in user at the top of the list. Added a message when no libraries have been setup but you are trying to add a user to a library.
* Removed an extra stream operation from SharpCompress cover image work. Removed an extra ToArray() from Book Reader for extracting PDF pages.
* Removed the left over comment
* Added parsing case for "Batman Beyond 04 (of 6) (1999)"
* Removed dead code
* Added parser case for "The Duke of Death and His Black Maid - Ch. 177 - The Ball (3).cbz"
* Removed a file that is created and modified every test run.
* Fixed a bad parser case for "Batman Beyond 02 (of 6) (1999)" which was consuming too many characters
* Removed a lot of "Volume" parsing for Comics that don't make sense. This is prep work for the upcoming Comic Rework release.
* Reworked a lot of parsing cases for comics based on naming conventions observed from releases found online.
* Added a way for external scripts to use a user api key to authenticate
* Fixed an issue if the manga only had one page, the bottom menu would be missing page and chapter controls.
* Fixed a bug where on small phones, nav bar could overflow due to scroll to top
* Tweaked a lot of regex for manga parsing to handle some cases where poorly named files, like "Vol. 03 Ch. 21" would end up parsing as Series "Vol. 03".
* Even more handling of parser cases. Manga parser should be as it was but more robust to handle bad naming.
* Fixed: Don't force metadata refresh on Scan Series, only on refresh metadata
* Implemented the ability to automatically refresh after a series scan based on when server finishes. Remove a duplicate API call from series detail.
* Removed another API call for series metadata that isn't needed.
* Refactored Message creation to a factory, hardcoded strings are centralized, and RefreshSeriesMetadata sends an event and is refactored to be async.
* Fixed a bug when really poorly named files are within a folder that contains the series name, fallback couldn't occur due to it being taken as root folder. Now we detect said condition and will go one level higher, resulting in potentially more I/O, but the series will not be deleted.
* Added the Read in Incognito context item for Chapter cards
* Skip an additional check for series summary for series that aren't EPUB or Archive formats.
* Fixed an issue where cover image generation could occur due to a bad check on LastWriteTime on the underlying file.
* Added some extra comic parser tests
* Added a ScanLibrary event (not hooked up in UI)
* Performance improvement on metadata service. Now when we scan for cover image changes, we emit when a change occurs and only then do we update parent entities (array copy).
* Removed an hr from series detail and ensure we update the cover image for series when scan series finishes.
* Updated the infinite scroller to use a Flags pattern for the debug mode. Updated a few logical conditions for mobile.
* Removed the concurrency check on row progress as if too many calls hit the DB, it will throw, but it doesn't matter.
Fixed a bad logic code which could cause scrolling after hitting the bottom of the chapter.
* Ensure prefetching uses totalPages + 1 since we pass in totalPages as - 1 from manga reader
* Fixed issue where last page of webtoon wouldn't be prefetched due to a < instead of <= on prefetching code
* Implemented ability to send images from archives to the UI without incurring any extra memory pressure.
* Dropdown menus now have a darker background
* Webtoon reader now works on mobile.
* Fixed how keyboard presses for up/down/left/right work with MANGA_UD reading mode. See issue #579
* Fixed cont reader for webtoons on mobile
* Fixed a small issue where top spacer would too quickly switch to prev chapter
* Updated user preferences to use same slider style. Removed some css that is not used.
* Added comic parser case for "Saga 001 (2012) (Digital) (Empire-Zone)"
* Added accessibility toggle to reading list order and aligned sliders to all use the same style.
* Removed a todo for checking on new image serving code. It works great.
* Fixed a missing await
* Auth guard will now check if an existing toast is present giving same message before poping the toast.
* Fixed alignment on phones for reading lists
* Moved sorters so they aren't resused between multiple threads. Slightly higher memory footprint.
* Fixed a broken unit test
* Code smells
* More unit test fixing
* Added some documentation. Removed Require Admin Role from Search Tags. Added Summary to be updated on UpdateTag.
* Added Swagger xml doc generation to beef up the documentation. Started adding xml comments to the APIs. This is a needed, slow task for upcoming Plugins system.
* Implemented the ability to upload a custom series image to override the existing cover image.
Refactored some code out to use ImageService and added more documentation
* When a page cache fails, delete cache directory so user can try to reload.
* Implemented the ability to lock a series cover image such that after user uploads something, it wont get refreshed by Kavita.
* Implemented the ability to reset cover image for series by unlocking
* Kick off a series refresh after a cover is unlocked.
* Ability to press enter to load a url
* Ability to reset selection
* Cleaned up cover chooser such that reset is nicer, errors inform user to use file upload, series edit modal now doesn't use scrollable body. Mobile tweaks. CoverImageLocked is now sent to the UI.
* More css changes to look better
* When no bookmarks, don't show both markups
* Fixed issues where images wouldn't refresh after cover image was changed.
* Implemented the ability to change the cover images for collection tags.
* Added property and API for chapter cover image update
* Added UI code to prepare for updating cover image for chapters. need to rearrange components
* Moved a ton of code around to separate card related screens into their own module.
* Implemented the ability to update a chapter/volume cover image
* Refactored action for volume to say edit to reflect modal action
* Fixed issue where after editing chapter cover image, the underlying card wouldn't update
* Fixed an issue where we were passing volumeId to the reset chapter lock. Changed some logic in volume cover image generation.
* Automatically apply when you hit reset cover image
* Fix directory issue when building all the packages where directory got skewed. (#98)
* Bump version for patch release due to bug in continue fuctionality. (#104)
* Chore/version bump (#106)
* Bump version for patch release due to bug in continue fuctionality.
* Added develop branch for github actions
* Updated readme to have an image and support link. (#107)
* Feature/readme (#109)
* Updated readme to have an image and support link.
* Updated readme
* Fixed a bug where if a chapter had multiple archive files, they wouldn't all be extracted due to short circuit in ExtractArchive. Now I add the file id then flatten afterwards. (#113)
* Bugfix/multiple file extract (#116)
* Fixed a bug where if a chapter had multiple archive files, they wouldn't all be extracted due to short circuit in ExtractArchive. Now I add the file id then flatten afterwards.
* Fixed a bug where due to how we were extracting for multiple files, the single file extractions failed.
* Bumped release for 3.5 release
* Comic Support (#119)
* Implemented some basic regex for comic support
* Implemented support for comics
* empty filenames, like .test.jpg shouldn't be counted as image types.
* Fixed some regex for Manga's with commas or version tags in parenthesis.
* More cases for parsing regex
* Lots of Parsing Enhancements (#120)
* More cases for parsing regex
* Implemented the ability to parse "Special" keywords.
* Commented out some unit tests
* More parsing cases
* Fixed unit tests
* Fixed typo in build script
* Parsing Enhancements (#126)
* More cases for parsing regex
* Implemented the ability to parse "Special" keywords.
* Commented out some unit tests
* More parsing cases
* Fixed unit tests
* Fixed typo in build script
* Fixed a bug where if there was a series with same name, but different capitalization, we wouldn't process it's infos.
* Tons of regex updates to handle more cases.
* More regex tweaking to handle as many cases as possible.
* Bad merge caused the comic parser to break. Fixed with some better regex.
* Parser Enhancement: Fallback to Folder name (#129)
* More cases for parsing regex
* Implemented GetFoldersTillRoot for falling back on parsing when we can't get anything from the filename.
* Implemented a fallback strategy. Not tested on large libraries yet.
* Fallback tested and working great.
* Removed a test case that won't pass and added some trims
* Update README.md
Added build steps
* Update README.md (#130)
Added docker link
* Special Grouping (#134)
* More cases for parsing regex
* Implemented a change to fix old special grouping. Added some TODOs as well for a future enhancement
* Don't go to archive file if it hasn't updated since last scan (#135)
* Skip archive work unless the file has actually changed since last scan.
* In Progress Activity Stream Fixes (#136)
* Fixed a bug in In-Progress where it wasn't properly fetching series.
* Fixed a bug where chapter cover images weren't being updated due to a missed not.
* Removed a piece of code that was needed for upgrading, since all beta users agreed to wipe db.
* Fixed InProgress to properly respect order and show more recent activity first. Issue is with IEntityDate LastModified not updating in DataContext.
* Updated dependencies to lastest stable.
* LastModified on Volumes wasn't updating, validated it does update when data is changed.
* In Progress Query Update (#145)
* Fixed a bug where chapter cover images weren't being updated due to a missed not.
* Removed a piece of code that was needed for upgrading, since all beta users agreed to wipe db.
* Fixed InProgress to properly respect order and show more recent activity first. Issue is with IEntityDate LastModified not updating in DataContext.
* Updated dependencies to lastest stable.
* LastModified on Volumes wasn't updating, validated it does update when data is changed.
* Performance, Scan Loop, Specials, and cleanup (#150)
* More cases for parsing regex
* Fixed a bug where chapter cover images weren't being updated due to a missed not.
* Removed a piece of code that was needed for upgrading, since all beta users agreed to wipe db.
* Fixed InProgress to properly respect order and show more recent activity first. Issue is with IEntityDate LastModified not updating in DataContext.
* Updated dependencies to lastest stable.
* LastModified on Volumes wasn't updating, validated it does update when data is changed.
* Rewrote a check to avoid a small heap object warning.
* Ensure UpdateSeries checks all libraries for unique name.
* Took care of some todos, removed unused imports, on dev go ahead and schedule reoocuring jobs since LiteDB caused the locking issue.
* No Tracking when we aren't using entities.
* Added code to remove abandoned progress rows after a chapter gets deleted.
* RefreshMetadata uses one large query rather than many trips to DB for updating metadata. Significantly faster.
* Fixed a bug where UpdateSeries would always complain about a unique name even when we weren't updating name.
* Files that are linked to a series but can't parse out Vol/Chapter information are properly grouped like other Specials.
* Refresh metadata on UI should call the task directly
* Fixed a bug on updating series to make sure we don't complain if we aren't trying to update the name to an existing name.
* Fixed#142 - Library cards should be sorted.
* Refactored the name of some variables to be more agnostic to comics.
* Implemented ScanLibrary but abandoning it.
* Code Cleanup & removing ScanSeries code.
* Some more tests and new Comparators for natural sorting.
* Fixed#137 - When performing I/O on archives, ignore __MACOSX folders completely.
* Fixed#137 - When performing I/O on archives, ignore __MACOSX folders completely.
* All entities that will show under specials tab should be marked special, rather than just what has a special keyword.
* Don't let specials generate cover images
* Don't let specials generate cover images
* SearchResults should send LocalizedName back since we are searching against it.
* Added some tests around macosx folders found from my actual server.
* Put extra notes about a case where duplicates come about, logger will now tell user about this issue.
* Missed a build issue somehow...
* Some code smells
* Bugfixes! (#157)
* More cases for parsing regex
* Fixed a bug where chapter cover images weren't being updated due to a missed not.
* Removed a piece of code that was needed for upgrading, since all beta users agreed to wipe db.
* Fixed InProgress to properly respect order and show more recent activity first. Issue is with IEntityDate LastModified not updating in DataContext.
* Updated dependencies to lastest stable.
* LastModified on Volumes wasn't updating, validated it does update when data is changed.
* Fixed#152 - Sorting issue when finding cover image.
* Fixed#151 - Sort files during scan.
* Fixed#161 - Remove files that don't exist from chapters during scan.
* Fixed#155 - Ignore images that start with !, expand cover detection by checking for the word cover as well as folder, and some code cleanup to make code more concise.
* Fixed#153 - Ensure that we persist series name changes and don't override on scanning.
* Fixed a broken unit test
* Version bump
* I keep fixing this but it keeps reverting (#158)
* Fixed#165 - Login and Registration will allow case-insensitive usernames now. (#169)
* Cover Image - First and tests (#170)
* Changed how natural sort works to cover more cases
* Changed the name of CoverImage regex for Parser and added more cases.
* Changed how we get result from Task.Run()
* Defer execution of a loop till we really need it and added another TODO for later this iteration.
* Big refactor to cover image code to unify between IOCompression and SharpCompress. Both use methods to find the correct file. This results in one extra loop through entries, but simplifies code signficantly.
In addition, new unit tests for the methods that actually do the logic on choosing cover file and first file.
* Removed dead code
* Added missing doc
* Feature/unit tests (#171)
* Removed a duplicate loop that was already done earlier in method.
* Normalize now replaces underscores
* Added more Parser cases, Added test case for SeriesExtension (Name in List), and added MergeNameTest and some TODOs for where tests should go
* Added a test for removal
* Fixed bad merge
Co-authored-by: Andrew Song <asong641@gmail.com>
* Feature/bugfix and regex (#174)
* Fixed#172
* Fixes#164
* Added a parse test for [Hidoi]_Amaenaideyo_MS_vol01_chp02.rar
* Fix annoying warning about SplitQuery on GetLibraryDtosForUsernameAsync
* Scan Bugfixes (#177)
* Added way more logging for debugging issue #163.
Fixed#175
* Removed some comment that isn't needed
* Fixed a enumeration issue due to removing while enumerating
* EPUB Support (#178)
* Added book filetype detection and reorganized tests due to size of file
* Added ability to get basic Parse Info from Book and Pages.
* We can now scan books and get them in a library with cover images.
* Take the first image in the epub if the cover isn't set.
* Implemented the ability to unzip the ebup to cache. Implemented a test api to load html files.
* Just some test code to figure out how to approach this.
* Fixed some merge conflicts
* Removed some dead code from merge
* Snapshot: I can now load everything properly into the UI by rewriting the urls before I send them back. I don't notice any lag from this method. It can be optimized further.
* Implemented a way to load the content in the browser not via an iframe.
* Added a note
* Anchor mappings is complete. New anchors are updated so references now resolve to javascript:void() for UI to take care of internally loading and the appropriate page is mapped to it. Anchors that are external have target="_blank" added so they don't force you out of the app and styles are of course inlined.
* Oops i need this
* Table of contents api implemented (rough) and some small enhancements to codebase for books.
* GetBookPageResources now only loads files from within the book. Nested chapter list support and images now use html parsing instead of string parsing.
* Fonts now are remapped to load from endpoint.
* book-resources now uses a key, ensuring the file is in proper format for lookup. Changed chapter list based on structure with one HEADER and nested chapters.
* Properly handle svg resource requests and when there are part anchors that are clickable, make sure we handle them in the UI by adding a kavita-page handler.
* Add Chapter group page even if one isn't set by using first page (without part) from nestedChildren.
* Added extra debug code for issue #163.
* Added new user preferences for books and updated the css so we scope it to our reading section.
* Cleaned up style code
* Implemented ability to save book preferences and some cleanup on existing apis.
* Added an api for checking if a user has read something in a library type before.
* Forgot to make sure the has reading progress is against a user lol.
* Remove cacheservice code for books, sine we use an in-memory method
* Handle svg images as well
* Enhanced cover image extraction to check for a "cover" image if the cover image wasn't set in OPF before falling back to the first image.
* Fixed an issue with special books not properly generating metadata due to not having filename set.
* Cleanup, removed warmup task code from statup/program and changed taskscheduler to schedule tasks on startup only (or if tasks are changed from UI).
* Code cleanup
* Code cleanup
* So much code. Lots of refactors to try to test scanner service. Moved a lot of the queries into Extensions to allow to easier test, even though it's hacky. Support @font-face src:url swaps with ' and ". Source summary information from epubs.
* Well...baseURL needs to come from BE and not from UI lol.
* Adjusted migrations so default values match Entity
* Removed comment
* I think I finally fixed#163! The issue was that when i checked if it had a parserInfo, i wasn't considering that the chapter range might have a - in it (0-6) and so when the code to check if range could parse out a number failed, it treated it like a special and checked range against info's filename.
* Some bugfixes
* Lots of testing, extracting code to make it easier to test. This code is buggy, but fixed a bug where 1) If we changed the normalization code, we would remove the whole db during a scan and 2) We weren't actually removing series properly.
Other than that, code is being extracted to remove duplication and centralize logic.
* More code cleanup and test cleanup to ensure scan loop is working as expected and matches expectaions from tests.
* Cleaned up the code and made it so if I change normalization, which I do in this branch, it wont break existing DBs.
* Some comic parser changes for partial chapter support.
* Added some code for directory service and scanner service along with python code to generate test files (not used yet). Fixed up all the tests.
* Code smells
* Book Feedback and small bugs (#183)
* Remove automatic retry for scanLibraries as if something fails, it wont pass magically. Catch exceptions when opening books for parsing and swallow to ignore the file.
* Delete extra attempts
* Switched to using FirstOrDefault for finding existing series. This will help avoid pointless crashes.
* Updated message when duplicate series are found (not sure how this happens)
* Fixed a negation for deleting volumes where files still exist.
* Implemented the ability to automatically scale the manga reader based on screen size.
* Feature/feedback (#185)
* Remove automatic retry for scanLibraries as if something fails, it wont pass magically. Catch exceptions when opening books for parsing and swallow to ignore the file.
* Delete extra attempts
* Switched to using FirstOrDefault for finding existing series. This will help avoid pointless crashes.
* Updated message when duplicate series are found (not sure how this happens)
* Fixed a negation for deleting volumes where files still exist.
* Implemented the ability to automatically scale the manga reader based on screen size.
* Default to automatic scaling
* Fix an issue where malformed epubs wouldn't be readable due to incorrect keys in the OPF. We now check if key is valid and if not, try to correct it. This makes a page load about a second on malformed books.
* Fixed#176. Refactored the recently added query to be restricted to user's access to libraries.
* Fixed a one off bug with In Progress series
* Implemented the ability to refresh metadata of just a single series directly
* Book Feedback (#190)
* Remove automatic retry for scanLibraries as if something fails, it wont pass magically. Catch exceptions when opening books for parsing and swallow to ignore the file.
* Delete extra attempts
* Switched to using FirstOrDefault for finding existing series. This will help avoid pointless crashes.
* Updated message when duplicate series are found (not sure how this happens)
* Fixed a negation for deleting volumes where files still exist.
* Implemented the ability to automatically scale the manga reader based on screen size.
* Default to automatic scaling
* Fix an issue where malformed epubs wouldn't be readable due to incorrect keys in the OPF. We now check if key is valid and if not, try to correct it. This makes a page load about a second on malformed books.
* Fixed#176. Refactored the recently added query to be restricted to user's access to libraries.
* Fixed a one off bug with In Progress series
* Implemented the ability to refresh metadata of just a single series directly
* Fixed a parser case where Series c000 (v01) would fail to parse the series
* Fixed#189. In Progress now returns data properly for library access and in multiple libraries.
* Fixed#188 by adding an extra message for bad login and updating UI
* Generate a fallback for table of contents by parsing the toc file (if we can find one)
* Bugfixes/misc (#196)
* Removed an error log statment which wasn't valid. Was showing error when a comicinfo.xml was not found in a directory.
* Fixed#191. Don't overwrite summary information if we already have something set from UI.
* Fixes#192
* Fixed#194 by moving the Take to after the query runs, so we take only distinct series.
* Added another case for Regex parsing for VanDread-v01-c01.zip
* Tap to Paginate User Pref (#197)
* Fixed In Progress and removed comments
* Tap to Paginate user setting is implemented. Fixes#193
* Implemented the ability to move between volumes (reading) automatically without existing the app. (#198)
* Feature/tech debt (#199)
* Added an icon for building the exe
* Technical debt
* Updated Readme for recruitment
* Regex addition (#200)
Co-authored-by: Andrew Song <asong641@gmail.com>
Joseph Milazzo