added display of a notification that the server is busy installing third-party software

- refactoring doInstallAction functions

client/CMakeLists.txt

@@ -21,13 +21,13 @@ set_property(GLOBAL PROPERTY PREDEFINED_TARGETS_FOLDER "Autogen")
 find_package(Qt6 REQUIRED COMPONENTS 
     Widgets Core Gui Network Xml 
     RemoteObjects Quick Svg QuickControls2 
-    Core5Compat
+    Core5Compat Concurrent
 )
 set(LIBS ${LIBS} 
     Qt6::Widgets Qt6::Core Qt6::Gui
     Qt6::Network Qt6::Xml Qt6::RemoteObjects
     Qt6::Quick Qt6::Svg Qt6::QuickControls2
-    Qt6::Core5Compat
+    Qt6::Core5Compat Qt6::Concurrent
 )
 
 qt_standard_project_setup()

client/core/scripts_registry.cpp

@@ -31,6 +31,7 @@ QString amnezia::scriptName(SharedScriptType type)
     case SharedScriptType::remove_all_containers: return QLatin1String("remove_all_containers.sh");
     case SharedScriptType::setup_host_firewall: return QLatin1String("setup_host_firewall.sh");
     case SharedScriptType::check_connection: return QLatin1String("check_connection.sh");
+    case SharedScriptType::check_server_is_busy: return QLatin1String("check_server_is_busy.sh");
     }
 }
 

client/core/scripts_registry.h

@@ -15,7 +15,8 @@ enum SharedScriptType {
     remove_container,
     remove_all_containers,
     setup_host_firewall,
-    check_connection
+    check_connection,
+    check_server_is_busy
 };
 enum ProtocolScriptType {
     // Protocol scripts

client/core/servercontroller.cpp

@@ -12,6 +12,8 @@
 #include <QApplication>
 #include <QTemporaryFile>
 #include <QFileInfo>
+#include <QThread>
+#include <QtConcurrent>
 
 #include "sftpchannel.h"
 #include "sshconnectionmanager.h"
@@ -528,14 +530,36 @@ ErrorCode ServerController::installDockerWorker(const ServerCredentials &credent
         stdOut += data + "\n";
     };
 
-    ErrorCode e = runScript(credentials,
+    QFutureWatcher<void> watcher;
+
+    QFuture<void> future = QtConcurrent::run([this, &stdOut, &cbReadStdOut, &cbReadStdErr, &credentials]() {
+        do {
+            stdOut.clear();
+            runScript(credentials,
+                      replaceVars(amnezia::scriptData(SharedScriptType::check_server_is_busy),
+                                  genVarsForScript(credentials)), cbReadStdOut, cbReadStdErr);
+            if (!stdOut.isEmpty() || stdOut.contains("Unable to acquire the dpkg frontend lock")) {
+                emit serverIsBusy(true);
+                QThread::msleep(1000);
+            }
+        } while (!stdOut.isEmpty());
+    });
+
+    watcher.setFuture(future);
+
+    QEventLoop wait;
+    QObject::connect(&watcher, &QFutureWatcher<void>::finished, &wait, &QEventLoop::quit);
+    wait.exec();
+
+    emit serverIsBusy(false);
+
+    ErrorCode error = runScript(credentials,
                                 replaceVars(amnezia::scriptData(SharedScriptType::install_docker),
-            genVarsForScript(credentials)),
+                                            genVarsForScript(credentials)), cbReadStdOut, cbReadStdErr);
-                cbReadStdOut, cbReadStdErr);
 
     if (stdOut.contains("command not found")) return ErrorCode::ServerDockerFailedError;
 
-    return e;
+    return error;
 }
 
 ErrorCode ServerController::prepareHostWorker(const ServerCredentials &credentials, DockerContainer container, const QJsonObject &config)

client/core/servercontroller.h

@@ -84,6 +84,9 @@ private:
 
     std::shared_ptr<Settings> m_settings;
     std::shared_ptr<VpnConfigurator> m_configurator;
+
+signals:
+    void serverIsBusy(const bool isBusy);
 };
 
 #endif // SERVERCONTROLLER_H

client/resources.qrc

@@ -160,5 +160,6 @@
         <file>ui/qml/Pages/PageQrDecoderIos.qml</file>
         <file>server_scripts/website_tor/Dockerfile</file>
         <file>ui/qml/Pages/PageViewConfig.qml</file>
+        <file>server_scripts/check_server_is_busy.sh</file>
     </qresource>
 </RCC>

client/server_scripts/check_server_is_busy.sh

@@ -0,0 +1,4 @@
+pm_apt="/usr/bin/apt-get";\
+if [[ -f "$pm_apt" ]]; then pm=$pm_apt; else exit; fi;\
+if [[ ! -f "/usr/bin/sudo" ]]; then $pm update -y -q; $pm install -y -q sudo; fi;\
+sudo fuser /var/lib/dpkg/lock-frontend

client/ui/pages_logic/ServerConfiguringProgressLogic.cpp

@@ -5,6 +5,8 @@
 #include <QEventLoop>
 #include <QMessageBox>
 
+#include "core/servercontroller.h"
+
 ServerConfiguringProgressLogic::ServerConfiguringProgressLogic(UiLogic *logic, QObject *parent):
     PageLogicBase(logic, parent),
     m_progressBarValue{0},
@@ -13,7 +15,9 @@ ServerConfiguringProgressLogic::ServerConfiguringProgressLogic(UiLogic *logic, Q
     m_progressBarVisible{true},
     m_progressBarMaximium{100},
     m_progressBarTextVisible{true},
-    m_progressBarText{tr("Configuring...")}
+    m_progressBarText{tr("Configuring...")},
+    m_labelServerBusyVisible{false},
+    m_labelServerBusyText{""}
 {
 
 }
@@ -30,8 +34,8 @@ ErrorCode ServerConfiguringProgressLogic::doInstallAction(const std::function<Er
     page.setEnabledFunc = [this] (bool enabled) -> void {
         set_pageEnabled(enabled);
     };
-    ButtonFunc button;
+    ButtonFunc noButton;
-    LabelFunc info;
+    LabelFunc noWaitInfo;
     ProgressFunc progress;
     progress.setVisibleFunc = [this] (bool visible) -> void {
         set_progressBarVisible(visible);
@@ -47,8 +51,24 @@ ErrorCode ServerConfiguringProgressLogic::doInstallAction(const std::function<Er
         return progressBarMaximium();
     };
 
+    LabelFunc busyInfo;
+    busyInfo.setTextFunc = [this] (const QString& text) -> void {
+        set_labelServerBusyText(text);
+    };
+    busyInfo.setVisibleFunc = [this] (bool visible) -> void {
+        set_labelServerBusyVisible(visible);
+    };
 
+    return doInstallAction(action, page, progress, noButton, noWaitInfo, busyInfo);
+}
 
+ErrorCode ServerConfiguringProgressLogic::doInstallAction(const std::function<ErrorCode()> &action,
+                                                          const PageFunc &page,
+                                                          const ProgressFunc &progress,
+                                                          const ButtonFunc &button,
+                                                          const LabelFunc &waitInfo,
+                                                          const LabelFunc &serverBusyInfo)
+{
     progress.setVisibleFunc(true);
     if (page.setEnabledFunc) {
         page.setEnabledFunc(false);
@@ -56,11 +76,11 @@ ErrorCode ServerConfiguringProgressLogic::doInstallAction(const std::function<Er
     if (button.setVisibleFunc) {
         button.setVisibleFunc(false);
     }
-    if (info.setVisibleFunc) {
+    if (waitInfo.setVisibleFunc) {
-        info.setVisibleFunc(true);
+        waitInfo.setVisibleFunc(true);
     }
-    if (info.setTextFunc) {
+    if (waitInfo.setTextFunc) {
-        info.setTextFunc(tr("Please wait, configuring process may take up to 5 minutes"));
+        waitInfo.setTextFunc(tr("Please wait, configuring process may take up to 5 minutes"));
     }
 
     QTimer timer;
@@ -71,8 +91,26 @@ ErrorCode ServerConfiguringProgressLogic::doInstallAction(const std::function<Er
     progress.setValueFunc(0);
     timer.start(1000);
 
+    QMetaObject::Connection connection;
+    if (serverBusyInfo.setTextFunc) {
+        connection = connect(m_serverController.get(),
+                             &ServerController::serverIsBusy,
+                             this,
+                             [&serverBusyInfo, &timer](const bool isBusy) {
+            isBusy ? timer.stop() : timer.start(1000);
+            serverBusyInfo.setVisibleFunc(isBusy);
+            serverBusyInfo.setTextFunc(isBusy ? "Amnesia has detected that your server is currently "
+                                                "busy installing other software. Amnesia installation "
+                                                "will pause until the server finishes installing other software"
+                                              : "");
+        });
+    }
+
     ErrorCode e = action();
     qDebug() << "doInstallAction finished with code" << e;
+    if (serverBusyInfo.setTextFunc) {
+        disconnect(connection);
+    }
 
     if (e) {
         if (page.setEnabledFunc) {
@@ -81,8 +119,8 @@ ErrorCode ServerConfiguringProgressLogic::doInstallAction(const std::function<Er
         if (button.setVisibleFunc) {
             button.setVisibleFunc(true);
         }
-        if (info.setVisibleFunc) {
+        if (waitInfo.setVisibleFunc) {
-            info.setVisibleFunc(false);
+            waitInfo.setVisibleFunc(false);
         }
         QMessageBox::warning(nullptr, APPLICATION_NAME,
                              tr("Error occurred while configuring server.") + "\n" +
@@ -95,9 +133,9 @@ ErrorCode ServerConfiguringProgressLogic::doInstallAction(const std::function<Er
     // just ui progressbar tweak
     timer.stop();
 
-    int remaining_val = progress.getMaximiumFunc() - progress.getValueFunc();
+    int remainingVal = progress.getMaximiumFunc() - progress.getValueFunc();
 
-    if (remaining_val > 0) {
+    if (remainingVal > 0) {
         QTimer timer1;
         QEventLoop loop1;
 
@@ -120,8 +158,8 @@ ErrorCode ServerConfiguringProgressLogic::doInstallAction(const std::function<Er
     if (page.setEnabledFunc) {
         page.setEnabledFunc(true);
     }
-    if (info.setTextFunc) {
+    if (waitInfo.setTextFunc) {
-        info.setTextFunc(tr("Operation finished"));
+        waitInfo.setTextFunc(tr("Operation finished"));
     }
     return ErrorCode::NoError;
 }

client/ui/pages_logic/ServerConfiguringProgressLogic.h

@@ -20,13 +20,8 @@ class ServerConfiguringProgressLogic : public PageLogicBase
     AUTO_PROPERTY(int, progressBarMaximium)
     AUTO_PROPERTY(bool, progressBarTextVisible)
     AUTO_PROPERTY(QString, progressBarText)
-
+    AUTO_PROPERTY(bool, labelServerBusyVisible)
-public:
+    AUTO_PROPERTY(QString, labelServerBusyText)
-    explicit ServerConfiguringProgressLogic(UiLogic *uiLogic, QObject *parent = nullptr);
-    ~ServerConfiguringProgressLogic() = default;
-
-    void onUpdatePage() override;
-    ErrorCode doInstallAction(const std::function<ErrorCode()> &action);
 
 private:
     struct ProgressFunc {
@@ -48,5 +43,23 @@ private:
         std::function<void(const QString&)> setTextFunc;
     };
 
+public:
+    explicit ServerConfiguringProgressLogic(UiLogic *uiLogic, QObject *parent = nullptr);
+    ~ServerConfiguringProgressLogic() = default;
+
+    friend class OpenVpnLogic;
+    friend class ShadowSocksLogic;
+    friend class CloakLogic;
+    friend class UiLogic;
+
+    void onUpdatePage() override;
+    ErrorCode doInstallAction(const std::function<ErrorCode()> &action);
+    ErrorCode doInstallAction(const std::function<ErrorCode()> &action,
+                              const PageFunc &page,
+                              const ProgressFunc &progress,
+                              const ButtonFunc &button,
+                              const LabelFunc &waitInfo,
+                              const LabelFunc &serverBusyInfo);
+
 };
 #endif // SERVER_CONFIGURING_PROGRESS_LOGIC_H

client/ui/pages_logic/protocols/CloakLogic.cpp

@@ -1,7 +1,10 @@
 #include "CloakLogic.h"
-#include "core/servercontroller.h"
+
 #include <functional>
-#include "../../uilogic.h"
+
+#include "core/servercontroller.h"
+#include "ui/uilogic.h"
+#include "ui/pages_logic/ServerConfiguringProgressLogic.h"
 
 using namespace amnezia;
 using namespace PageEnumNS;
@@ -59,40 +62,59 @@ void CloakLogic::onPushButtonSaveClicked()
     QJsonObject newContainerConfig = containerConfig;
     newContainerConfig.insert(ProtocolProps::protoToString(Proto::Cloak), protocolConfig);
 
-    UiLogic::PageFunc page_func;
+    ServerConfiguringProgressLogic::PageFunc pageFunc;
-    page_func.setEnabledFunc = [this] (bool enabled) -> void {
+    pageFunc.setEnabledFunc = [this] (bool enabled) -> void {
         set_pageEnabled(enabled);
     };
-    UiLogic::ButtonFunc pushButton_save_func;
+    ServerConfiguringProgressLogic::ButtonFunc saveButtonFunc;
-    pushButton_save_func.setVisibleFunc = [this] (bool visible) ->void {
+    saveButtonFunc.setVisibleFunc = [this] (bool visible) -> void {
         set_pushButtonSaveVisible(visible);
     };
-    UiLogic::LabelFunc label_info_func;
+    ServerConfiguringProgressLogic::LabelFunc waitInfoFunc;
-    label_info_func.setVisibleFunc = [this] (bool visible) ->void {
+    waitInfoFunc.setVisibleFunc = [this] (bool visible) -> void {
         set_labelInfoVisible(visible);
     };
-    label_info_func.setTextFunc = [this] (const QString& text) ->void {
+    waitInfoFunc.setTextFunc = [this] (const QString& text) -> void {
         set_labelInfoText(text);
     };
-    UiLogic::ProgressFunc progressBar_reset;
+    ServerConfiguringProgressLogic::ProgressFunc progressBarFunc;
-    progressBar_reset.setVisibleFunc = [this] (bool visible) ->void {
+    progressBarFunc.setVisibleFunc = [this] (bool visible) -> void {
         set_progressBarResetVisible(visible);
     };
-    progressBar_reset.setValueFunc = [this] (int value) ->void {
+    progressBarFunc.setValueFunc = [this] (int value) -> void {
         set_progressBarResetValue(value);
     };
-    progressBar_reset.getValueFunc = [this] (void) -> int {
+    progressBarFunc.getValueFunc = [this] (void) -> int {
         return progressBarResetValue();
     };
-    progressBar_reset.getMaximiumFunc = [this] (void) -> int {
+    progressBarFunc.getMaximiumFunc = [this] (void) -> int {
         return progressBarResetMaximium();
     };
+    progressBarFunc.setTextVisibleFunc = [this] (bool visible) -> void {
+        set_progressBarTextVisible(visible);
+    };
+    progressBarFunc.setTextFunc = [this] (const QString& text) -> void {
+        set_progressBarText(text);
+    };
 
-    ErrorCode e = uiLogic()->doInstallAction([this, containerConfig, &newContainerConfig](){
+    ServerConfiguringProgressLogic::LabelFunc busyInfoFuncy;
-        return m_serverController->updateContainer(m_settings->serverCredentials(uiLogic()->selectedServerIndex), uiLogic()->selectedDockerContainer, containerConfig, newContainerConfig);
+    busyInfoFuncy.setTextFunc = [this] (const QString& text) -> void {
+        set_labelServerBusyText(text);
+    };
+    busyInfoFuncy.setVisibleFunc = [this] (bool visible) -> void {
+        set_labelServerBusyVisible(visible);
+    };
+
+    progressBarFunc.setTextVisibleFunc(true);
+    progressBarFunc.setTextFunc(QString("Configuring..."));
+    ErrorCode e = uiLogic()->pageLogic<ServerConfiguringProgressLogic>()->doInstallAction([this, containerConfig, &newContainerConfig](){
+        return m_serverController->updateContainer(m_settings->serverCredentials(uiLogic()->selectedServerIndex),
+                                                   uiLogic()->selectedDockerContainer,
+                                                   containerConfig,
+                                                   newContainerConfig);
     },
-    page_func, progressBar_reset,
+    pageFunc, progressBarFunc,
-    pushButton_save_func, label_info_func);
+    saveButtonFunc, waitInfoFunc, busyInfoFuncy);
 
     if (!e) {
         m_settings->setContainerConfig(uiLogic()->selectedServerIndex, uiLogic()->selectedDockerContainer, newContainerConfig);

client/ui/pages_logic/protocols/CloakLogic.h

@@ -20,7 +20,11 @@ class CloakLogic : public PageProtocolLogicBase
     AUTO_PROPERTY(QString, labelInfoText)
     AUTO_PROPERTY(int, progressBarResetValue)
     AUTO_PROPERTY(int, progressBarResetMaximium)
+    AUTO_PROPERTY(bool, progressBarTextVisible)
+    AUTO_PROPERTY(QString, progressBarText)
 
+    AUTO_PROPERTY(bool, labelServerBusyVisible)
+    AUTO_PROPERTY(QString, labelServerBusyText)
 public:
     Q_INVOKABLE void onPushButtonSaveClicked();
 

client/ui/pages_logic/protocols/OpenVpnLogic.cpp

@@ -1,7 +1,10 @@
 #include "OpenVpnLogic.h"
-#include "core/servercontroller.h"
+
 #include <functional>
-#include "../../uilogic.h"
+
+#include "core/servercontroller.h"
+#include "ui/uilogic.h"
+#include "ui/pages_logic/ServerConfiguringProgressLogic.h"
 
 using namespace amnezia;
 using namespace PageEnumNS;
@@ -98,40 +101,59 @@ void OpenVpnLogic::onPushButtonProtoOpenVpnSaveClicked()
     QJsonObject newContainerConfig = containerConfig;
     newContainerConfig.insert(ProtocolProps::protoToString(Proto::OpenVpn), protocolConfig);
 
-    UiLogic::PageFunc page_proto_openvpn;
+    ServerConfiguringProgressLogic::PageFunc pageFunc;
-    page_proto_openvpn.setEnabledFunc = [this] (bool enabled) -> void {
+    pageFunc.setEnabledFunc = [this] (bool enabled) -> void {
         set_pageEnabled(enabled);
     };
-    UiLogic::ButtonFunc pushButton_proto_openvpn_save;
+    ServerConfiguringProgressLogic::ButtonFunc saveButtonFunc;
-    pushButton_proto_openvpn_save.setVisibleFunc = [this] (bool visible) ->void {
+    saveButtonFunc.setVisibleFunc = [this] (bool visible) -> void {
         set_pushButtonSaveVisible(visible);
     };
-    UiLogic::LabelFunc label_proto_openvpn_info;
+    ServerConfiguringProgressLogic::LabelFunc waitInfoFunc;
-    label_proto_openvpn_info.setVisibleFunc = [this] (bool visible) ->void {
+    waitInfoFunc.setVisibleFunc = [this] (bool visible) -> void {
         set_labelProtoOpenVpnInfoVisible(visible);
     };
-    label_proto_openvpn_info.setTextFunc = [this] (const QString& text) ->void {
+    waitInfoFunc.setTextFunc = [this] (const QString& text) -> void {
         set_labelProtoOpenVpnInfoText(text);
     };
-    UiLogic::ProgressFunc progressBar_proto_openvpn_reset;
+    ServerConfiguringProgressLogic::ProgressFunc progressBarFunc;
-    progressBar_proto_openvpn_reset.setVisibleFunc = [this] (bool visible) ->void {
+    progressBarFunc.setVisibleFunc = [this] (bool visible) -> void {
         set_progressBarResetVisible(visible);
     };
-    progressBar_proto_openvpn_reset.setValueFunc = [this] (int value) ->void {
+    progressBarFunc.setValueFunc = [this] (int value) -> void {
         set_progressBarResetValue(value);
     };
-    progressBar_proto_openvpn_reset.getValueFunc = [this] (void) -> int {
+    progressBarFunc.getValueFunc = [this] (void) -> int {
         return progressBarResetValue();
     };
-    progressBar_proto_openvpn_reset.getMaximiumFunc = [this] (void) -> int {
+    progressBarFunc.getMaximiumFunc = [this] (void) -> int {
         return progressBarResetMaximium();
     };
+    progressBarFunc.setTextVisibleFunc = [this] (bool visible) -> void {
+        set_progressBarTextVisible(visible);
+    };
+    progressBarFunc.setTextFunc = [this] (const QString& text) -> void {
+        set_progressBarText(text);
+    };
 
-    ErrorCode e = uiLogic()->doInstallAction([this, containerConfig, &newContainerConfig](){
+    ServerConfiguringProgressLogic::LabelFunc busyInfoFuncy;
-        return m_serverController->updateContainer(m_settings->serverCredentials(uiLogic()->selectedServerIndex), uiLogic()->selectedDockerContainer, containerConfig, newContainerConfig);
+    busyInfoFuncy.setTextFunc = [this] (const QString& text) -> void {
+        set_labelServerBusyText(text);
+    };
+    busyInfoFuncy.setVisibleFunc = [this] (bool visible) -> void {
+        set_labelServerBusyVisible(visible);
+    };
+
+    progressBarFunc.setTextVisibleFunc(true);
+    progressBarFunc.setTextFunc(QString("Configuring..."));
+    ErrorCode e = uiLogic()->pageLogic<ServerConfiguringProgressLogic>()->doInstallAction([this, containerConfig, &newContainerConfig](){
+        return m_serverController->updateContainer(m_settings->serverCredentials(uiLogic()->selectedServerIndex),
+                                                   uiLogic()->selectedDockerContainer,
+                                                   containerConfig,
+                                                   newContainerConfig);
     },
-    page_proto_openvpn, progressBar_proto_openvpn_reset,
+    pageFunc, progressBarFunc,
-    pushButton_proto_openvpn_save, label_proto_openvpn_info);
+    saveButtonFunc, waitInfoFunc, busyInfoFuncy);
 
     if (!e) {
         m_settings->setContainerConfig(uiLogic()->selectedServerIndex, uiLogic()->selectedDockerContainer, newContainerConfig);

client/ui/pages_logic/protocols/OpenVpnLogic.h

@@ -34,6 +34,11 @@ class OpenVpnLogic : public PageProtocolLogicBase
     AUTO_PROPERTY(QString, labelProtoOpenVpnInfoText)
     AUTO_PROPERTY(int, progressBarResetValue)
     AUTO_PROPERTY(int, progressBarResetMaximium)
+    AUTO_PROPERTY(bool, progressBarTextVisible)
+    AUTO_PROPERTY(QString, progressBarText)
+
+    AUTO_PROPERTY(bool, labelServerBusyVisible)
+    AUTO_PROPERTY(QString, labelServerBusyText)
 
 public:
     Q_INVOKABLE void onPushButtonProtoOpenVpnSaveClicked();

client/ui/pages_logic/protocols/ShadowSocksLogic.cpp

@@ -1,7 +1,10 @@
 #include "ShadowSocksLogic.h"
-#include "core/servercontroller.h"
+
 #include <functional>
-#include "../../uilogic.h"
+
+#include "core/servercontroller.h"
+#include "ui/pages_logic/ServerConfiguringProgressLogic.h"
+#include "ui/uilogic.h"
 
 using namespace amnezia;
 using namespace PageEnumNS;
@@ -11,12 +14,12 @@ ShadowSocksLogic::ShadowSocksLogic(UiLogic *logic, QObject *parent):
     m_comboBoxCipherText{"chacha20-poly1305"},
     m_lineEditPortText{},
     m_pushButtonSaveVisible{false},
-    m_progressBaResetVisible{false},
+    m_progressBarResetVisible{false},
     m_lineEditPortEnabled{false},
     m_labelInfoVisible{true},
     m_labelInfoText{},
-    m_progressBaResetValue{0},
+    m_progressBarResetValue{0},
-    m_progressBaResetMaximium{100}
+    m_progressBarResetMaximium{100}
 {
 
 }
@@ -25,7 +28,7 @@ void ShadowSocksLogic::updateProtocolPage(const QJsonObject &ssConfig, DockerCon
 {
     set_pageEnabled(haveAuthData);
     set_pushButtonSaveVisible(haveAuthData);
-    set_progressBaResetVisible(haveAuthData);
+    set_progressBarResetVisible(haveAuthData);
 
     set_comboBoxCipherText(ssConfig.value(config_key::cipher).
                                           toString(protocols::shadowsocks::defaultCipher));
@@ -51,40 +54,59 @@ void ShadowSocksLogic::onPushButtonSaveClicked()
     QJsonObject containerConfig = m_settings->containerConfig(uiLogic()->selectedServerIndex, uiLogic()->selectedDockerContainer);
     QJsonObject newContainerConfig = containerConfig;
     newContainerConfig.insert(ProtocolProps::protoToString(Proto::ShadowSocks), protocolConfig);
-    UiLogic::PageFunc page_proto_shadowsocks;
+    ServerConfiguringProgressLogic::PageFunc pageFunc;
-    page_proto_shadowsocks.setEnabledFunc = [this] (bool enabled) -> void {
+    pageFunc.setEnabledFunc = [this] (bool enabled) -> void {
         set_pageEnabled(enabled);
     };
-    UiLogic::ButtonFunc pushButton_proto_shadowsocks_save;
+    ServerConfiguringProgressLogic::ButtonFunc saveButtonFunc;
-    pushButton_proto_shadowsocks_save.setVisibleFunc = [this] (bool visible) ->void {
+    saveButtonFunc.setVisibleFunc = [this] (bool visible) -> void {
         set_pushButtonSaveVisible(visible);
     };
-    UiLogic::LabelFunc label_proto_shadowsocks_info;
+    ServerConfiguringProgressLogic::LabelFunc waitInfoFunc;
-    label_proto_shadowsocks_info.setVisibleFunc = [this] (bool visible) ->void {
+    waitInfoFunc.setVisibleFunc = [this] (bool visible) -> void {
         set_labelInfoVisible(visible);
     };
-    label_proto_shadowsocks_info.setTextFunc = [this] (const QString& text) ->void {
+    waitInfoFunc.setTextFunc = [this] (const QString& text) -> void {
         set_labelInfoText(text);
     };
-    UiLogic::ProgressFunc progressBar_reset;
+    ServerConfiguringProgressLogic::ProgressFunc progressBarFunc;
-    progressBar_reset.setVisibleFunc = [this] (bool visible) ->void {
+    progressBarFunc.setVisibleFunc = [this] (bool visible) -> void {
-        set_progressBaResetVisible(visible);
+        set_progressBarResetVisible(visible);
     };
-    progressBar_reset.setValueFunc = [this] (int value) ->void {
+    progressBarFunc.setValueFunc = [this] (int value) -> void {
-        set_progressBaResetValue(value);
+        set_progressBarResetValue(value);
     };
-    progressBar_reset.getValueFunc = [this] (void) -> int {
+    progressBarFunc.getValueFunc = [this] (void) -> int {
-        return progressBaResetValue();
+        return progressBarResetValue();
     };
-    progressBar_reset.getMaximiumFunc = [this] (void) -> int {
+    progressBarFunc.getMaximiumFunc = [this] (void) -> int {
-        return progressBaResetMaximium();
+        return progressBarResetMaximium();
+    };
+    progressBarFunc.setTextVisibleFunc = [this] (bool visible) -> void {
+        set_progressBarTextVisible(visible);
+    };
+    progressBarFunc.setTextFunc = [this] (const QString& text) -> void {
+        set_progressBarText(text);
     };
 
-    ErrorCode e = uiLogic()->doInstallAction([this, containerConfig, &newContainerConfig](){
+    ServerConfiguringProgressLogic::LabelFunc busyInfoFuncy;
-        return m_serverController->updateContainer(m_settings->serverCredentials(uiLogic()->selectedServerIndex), uiLogic()->selectedDockerContainer, containerConfig, newContainerConfig);
+    busyInfoFuncy.setTextFunc = [this] (const QString& text) -> void {
+        set_labelServerBusyText(text);
+    };
+    busyInfoFuncy.setVisibleFunc = [this] (bool visible) -> void {
+        set_labelServerBusyVisible(visible);
+    };
+
+    progressBarFunc.setTextVisibleFunc(true);
+    progressBarFunc.setTextFunc(QString("Configuring..."));
+    ErrorCode e = uiLogic()->pageLogic<ServerConfiguringProgressLogic>()->doInstallAction([this, containerConfig, &newContainerConfig](){
+        return m_serverController->updateContainer(m_settings->serverCredentials(uiLogic()->selectedServerIndex),
+                                                   uiLogic()->selectedDockerContainer,
+                                                   containerConfig,
+                                                   newContainerConfig);
     },
-    page_proto_shadowsocks, progressBar_reset,
+    pageFunc, progressBarFunc,
-    pushButton_proto_shadowsocks_save, label_proto_shadowsocks_info);
+    saveButtonFunc, waitInfoFunc, busyInfoFuncy);
 
     if (!e) {
         m_settings->setContainerConfig(uiLogic()->selectedServerIndex, uiLogic()->selectedDockerContainer, newContainerConfig);

client/ui/pages_logic/protocols/ShadowSocksLogic.h

@@ -12,13 +12,17 @@ class ShadowSocksLogic : public PageProtocolLogicBase
     AUTO_PROPERTY(QString, comboBoxCipherText)
     AUTO_PROPERTY(QString, lineEditPortText)
     AUTO_PROPERTY(bool, pushButtonSaveVisible)
-    AUTO_PROPERTY(bool, progressBaResetVisible)
+    AUTO_PROPERTY(bool, progressBarResetVisible)
     AUTO_PROPERTY(bool, lineEditPortEnabled)
     AUTO_PROPERTY(bool, labelInfoVisible)
     AUTO_PROPERTY(QString, labelInfoText)
-    AUTO_PROPERTY(int, progressBaResetValue)
+    AUTO_PROPERTY(int, progressBarResetValue)
-    AUTO_PROPERTY(int, progressBaResetMaximium)
+    AUTO_PROPERTY(int, progressBarResetMaximium)
+    AUTO_PROPERTY(bool, progressBarTextVisible)
+    AUTO_PROPERTY(QString, progressBarText)
 
+    AUTO_PROPERTY(bool, labelServerBusyVisible)
+    AUTO_PROPERTY(QString, labelServerBusyText)
 public:
     Q_INVOKABLE void onPushButtonSaveClicked();
 

client/ui/qml/Pages/PageServerConfiguringProgress.qml

@@ -27,6 +27,22 @@ PageBase {
         horizontalAlignment: Text.AlignHCenter
     }
 
+    LabelType {
+        id: labelServerBusy
+        x: 0
+        anchors.top: label.bottom
+        anchors.topMargin: 30
+
+        anchors.horizontalCenter: parent.horizontalCenter
+        horizontalAlignment: Text.AlignHCenter
+
+        width: parent.width - 40
+        height: 41
+
+        text: ServerConfiguringProgressLogic.labelServerBusyText
+        visible: ServerConfiguringProgressLogic.labelServerBusyVisible
+    }
+
     LabelType {
         anchors.bottom: pr.top
         anchors.bottomMargin: 20

client/ui/qml/Pages/Protocols/PageProtoCloak.qml

@@ -14,6 +14,7 @@ PageProtocolBase {
     enabled: logic.pageEnabled
     BackButton {
         id: back
+        enabled: logic.pageEnabled
     }
 
     Caption {
@@ -110,12 +111,20 @@ PageProtocolBase {
         }
     }
 
+    LabelType {
+        id: label_server_busy
+        horizontalAlignment: Text.AlignHCenter
+        Layout.maximumWidth: parent.width
+        Layout.fillWidth: true
+        visible: logic.labelServerBusyVisible
+        text: logic.labelServerBusyText
+    }
+
     LabelType {
         id: label_proto_cloak_info
-        x: 30
+        horizontalAlignment: Text.AlignHCenter
-        anchors.bottom: pb_save.top
+        Layout.maximumWidth: parent.width
-        anchors.bottomMargin: 10
+        Layout.fillWidth: true
-        width: parent.width - 40
         visible: logic.labelInfoVisible
         text: logic.labelInfoText
     }
@@ -146,6 +155,19 @@ PageProtocolBase {
             }
         }
         visible: logic.progressBarResetVisible
+        LabelType {
+            anchors.left: parent.left
+            anchors.right: parent.right
+            anchors.verticalCenter: parent.verticalCenter
+            text: logic.progressBarText
+            horizontalAlignment: Text.AlignHCenter
+            verticalAlignment: Text.AlignVCenter
+            font.family: "Lato"
+            font.styleName: "normal"
+            font.pixelSize: 16
+            color: "#D4D4D4"
+            visible: logic.progressBarTextVisible
+        }
     }
     BlueButtonType {
         id: pb_save

client/ui/qml/Pages/Protocols/PageProtoOpenVPN.qml

@@ -13,6 +13,7 @@ PageProtocolBase {
 
     BackButton {
         id: back
+        enabled: logic.pageEnabled
     }
     Caption {
         id: caption
@@ -345,9 +346,19 @@ PageProtocolBase {
             }
 
             LabelType {
-                id: label_proto_openvpn_info
+                id: label_server_busy
+                horizontalAlignment: Text.AlignHCenter
+                Layout.maximumWidth: parent.width
+                Layout.fillWidth: true
+                visible: logic.labelServerBusyVisible
+                text: logic.labelServerBusyText
+            }
 
-                height: 41
+            LabelType {
+                id: label_proto_openvpn_info
+                horizontalAlignment: Text.AlignHCenter
+                Layout.maximumWidth: parent.width
+                Layout.fillWidth: true
                 visible: logic.labelProtoOpenVpnInfoVisible
                 text: logic.labelProtoOpenVpnInfoText
             }
@@ -395,11 +406,20 @@ PageProtocolBase {
                         }
                     }
                 }
-
+                LabelType {
+                    anchors.left: parent.left
+                    anchors.right: parent.right
+                    anchors.verticalCenter: parent.verticalCenter
+                    text: logic.progressBarText
+                    horizontalAlignment: Text.AlignHCenter
+                    verticalAlignment: Text.AlignVCenter
+                    font.family: "Lato"
+                    font.styleName: "normal"
+                    font.pixelSize: 16
+                    color: "#D4D4D4"
+                    visible: logic.progressBarTextVisible
+                }
             }
-
         }
-
     }
-
 }

client/ui/qml/Pages/Protocols/PageProtoShadowSocks.qml

@@ -13,6 +13,7 @@ PageProtocolBase {
 
     BackButton {
         id: back
+        enabled: logic.pageEnabled
     }
 
     Caption {
@@ -88,27 +89,33 @@ PageProtocolBase {
         Item {
             Layout.fillHeight: true
         }
-    }
 
+        LabelType {
+            id: label_server_busy
+            horizontalAlignment: Text.AlignHCenter
+            Layout.maximumWidth: parent.width
+            Layout.fillWidth: true
+            visible: logic.labelServerBusyVisible
+            text: logic.labelServerBusyText
+        }
 
         LabelType {
             id: label_proto_shadowsocks_info
-        x: 30
+            horizontalAlignment: Text.AlignHCenter
-        anchors.bottom: pb_save.top
+            Layout.maximumWidth: parent.width
-        anchors.bottomMargin: 10
+            Layout.fillWidth: true
-        width: parent.width - 40
-        height: 41
             visible: logic.labelInfoVisible
             text: logic.labelInfoText
         }
+    }
 
     ProgressBar {
         id: progressBar_reset
         anchors.fill: pb_save
         from: 0
-        to: logic.progressBaResetMaximium
+        to: logic.progressBarResetMaximium
-        value: logic.progressBaResetValue
+        value: logic.progressBarResetValue
-        visible: logic.progressBaResetVisible
+        visible: logic.progressBarResetVisible
         background: Rectangle {
             implicitWidth: parent.width
             implicitHeight: parent.height
@@ -126,6 +133,19 @@ PageProtocolBase {
                 color: Qt.rgba(255, 255, 255, 0.15);
             }
         }
+        LabelType {
+            anchors.left: parent.left
+            anchors.right: parent.right
+            anchors.verticalCenter: parent.verticalCenter
+            text: logic.progressBarText
+            horizontalAlignment: Text.AlignHCenter
+            verticalAlignment: Text.AlignVCenter
+            font.family: "Lato"
+            font.styleName: "normal"
+            font.pixelSize: 16
+            color: "#D4D4D4"
+            visible: logic.progressBarTextVisible
+        }
     }
 
     BlueButtonType {

client/ui/uilogic.cpp

@@ -303,44 +303,62 @@ void UiLogic::installServer(QMap<DockerContainer, QJsonObject> &containers)
     loop.exec();
     qApp->processEvents();
 
-    PageFunc page_new_server_configuring;
+    ServerConfiguringProgressLogic::PageFunc pageFunc;
-    page_new_server_configuring.setEnabledFunc = [this] (bool enabled) -> void {
+    pageFunc.setEnabledFunc = [this] (bool enabled) -> void {
         pageLogic<ServerConfiguringProgressLogic>()->set_pageEnabled(enabled);
     };
-    ButtonFunc no_button;
+
-    LabelFunc label_new_server_configuring_wait_info;
+    ServerConfiguringProgressLogic::ButtonFunc noButton;
-    label_new_server_configuring_wait_info.setTextFunc = [this] (const QString& text) -> void {
+
+    ServerConfiguringProgressLogic::LabelFunc waitInfoFunc;
+    waitInfoFunc.setTextFunc = [this] (const QString& text) -> void {
         pageLogic<ServerConfiguringProgressLogic>()->set_labelWaitInfoText(text);
     };
-    label_new_server_configuring_wait_info.setVisibleFunc = [this] (bool visible) ->void {
+    waitInfoFunc.setVisibleFunc = [this] (bool visible) -> void {
         pageLogic<ServerConfiguringProgressLogic>()->set_labelWaitInfoVisible(visible);
     };
-    ProgressFunc progressBar_new_server_configuring;
+
-    progressBar_new_server_configuring.setVisibleFunc = [this] (bool visible) ->void {
+    ServerConfiguringProgressLogic::ProgressFunc progressBarFunc;
+    progressBarFunc.setVisibleFunc = [this] (bool visible) -> void {
         pageLogic<ServerConfiguringProgressLogic>()->set_progressBarVisible(visible);
     };
-    progressBar_new_server_configuring.setValueFunc = [this] (int value) ->void {
+    progressBarFunc.setValueFunc = [this] (int value) -> void {
         pageLogic<ServerConfiguringProgressLogic>()->set_progressBarValue(value);
     };
-    progressBar_new_server_configuring.getValueFunc = [this] (void) -> int {
+    progressBarFunc.getValueFunc = [this] (void) -> int {
         return pageLogic<ServerConfiguringProgressLogic>()->progressBarValue();
     };
-    progressBar_new_server_configuring.getMaximiumFunc = [this] (void) -> int {
+    progressBarFunc.getMaximiumFunc = [this] (void) -> int {
         return pageLogic<ServerConfiguringProgressLogic>()->progressBarMaximium();
     };
-    progressBar_new_server_configuring.setTextVisibleFunc = [this] (bool visible) ->void {
+    progressBarFunc.setTextVisibleFunc = [this] (bool visible) -> void {
         pageLogic<ServerConfiguringProgressLogic>()->set_progressBarTextVisible(visible);
     };
-    progressBar_new_server_configuring.setTextFunc = [this] (const QString& text) ->void {
+    progressBarFunc.setTextFunc = [this] (const QString& text) -> void {
         pageLogic<ServerConfiguringProgressLogic>()->set_progressBarText(text);
     };
-    bool ok = installContainers(installCredentials, containers,
-                                page_new_server_configuring,
-                                progressBar_new_server_configuring,
-                                no_button,
-                                label_new_server_configuring_wait_info);
 
-    if (ok) {
+    ServerConfiguringProgressLogic::LabelFunc busyInfoFunc;
+    busyInfoFunc.setTextFunc = [this] (const QString& text) -> void {
+        pageLogic<ServerConfiguringProgressLogic>()->set_labelServerBusyText(text);
+    };
+    busyInfoFunc.setVisibleFunc = [this] (bool visible) -> void {
+        pageLogic<ServerConfiguringProgressLogic>()->set_labelServerBusyVisible(visible);
+    };
+
+    int count = 0;
+    ErrorCode error;
+    for (QMap<DockerContainer, QJsonObject>::iterator i = containers.begin(); i != containers.end(); i++, count++) {
+        progressBarFunc.setTextFunc(QString("Installing %1 %2 %3").arg(count+1).arg(tr("of")).arg(containers.size()));
+
+        error = pageLogic<ServerConfiguringProgressLogic>()->doInstallAction([&] () {
+            return m_serverController->setupContainer(installCredentials, i.key(), i.value());
+        }, pageFunc, progressBarFunc, noButton, waitInfoFunc, busyInfoFunc);
+
+        m_serverController->disconnectFromHost(installCredentials);
+    }
+
+    if (error == ErrorCode::NoError) {
         QJsonObject server;
         server.insert(config_key::hostName, installCredentials.hostName);
         server.insert(config_key::userName, installCredentials.userName);
@@ -367,182 +385,6 @@ void UiLogic::installServer(QMap<DockerContainer, QJsonObject> &containers)
     }
 }
 
-bool UiLogic::installContainers(ServerCredentials credentials,
-                                QMap<DockerContainer, QJsonObject> &containers,
-                                const PageFunc &page,
-                                const ProgressFunc &progress,
-                                const ButtonFunc &button,
-                                const LabelFunc &info)
-{
-    if (!progress.setValueFunc) return false;
-
-    if (page.setEnabledFunc) {
-        page.setEnabledFunc(false);
-    }
-    if (button.setVisibleFunc) {
-        button.setVisibleFunc(false);
-    }
-
-    if (info.setVisibleFunc) {
-        info.setVisibleFunc(true);
-    }
-    if (info.setTextFunc) {
-        info.setTextFunc(tr("Please wait, configuring process may take up to 5 minutes"));
-    }
-
-    int cnt = 0;
-    for (QMap<DockerContainer, QJsonObject>::iterator i = containers.begin(); i != containers.end(); i++, cnt++) {
-        QTimer timer;
-        connect(&timer, &QTimer::timeout, [progress](){
-            progress.setValueFunc(progress.getValueFunc() + 1);
-        });
-
-        progress.setValueFunc(0);
-        timer.start(1000);
-
-        progress.setTextVisibleFunc(true);
-        progress.setTextFunc(QString("Installing %1 %2 %3").arg(cnt+1).arg(tr("of")).arg(containers.size()));
-
-        ErrorCode e = m_serverController->setupContainer(credentials, i.key(), i.value());
-        qDebug() << "Setup server finished with code" << e;
-        m_serverController->disconnectFromHost(credentials);
-
-        if (e) {
-            if (page.setEnabledFunc) {
-                page.setEnabledFunc(true);
-            }
-            if (button.setVisibleFunc) {
-                button.setVisibleFunc(true);
-            }
-            if (info.setVisibleFunc) {
-                info.setVisibleFunc(false);
-            }
-
-            QMessageBox::warning(nullptr, APPLICATION_NAME,
-                                 tr("Error occurred while configuring server.") + "\n" +
-                                 errorString(e));
-
-            return false;
-        }
-
-        // just ui progressbar tweak
-        timer.stop();
-
-        int remaining_val = progress.getMaximiumFunc() - progress.getValueFunc();
-
-        if (remaining_val > 0) {
-            QTimer timer1;
-            QEventLoop loop1;
-
-            connect(&timer1, &QTimer::timeout, [&](){
-                progress.setValueFunc(progress.getValueFunc() + 1);
-                if (progress.getValueFunc() >= progress.getMaximiumFunc()) {
-                    loop1.quit();
-                }
-            });
-
-            timer1.start(5);
-            loop1.exec();
-        }
-    }
-
-
-    if (button.setVisibleFunc) {
-        button.setVisibleFunc(true);
-    }
-    if (page.setEnabledFunc) {
-        page.setEnabledFunc(true);
-    }
-    if (info.setTextFunc) {
-        info.setTextFunc(tr("Amnezia server installed"));
-    }
-
-    return true;
-}
-
-ErrorCode UiLogic::doInstallAction(const std::function<ErrorCode()> &action,
-                                   const PageFunc &page,
-                                   const ProgressFunc &progress,
-                                   const ButtonFunc &button,
-                                   const LabelFunc &info)
-{
-    progress.setVisibleFunc(true);
-    if (page.setEnabledFunc) {
-        page.setEnabledFunc(false);
-    }
-    if (button.setVisibleFunc) {
-        button.setVisibleFunc(false);
-    }
-    if (info.setVisibleFunc) {
-        info.setVisibleFunc(true);
-    }
-    if (info.setTextFunc) {
-        info.setTextFunc(tr("Please wait, configuring process may take up to 5 minutes"));
-    }
-
-    QTimer timer;
-    connect(&timer, &QTimer::timeout, [progress](){
-        progress.setValueFunc(progress.getValueFunc() + 1);
-    });
-
-    progress.setValueFunc(0);
-    timer.start(1000);
-
-    ErrorCode e = action();
-    qDebug() << "doInstallAction finished with code" << e;
-
-    if (e) {
-        if (page.setEnabledFunc) {
-            page.setEnabledFunc(true);
-        }
-        if (button.setVisibleFunc) {
-            button.setVisibleFunc(true);
-        }
-        if (info.setVisibleFunc) {
-            info.setVisibleFunc(false);
-        }
-        QMessageBox::warning(nullptr, APPLICATION_NAME,
-                             tr("Error occurred while configuring server.") + "\n" +
-                             errorString(e));
-
-        progress.setVisibleFunc(false);
-        return e;
-    }
-
-    // just ui progressbar tweak
-    timer.stop();
-
-    int remaining_val = progress.getMaximiumFunc() - progress.getValueFunc();
-
-    if (remaining_val > 0) {
-        QTimer timer1;
-        QEventLoop loop1;
-
-        connect(&timer1, &QTimer::timeout, [&](){
-            progress.setValueFunc(progress.getValueFunc() + 1);
-            if (progress.getValueFunc() >= progress.getMaximiumFunc()) {
-                loop1.quit();
-            }
-        });
-
-        timer1.start(5);
-        loop1.exec();
-    }
-
-
-    progress.setVisibleFunc(false);
-    if (button.setVisibleFunc) {
-        button.setVisibleFunc(true);
-    }
-    if (page.setEnabledFunc) {
-        page.setEnabledFunc(true);
-    }
-    if (info.setTextFunc) {
-        info.setTextFunc(tr("Operation finished"));
-    }
-    return ErrorCode::NoError;
-}
-
 PageProtocolLogicBase *UiLogic::protocolLogic(Proto p)
 {
     PageProtocolLogicBase *logic = m_protocolLogicMap.value(p);

client/ui/uilogic.h

@@ -136,38 +136,6 @@ private slots:
 
 private:
     PageEnumNS::Page currentPage();
-    struct ProgressFunc {
-        std::function<void(bool)> setVisibleFunc;
-        std::function<void(int)> setValueFunc;
-        std::function<int(void)> getValueFunc;
-        std::function<int(void)> getMaximiumFunc;
-        std::function<void(bool)> setTextVisibleFunc;
-        std::function<void(const QString&)> setTextFunc;
-    };
-    struct PageFunc {
-        std::function<void(bool)> setEnabledFunc;
-    };
-    struct ButtonFunc {
-        std::function<void(bool)> setVisibleFunc;
-    };
-    struct LabelFunc {
-        std::function<void(bool)> setVisibleFunc;
-        std::function<void(const QString&)> setTextFunc;
-    };
-
-    bool installContainers(ServerCredentials credentials,
-                           QMap<DockerContainer, QJsonObject> &containers,
-                           const PageFunc& page,
-                           const ProgressFunc& progress,
-                           const ButtonFunc& button,
-                           const LabelFunc& info);
-
-    ErrorCode doInstallAction(const std::function<ErrorCode()> &action,
-                              const PageFunc& page,
-                              const ProgressFunc& progress,
-                              const ButtonFunc& button,
-                              const LabelFunc& info);
-
 
 public:
     Q_INVOKABLE PageProtocolLogicBase *protocolLogic(Proto p);