From 3e47a41985c2bd8e4eb7abc5dea01e0637804a4b Mon Sep 17 00:00:00 2001
From: aiamnezia <ai@amnezia.org>
Date: Tue, 8 Apr 2025 17:31:20 +0400
Subject: [PATCH] Fix bug with Amnezia DNS in split tunneling list

---
 client/vpnconnection.cpp | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/client/vpnconnection.cpp b/client/vpnconnection.cpp
index 60e61ee4..ff875b39 100644
--- a/client/vpnconnection.cpp
+++ b/client/vpnconnection.cpp
@@ -351,18 +351,16 @@ void VpnConnection::appendSplitTunnelingConfig()
                 sitesJsonArray.append(site);
             }
 
-            // Allow traffic to Amnezia DNS
-            if (sitesRouteMode == Settings::VpnOnlyForwardSites) {
+            if (sitesJsonArray.isEmpty()) {
+                sitesRouteMode = Settings::RouteMode::VpnAllSites;
+            } else if (sitesRouteMode == Settings::VpnOnlyForwardSites) {
+                // Allow traffic to Amnezia DNS
                 sitesJsonArray.append(m_vpnConfiguration.value(config_key::dns1).toString());
                 sitesJsonArray.append(m_vpnConfiguration.value(config_key::dns2).toString());
             }
         }
     }
 
-    if (sitesJsonArray.isEmpty()) {
-        sitesRouteMode = Settings::RouteMode::VpnAllSites;
-    }
-
     m_vpnConfiguration.insert(config_key::splitTunnelType, sitesRouteMode);
     m_vpnConfiguration.insert(config_key::splitTunnelSites, sitesJsonArray);
 
@@ -375,10 +373,10 @@ void VpnConnection::appendSplitTunnelingConfig()
         for (const auto &app : apps) {
             appsJsonArray.append(app.appPath.isEmpty() ? app.packageName : app.appPath);
         }
-    }
 
-    if (appsJsonArray.isEmpty()) {
-        appsRouteMode = Settings::AppsRouteMode::VpnAllApps;
+        if (appsJsonArray.isEmpty()) {
+            appsRouteMode = Settings::AppsRouteMode::VpnAllApps;
+        }
     }
 
     m_vpnConfiguration.insert(config_key::appSplitTunnelType, appsRouteMode);