From 4910dcfa96a60093397aafa53204fe9b90c47bea Mon Sep 17 00:00:00 2001 From: albexk Date: Wed, 2 Oct 2024 15:18:05 +0300 Subject: [PATCH] Set the maximum version of Androids to 7.1 (API 25) --- .github/workflows/deploy.yml | 2 +- client/android/AndroidManifest.xml | 6 +++ .../vpn/protocol/openvpn/OpenVpnClient.kt | 8 ---- .../protocolApi/src/main/kotlin/Protocol.kt | 16 +------ .../src/main/kotlin/ProtocolConfig.kt | 2 +- client/android/qt/build.gradle.kts | 2 +- .../src/org/amnezia/vpn/AmneziaActivity.kt | 28 +------------ .../src/org/amnezia/vpn/AmneziaTileService.kt | 42 ++----------------- .../src/org/amnezia/vpn/AmneziaVpnService.kt | 36 +--------------- .../org/amnezia/vpn/ServiceNotification.kt | 29 ++----------- .../src/org/amnezia/vpn/VpnRequestActivity.kt | 10 ++--- client/android/utils/src/main/kotlin/Log.kt | 17 ++------ .../utils/src/main/kotlin/net/NetworkState.kt | 37 ++-------------- .../utils/src/main/kotlin/net/TrafficStats.kt | 17 +++----- 14 files changed, 35 insertions(+), 217 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index f9fb19a5..f3ac2ff1 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -301,7 +301,7 @@ jobs: env: ANDROID_BUILD_PLATFORM: android-34 - QT_VERSION: 6.7.3 + QT_VERSION: 6.6.3 QT_MODULES: 'qtremoteobjects qt5compat qtimageformats qtshadertools' PROD_AGW_PUBLIC_KEY: ${{ secrets.PROD_AGW_PUBLIC_KEY }} DEV_AGW_PUBLIC_KEY: ${{ secrets.DEV_AGW_PUBLIC_KEY }} diff --git a/client/android/AndroidManifest.xml b/client/android/AndroidManifest.xml index 179def86..6d77f13c 100644 --- a/client/android/AndroidManifest.xml +++ b/client/android/AndroidManifest.xml @@ -3,10 +3,13 @@ + + @@ -67,6 +70,9 @@ android:name="android.app.lib_name" android:value="-- %%INSERT_APP_LIB_NAME%% --" /> + = Build.VERSION_CODES.Q) { - try { - configBuilder.setHttpProxy(ProxyInfo.buildDirectProxy(host, port)) - } catch (e: Exception) { - Log.e(TAG, "Could not set proxy: ${e.message}") - return false - } - } return true } diff --git a/client/android/protocolApi/src/main/kotlin/Protocol.kt b/client/android/protocolApi/src/main/kotlin/Protocol.kt index b5c382be..76900bf0 100644 --- a/client/android/protocolApi/src/main/kotlin/Protocol.kt +++ b/client/android/protocolApi/src/main/kotlin/Protocol.kt @@ -117,12 +117,7 @@ abstract class Protocol { Log.d(TAG, "addRoute: $inetNetwork") vpnBuilder.addRoute(inetNetwork) } else { - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) { - Log.d(TAG, "excludeRoute: $inetNetwork") - vpnBuilder.excludeRoute(inetNetwork) - } else { - Log.e(TAG, "Trying to exclude route $inetNetwork on old Android") - } + Log.e(TAG, "Trying to exclude route $inetNetwork on old Android") } } @@ -139,13 +134,6 @@ abstract class Protocol { Log.d(TAG, "setMtu: ${config.mtu}") vpnBuilder.setMtu(config.mtu) - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) { - config.httpProxy?.let { - Log.d(TAG, "setHttpProxy: $it") - vpnBuilder.setHttpProxy(it) - } - } - if (config.allowAllAF) { Log.d(TAG, "allowFamily") vpnBuilder.allowFamily(OsConstants.AF_INET) @@ -155,8 +143,6 @@ abstract class Protocol { Log.d(TAG, "setBlocking: ${config.blockingMode}") vpnBuilder.setBlocking(config.blockingMode) vpnBuilder.setUnderlyingNetworks(null) - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) - vpnBuilder.setMetered(false) } } diff --git a/client/android/protocolApi/src/main/kotlin/ProtocolConfig.kt b/client/android/protocolApi/src/main/kotlin/ProtocolConfig.kt index bebcea4c..3310c300 100644 --- a/client/android/protocolApi/src/main/kotlin/ProtocolConfig.kt +++ b/client/android/protocolApi/src/main/kotlin/ProtocolConfig.kt @@ -145,7 +145,7 @@ open class ProtocolConfig protected constructor( } // for older versions of Android, build a list of subnets without excluded routes // and add them to routes - if (Build.VERSION.SDK_INT < Build.VERSION_CODES.TIRAMISU && routes.any { !it.include }) { + if (routes.any { !it.include }) { val ipRangeSet = IpRangeSet() routes.forEach { if (it.include) ipRangeSet.add(IpRange(it.inetNetwork)) diff --git a/client/android/qt/build.gradle.kts b/client/android/qt/build.gradle.kts index 6b1d3fd1..139adf4f 100644 --- a/client/android/qt/build.gradle.kts +++ b/client/android/qt/build.gradle.kts @@ -21,5 +21,5 @@ android { } dependencies { - api(fileTree(mapOf("dir" to "../libs", "include" to listOf("*.jar")))) + implementation(fileTree(mapOf("dir" to "../libs", "include" to listOf("*.jar")))) } diff --git a/client/android/src/org/amnezia/vpn/AmneziaActivity.kt b/client/android/src/org/amnezia/vpn/AmneziaActivity.kt index d5026425..93bbf37e 100644 --- a/client/android/src/org/amnezia/vpn/AmneziaActivity.kt +++ b/client/android/src/org/amnezia/vpn/AmneziaActivity.kt @@ -3,8 +3,6 @@ package org.amnezia.vpn import android.Manifest import android.annotation.SuppressLint import android.app.AlertDialog -import android.app.NotificationManager -import android.content.BroadcastReceiver import android.content.ComponentName import android.content.Intent import android.content.Intent.EXTRA_MIME_TYPES @@ -68,7 +66,6 @@ class AmneziaActivity : QtActivity() { private var isWaitingStatus = true private var isServiceConnected = false private var isInBoundState = false - private var notificationStateReceiver: BroadcastReceiver? = null private lateinit var vpnServiceMessenger: IpcMessenger private val actionResultHandlers = mutableMapOf() @@ -176,7 +173,6 @@ class AmneziaActivity : QtActivity() { doBindService() } ) - registerBroadcastReceivers() intent?.let(::processIntent) runBlocking { vpnProto = proto.await() } } @@ -192,26 +188,6 @@ class AmneziaActivity : QtActivity() { } } - private fun registerBroadcastReceivers() { - notificationStateReceiver = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) { - registerBroadcastReceiver( - arrayOf( - NotificationManager.ACTION_NOTIFICATION_CHANNEL_BLOCK_STATE_CHANGED, - NotificationManager.ACTION_APP_BLOCK_STATE_CHANGED - ) - ) { - Log.d( - TAG, "Notification state changed: ${it?.action}, blocked = " + - "${it?.getBooleanExtra(NotificationManager.EXTRA_BLOCKED_STATE, false)}" - ) - mainScope.launch { - qtInitialized.await() - QtAndroidController.onNotificationStateChanged() - } - } - } else null - } - override fun onNewIntent(intent: Intent?) { super.onNewIntent(intent) Log.d(TAG, "onNewIntent: $intent") @@ -257,8 +233,6 @@ class AmneziaActivity : QtActivity() { override fun onDestroy() { Log.d(TAG, "Destroy Amnezia activity") - unregisterBroadcastReceiver(notificationStateReceiver) - notificationStateReceiver = null mainScope.cancel() super.onDestroy() } @@ -664,7 +638,7 @@ class AmneziaActivity : QtActivity() { } @Suppress("unused") - fun isNotificationPermissionGranted(): Boolean = applicationContext.isNotificationPermissionGranted() + fun isNotificationPermissionGranted(): Boolean = true @Suppress("unused") fun requestNotificationPermission() { diff --git a/client/android/src/org/amnezia/vpn/AmneziaTileService.kt b/client/android/src/org/amnezia/vpn/AmneziaTileService.kt index 32d5710d..117755e2 100644 --- a/client/android/src/org/amnezia/vpn/AmneziaTileService.kt +++ b/client/android/src/org/amnezia/vpn/AmneziaTileService.kt @@ -1,12 +1,9 @@ package org.amnezia.vpn -import android.annotation.SuppressLint -import android.app.PendingIntent import android.content.ComponentName import android.content.Intent import android.content.ServiceConnection import android.net.VpnService -import android.os.Build import android.os.IBinder import android.os.Messenger import android.service.quicksettings.Tile @@ -148,7 +145,8 @@ class AmneziaTileService : TileService() { Intent(this, AmneziaActivity::class.java).apply { addFlags(Intent.FLAG_ACTIVITY_NEW_TASK) }.also { - startActivityAndCollapseCompat(it) + @Suppress("DEPRECATION") + startActivityAndCollapse(it) } } } @@ -192,7 +190,8 @@ class AmneziaTileService : TileService() { addFlags(Intent.FLAG_ACTIVITY_NEW_TASK) putExtra(EXTRA_PROTOCOL, vpnProto) }.also { - startActivityAndCollapseCompat(it) + @Suppress("DEPRECATION") + startActivityAndCollapse(it) } false } else { @@ -216,23 +215,6 @@ class AmneziaTileService : TileService() { private fun stopVpn() = vpnServiceMessenger.send(Action.DISCONNECT) - @SuppressLint("StartActivityAndCollapseDeprecated") - private fun startActivityAndCollapseCompat(intent: Intent) { - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) { - startActivityAndCollapse( - PendingIntent.getActivity( - applicationContext, - 0, - intent, - PendingIntent.FLAG_IMMUTABLE - ) - ) - } else { - @Suppress("DEPRECATION") - startActivityAndCollapse(intent) - } - } - private fun updateVpnState(state: ProtocolState) = scope.launch { VpnStateStore.store { it.copy(protocolState = state) } } @@ -249,17 +231,14 @@ class AmneziaTileService : TileService() { when (val protocolState = vpnState.protocolState) { CONNECTED -> { state = Tile.STATE_ACTIVE - subtitleCompat = null } DISCONNECTED, UNKNOWN -> { state = Tile.STATE_INACTIVE - subtitleCompat = null } CONNECTING, DISCONNECTING, RECONNECTING -> { state = Tile.STATE_UNAVAILABLE - subtitleCompat = getString(protocolState) } } updateTile() @@ -267,17 +246,4 @@ class AmneziaTileService : TileService() { // double update to fix weird visual glitches tile.updateTile() } - - private var Tile.subtitleCompat: CharSequence? - set(value) { - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) { - this.subtitle = value - } - } - get() { - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) { - return this.subtitle - } - return null - } } diff --git a/client/android/src/org/amnezia/vpn/AmneziaVpnService.kt b/client/android/src/org/amnezia/vpn/AmneziaVpnService.kt index 937127ee..4ce51130 100644 --- a/client/android/src/org/amnezia/vpn/AmneziaVpnService.kt +++ b/client/android/src/org/amnezia/vpn/AmneziaVpnService.kt @@ -3,14 +3,10 @@ package org.amnezia.vpn import android.annotation.SuppressLint import android.app.ActivityManager import android.app.ActivityManager.RunningAppProcessInfo.IMPORTANCE_FOREGROUND_SERVICE -import android.app.NotificationManager import android.content.BroadcastReceiver import android.content.Context import android.content.Intent -import android.content.pm.ServiceInfo.FOREGROUND_SERVICE_TYPE_MANIFEST -import android.content.pm.ServiceInfo.FOREGROUND_SERVICE_TYPE_SYSTEM_EXEMPTED import android.net.VpnService -import android.os.Build import android.os.Handler import android.os.IBinder import android.os.Looper @@ -104,7 +100,6 @@ open class AmneziaVpnService : VpnService() { private lateinit var networkState: NetworkState private lateinit var trafficStats: TrafficStats private var controlReceiver: BroadcastReceiver? = null - private var notificationStateReceiver: BroadcastReceiver? = null private var screenOnReceiver: BroadcastReceiver? = null private var screenOffReceiver: BroadcastReceiver? = null private val clientMessengers = ConcurrentHashMap() @@ -189,16 +184,6 @@ open class AmneziaVpnService : VpnService() { Messenger(actionMessageHandler) } - /** - * Notification setup - */ - private val foregroundServiceTypeCompat - get() = when { - Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE -> FOREGROUND_SERVICE_TYPE_SYSTEM_EXEMPTED - Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q -> FOREGROUND_SERVICE_TYPE_MANIFEST - else -> 0 - } - private val serviceNotification: ServiceNotification by lazy(NONE) { ServiceNotification(this) } /** @@ -232,7 +217,7 @@ open class AmneziaVpnService : VpnService() { ServiceCompat.startForeground( this, NOTIFICATION_ID, serviceNotification.buildNotification(serverName, vpnProto?.label, protocolState.value), - foregroundServiceTypeCompat + 0 ) return START_REDELIVER_INTENT } @@ -309,23 +294,6 @@ open class AmneziaVpnService : VpnService() { } } - notificationStateReceiver = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) { - registerBroadcastReceiver( - arrayOf( - NotificationManager.ACTION_NOTIFICATION_CHANNEL_BLOCK_STATE_CHANGED, - NotificationManager.ACTION_APP_BLOCK_STATE_CHANGED - ) - ) { - val state = it?.getBooleanExtra(NotificationManager.EXTRA_BLOCKED_STATE, false) - Log.d(TAG, "Notification state changed: ${it?.action}, blocked = $state") - if (state == false) { - enableNotification() - } else { - disableNotification() - } - } - } else null - registerScreenStateBroadcastReceivers() } @@ -353,10 +321,8 @@ open class AmneziaVpnService : VpnService() { private fun unregisterBroadcastReceivers() { Log.d(TAG, "Unregister broadcast receivers") unregisterBroadcastReceiver(controlReceiver) - unregisterBroadcastReceiver(notificationStateReceiver) unregisterScreenStateBroadcastReceivers() controlReceiver = null - notificationStateReceiver = null } /** diff --git a/client/android/src/org/amnezia/vpn/ServiceNotification.kt b/client/android/src/org/amnezia/vpn/ServiceNotification.kt index f4707731..a991eafc 100644 --- a/client/android/src/org/amnezia/vpn/ServiceNotification.kt +++ b/client/android/src/org/amnezia/vpn/ServiceNotification.kt @@ -1,19 +1,15 @@ package org.amnezia.vpn -import android.Manifest.permission import android.annotation.SuppressLint import android.app.Notification -import android.app.NotificationManager import android.app.PendingIntent import android.content.Context import android.content.Intent -import android.content.pm.PackageManager import android.os.Build import androidx.core.app.NotificationChannelCompat.Builder import androidx.core.app.NotificationCompat import androidx.core.app.NotificationCompat.Action import androidx.core.app.NotificationManagerCompat -import androidx.core.content.ContextCompat import org.amnezia.vpn.protocol.ProtocolState import org.amnezia.vpn.protocol.ProtocolState.CONNECTED import org.amnezia.vpn.protocol.ProtocolState.DISCONNECTED @@ -85,29 +81,17 @@ class ServiceNotification(private val context: Context) { .setSubText(getSpeedString(speed)) .build() - fun isNotificationEnabled(): Boolean { - if (!context.isNotificationPermissionGranted()) return false - if (!notificationManager.areNotificationsEnabled()) return false - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { - return notificationManager.getNotificationChannel(NOTIFICATION_CHANNEL_ID) - ?.let { it.importance != NotificationManager.IMPORTANCE_NONE } ?: true - } - return true - } + fun isNotificationEnabled(): Boolean = notificationManager.areNotificationsEnabled() @SuppressLint("MissingPermission") fun updateNotification(serverName: String?, protocol: String?, state: ProtocolState) { - if (context.isNotificationPermissionGranted()) { - Log.d(TAG, "Update notification: $serverName, $state") - notificationManager.notify(NOTIFICATION_ID, buildNotification(serverName, protocol, state)) - } + Log.d(TAG, "Update notification: $serverName, $state") + notificationManager.notify(NOTIFICATION_ID, buildNotification(serverName, protocol, state)) } @SuppressLint("MissingPermission") fun updateSpeed(speed: TrafficData) { - if (context.isNotificationPermissionGranted()) { - notificationManager.notify(NOTIFICATION_ID, buildNotification(speed)) - } + notificationManager.notify(NOTIFICATION_ID, buildNotification(speed)) } private fun getSpeedString(traffic: TrafficData) = @@ -168,8 +152,3 @@ class ServiceNotification(private val context: Context) { } } } - -fun Context.isNotificationPermissionGranted(): Boolean = - Build.VERSION.SDK_INT < Build.VERSION_CODES.TIRAMISU || - ContextCompat.checkSelfPermission(this, permission.POST_NOTIFICATIONS) == - PackageManager.PERMISSION_GRANTED diff --git a/client/android/src/org/amnezia/vpn/VpnRequestActivity.kt b/client/android/src/org/amnezia/vpn/VpnRequestActivity.kt index c24f5a19..56bcbdea 100644 --- a/client/android/src/org/amnezia/vpn/VpnRequestActivity.kt +++ b/client/android/src/org/amnezia/vpn/VpnRequestActivity.kt @@ -7,7 +7,6 @@ import android.content.Intent import android.content.res.Configuration.UI_MODE_NIGHT_MASK import android.content.res.Configuration.UI_MODE_NIGHT_YES import android.net.VpnService -import android.os.Build import android.os.Bundle import android.provider.Settings import android.widget.Toast @@ -31,12 +30,9 @@ class VpnRequestActivity : ComponentActivity() { override fun onCreate(savedInstanceState: Bundle?) { super.onCreate(savedInstanceState) Log.d(TAG, "Start request activity") - vpnProto = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) { - intent.extras?.getSerializable(EXTRA_PROTOCOL, VpnProto::class.java) - } else { - @Suppress("DEPRECATION") - intent.extras?.getSerializable(EXTRA_PROTOCOL) as VpnProto - } + @Suppress("DEPRECATION") + vpnProto = intent.extras?.getSerializable(EXTRA_PROTOCOL) as VpnProto + val requestIntent = VpnService.prepare(applicationContext) if (requestIntent != null) { if (getSystemService()!!.isKeyguardLocked) { diff --git a/client/android/utils/src/main/kotlin/Log.kt b/client/android/utils/src/main/kotlin/Log.kt index a656b9ea..42832b0d 100644 --- a/client/android/utils/src/main/kotlin/Log.kt +++ b/client/android/utils/src/main/kotlin/Log.kt @@ -10,8 +10,6 @@ import java.io.IOException import java.io.RandomAccessFile import java.nio.channels.FileChannel import java.nio.channels.FileLock -import java.time.LocalDateTime -import java.time.format.DateTimeFormatter import java.util.Date import java.util.Locale import java.util.concurrent.locks.ReentrantLock @@ -41,11 +39,9 @@ private const val LOG_MAX_FILE_SIZE = 1024 * 1024 * | | | create a report and/or terminate the process | */ object Log { - private val dateTimeFormat: Any = - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) DateTimeFormatter.ofPattern(DATE_TIME_PATTERN) - else object : ThreadLocal() { - override fun initialValue(): DateFormat = SimpleDateFormat(DATE_TIME_PATTERN, Locale.US) - } + private val dateTimeFormat = object : ThreadLocal() { + override fun initialValue(): DateFormat = SimpleDateFormat(DATE_TIME_PATTERN, Locale.US) + } private lateinit var logDir: File private val logFile: File by lazy { File(logDir, LOG_FILE_NAME) } @@ -143,12 +139,7 @@ object Log { } private fun formatLogMsg(tag: String, msg: String, priority: Priority): String { - val date = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { - LocalDateTime.now().format(dateTimeFormat as DateTimeFormatter) - } else { - @Suppress("UNCHECKED_CAST") - (dateTimeFormat as ThreadLocal).get()?.format(Date()) - } + val date = dateTimeFormat.get()?.format(Date()) return "$date ${Process.myPid()} ${Process.myTid()} $priority [${Thread.currentThread().name}] " + "$tag: $msg\n" } diff --git a/client/android/utils/src/main/kotlin/net/NetworkState.kt b/client/android/utils/src/main/kotlin/net/NetworkState.kt index b71bf393..90988f38 100644 --- a/client/android/utils/src/main/kotlin/net/NetworkState.kt +++ b/client/android/utils/src/main/kotlin/net/NetworkState.kt @@ -8,11 +8,9 @@ import android.net.NetworkCapabilities import android.net.NetworkCapabilities.NET_CAPABILITY_INTERNET import android.net.NetworkCapabilities.NET_CAPABILITY_VALIDATED import android.net.NetworkRequest -import android.os.Build import android.os.Handler import androidx.core.content.getSystemService import kotlin.LazyThreadSafetyMode.NONE -import kotlinx.coroutines.delay import org.amnezia.vpn.util.Log private const val TAG = "NetworkState" @@ -47,12 +45,8 @@ class NetworkState( override fun onCapabilitiesChanged(network: Network, networkCapabilities: NetworkCapabilities) { Log.d(TAG, "onCapabilitiesChanged: $network, $networkCapabilities") - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { + handler.post { checkNetworkState(network, networkCapabilities) - } else { - handler.post { - checkNetworkState(network, networkCapabilities) - } } } @@ -82,35 +76,10 @@ class NetworkState( } } - suspend fun bindNetworkListener() { + fun bindNetworkListener() { if (isListenerBound) return Log.d(TAG, "Bind network listener") - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) { - connectivityManager.registerBestMatchingNetworkCallback(networkRequest, networkCallback, handler) - } else if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { - val numberAttempts = 300 - var attemptCount = 0 - while(true) { - try { - connectivityManager.requestNetwork(networkRequest, networkCallback, handler) - break - } catch (e: SecurityException) { - Log.e(TAG, "Failed to bind network listener: $e") - // Android 11 bug: https://issuetracker.google.com/issues/175055271 - if (e.message?.startsWith("Package android does not belong to") == true) { - if (++attemptCount > numberAttempts) { - throw e - } - delay(1000) - continue - } else { - throw e - } - } - } - } else { - connectivityManager.requestNetwork(networkRequest, networkCallback) - } + connectivityManager.requestNetwork(networkRequest, networkCallback) isListenerBound = true } diff --git a/client/android/utils/src/main/kotlin/net/TrafficStats.kt b/client/android/utils/src/main/kotlin/net/TrafficStats.kt index 170d164e..f5a44bec 100644 --- a/client/android/utils/src/main/kotlin/net/TrafficStats.kt +++ b/client/android/utils/src/main/kotlin/net/TrafficStats.kt @@ -1,7 +1,6 @@ package org.amnezia.vpn.util.net import android.net.TrafficStats -import android.os.Build import android.os.Process import android.os.SystemClock import kotlin.math.roundToLong @@ -17,18 +16,12 @@ class TrafficStats { private var lastTrafficData = TrafficData.ZERO private var lastTimestamp = 0L - private val getTrafficDataCompat: () -> TrafficData = - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) { - val iface = "tun0" - fun(): TrafficData { - return TrafficData(TrafficStats.getRxBytes(iface), TrafficStats.getTxBytes(iface)) - } - } else { - val uid = Process.myUid() - fun(): TrafficData { - return TrafficData(TrafficStats.getUidRxBytes(uid), TrafficStats.getUidTxBytes(uid)) - } + private val getTrafficDataCompat: () -> TrafficData = run { + val uid = Process.myUid() + fun(): TrafficData { + return TrafficData(TrafficStats.getUidRxBytes(uid), TrafficStats.getUidTxBytes(uid)) } + } fun reset() { lastTrafficData = getTrafficDataCompat()