diff --git a/client/configurators/awg_configurator.cpp b/client/configurators/awg_configurator.cpp index d0a1034e..21b61ba4 100644 --- a/client/configurators/awg_configurator.cpp +++ b/client/configurators/awg_configurator.cpp @@ -9,7 +9,7 @@ AwgConfigurator::AwgConfigurator(std::shared_ptr settings, const QShar } QString AwgConfigurator::createConfig(const ServerCredentials &credentials, DockerContainer container, const QJsonObject &containerConfig, - ErrorCode errorCode) + ErrorCode &errorCode) { QString config = WireguardConfigurator::createConfig(credentials, container, containerConfig, errorCode); diff --git a/client/configurators/awg_configurator.h b/client/configurators/awg_configurator.h index 0a64bbb1..301b927c 100644 --- a/client/configurators/awg_configurator.h +++ b/client/configurators/awg_configurator.h @@ -12,7 +12,7 @@ public: AwgConfigurator(std::shared_ptr settings, const QSharedPointer &serverController, QObject *parent = nullptr); QString createConfig(const ServerCredentials &credentials, DockerContainer container, - const QJsonObject &containerConfig, ErrorCode errorCode); + const QJsonObject &containerConfig, ErrorCode &errorCode); }; #endif // AWGCONFIGURATOR_H diff --git a/client/configurators/cloak_configurator.cpp b/client/configurators/cloak_configurator.cpp index d876e7b8..fd0c0391 100644 --- a/client/configurators/cloak_configurator.cpp +++ b/client/configurators/cloak_configurator.cpp @@ -13,7 +13,7 @@ CloakConfigurator::CloakConfigurator(std::shared_ptr settings, const Q } QString CloakConfigurator::createConfig(const ServerCredentials &credentials, DockerContainer container, const QJsonObject &containerConfig, - ErrorCode errorCode) + ErrorCode &errorCode) { QString cloakPublicKey = m_serverController->getTextFileFromContainer(container, credentials, amnezia::protocols::cloak::ckPublicKeyPath, errorCode); diff --git a/client/configurators/cloak_configurator.h b/client/configurators/cloak_configurator.h index 6c2523fb..d117a821 100644 --- a/client/configurators/cloak_configurator.h +++ b/client/configurators/cloak_configurator.h @@ -14,7 +14,7 @@ public: CloakConfigurator(std::shared_ptr settings, const QSharedPointer &serverController, QObject *parent = nullptr); QString createConfig(const ServerCredentials &credentials, DockerContainer container, - const QJsonObject &containerConfig, ErrorCode errorCode); + const QJsonObject &containerConfig, ErrorCode &errorCode); }; #endif // CLOAK_CONFIGURATOR_H diff --git a/client/configurators/configurator_base.h b/client/configurators/configurator_base.h index f63892eb..2427b604 100644 --- a/client/configurators/configurator_base.h +++ b/client/configurators/configurator_base.h @@ -15,7 +15,7 @@ public: explicit ConfiguratorBase(std::shared_ptr settings, const QSharedPointer &serverController, QObject *parent = nullptr); virtual QString createConfig(const ServerCredentials &credentials, DockerContainer container, - const QJsonObject &containerConfig, ErrorCode errorCode) = 0; + const QJsonObject &containerConfig, ErrorCode &errorCode) = 0; virtual QString processConfigWithLocalSettings(const QPair &dns, const bool isApiConfig, QString &protocolConfigString); diff --git a/client/configurators/ikev2_configurator.cpp b/client/configurators/ikev2_configurator.cpp index bf1a8ad4..894a0e3d 100644 --- a/client/configurators/ikev2_configurator.cpp +++ b/client/configurators/ikev2_configurator.cpp @@ -20,7 +20,7 @@ Ikev2Configurator::Ikev2Configurator(std::shared_ptr settings, const Q } Ikev2Configurator::ConnectionData Ikev2Configurator::prepareIkev2Config(const ServerCredentials &credentials, DockerContainer container, - ErrorCode errorCode) + ErrorCode &errorCode) { Ikev2Configurator::ConnectionData connData; connData.host = credentials.hostName; @@ -55,7 +55,7 @@ Ikev2Configurator::ConnectionData Ikev2Configurator::prepareIkev2Config(const Se } QString Ikev2Configurator::createConfig(const ServerCredentials &credentials, DockerContainer container, const QJsonObject &containerConfig, - ErrorCode errorCode) + ErrorCode &errorCode) { Q_UNUSED(containerConfig) diff --git a/client/configurators/ikev2_configurator.h b/client/configurators/ikev2_configurator.h index 322028c1..e3a85216 100644 --- a/client/configurators/ikev2_configurator.h +++ b/client/configurators/ikev2_configurator.h @@ -22,14 +22,14 @@ public: }; QString createConfig(const ServerCredentials &credentials, DockerContainer container, - const QJsonObject &containerConfig, ErrorCode errorCode); + const QJsonObject &containerConfig, ErrorCode &errorCode); QString genIkev2Config(const ConnectionData &connData); QString genMobileConfig(const ConnectionData &connData); QString genStrongSwanConfig(const ConnectionData &connData); ConnectionData prepareIkev2Config(const ServerCredentials &credentials, - DockerContainer container, ErrorCode errorCode); + DockerContainer container, ErrorCode &errorCode); }; #endif // IKEV2_CONFIGURATOR_H diff --git a/client/configurators/openvpn_configurator.cpp b/client/configurators/openvpn_configurator.cpp index 03adaa49..c4bdf860 100644 --- a/client/configurators/openvpn_configurator.cpp +++ b/client/configurators/openvpn_configurator.cpp @@ -31,7 +31,7 @@ OpenVpnConfigurator::OpenVpnConfigurator(std::shared_ptr settings, con } OpenVpnConfigurator::ConnectionData OpenVpnConfigurator::prepareOpenVpnConfig(const ServerCredentials &credentials, - DockerContainer container, ErrorCode errorCode) + DockerContainer container, ErrorCode &errorCode) { OpenVpnConfigurator::ConnectionData connData = OpenVpnConfigurator::createCertRequest(); connData.host = credentials.hostName; @@ -72,7 +72,7 @@ OpenVpnConfigurator::ConnectionData OpenVpnConfigurator::prepareOpenVpnConfig(co } QString OpenVpnConfigurator::createConfig(const ServerCredentials &credentials, DockerContainer container, - const QJsonObject &containerConfig, ErrorCode errorCode) + const QJsonObject &containerConfig, ErrorCode &errorCode) { QString config = m_serverController->replaceVars(amnezia::scriptData(ProtocolScriptType::openvpn_template, container), m_serverController->genVarsForScript(credentials, container, containerConfig)); diff --git a/client/configurators/openvpn_configurator.h b/client/configurators/openvpn_configurator.h index f98831db..48e3f4be 100644 --- a/client/configurators/openvpn_configurator.h +++ b/client/configurators/openvpn_configurator.h @@ -25,7 +25,7 @@ public: }; QString createConfig(const ServerCredentials &credentials, DockerContainer container, - const QJsonObject &containerConfig, ErrorCode errorCode); + const QJsonObject &containerConfig, ErrorCode &errorCode); QString processConfigWithLocalSettings(const QPair &dns, const bool isApiConfig, QString &protocolConfigString); @@ -36,7 +36,7 @@ public: private: ConnectionData prepareOpenVpnConfig(const ServerCredentials &credentials, DockerContainer container, - ErrorCode errorCode); + ErrorCode &errorCode); ErrorCode signCert(DockerContainer container, const ServerCredentials &credentials, QString clientId); }; diff --git a/client/configurators/shadowsocks_configurator.cpp b/client/configurators/shadowsocks_configurator.cpp index 9cd1ee5b..fd6c4841 100644 --- a/client/configurators/shadowsocks_configurator.cpp +++ b/client/configurators/shadowsocks_configurator.cpp @@ -14,7 +14,7 @@ ShadowSocksConfigurator::ShadowSocksConfigurator(std::shared_ptr setti } QString ShadowSocksConfigurator::createConfig(const ServerCredentials &credentials, DockerContainer container, - const QJsonObject &containerConfig, ErrorCode errorCode) + const QJsonObject &containerConfig, ErrorCode &errorCode) { QString ssKey = m_serverController->getTextFileFromContainer(container, credentials, amnezia::protocols::shadowsocks::ssKeyPath, errorCode); diff --git a/client/configurators/shadowsocks_configurator.h b/client/configurators/shadowsocks_configurator.h index 1e8d997b..b21b3be3 100644 --- a/client/configurators/shadowsocks_configurator.h +++ b/client/configurators/shadowsocks_configurator.h @@ -13,7 +13,7 @@ public: ShadowSocksConfigurator(std::shared_ptr settings, const QSharedPointer &serverController, QObject *parent = nullptr); QString createConfig(const ServerCredentials &credentials, DockerContainer container, - const QJsonObject &containerConfig, ErrorCode errorCode); + const QJsonObject &containerConfig, ErrorCode &errorCode); }; #endif // SHADOWSOCKS_CONFIGURATOR_H diff --git a/client/configurators/wireguard_configurator.cpp b/client/configurators/wireguard_configurator.cpp index f3ea9ea3..f7faaa52 100644 --- a/client/configurators/wireguard_configurator.cpp +++ b/client/configurators/wireguard_configurator.cpp @@ -65,7 +65,7 @@ WireguardConfigurator::ConnectionData WireguardConfigurator::genClientKeys() WireguardConfigurator::ConnectionData WireguardConfigurator::prepareWireguardConfig(const ServerCredentials &credentials, DockerContainer container, - const QJsonObject &containerConfig, ErrorCode errorCode) + const QJsonObject &containerConfig, ErrorCode &errorCode) { WireguardConfigurator::ConnectionData connData = WireguardConfigurator::genClientKeys(); connData.host = credentials.hostName; @@ -158,7 +158,7 @@ WireguardConfigurator::ConnectionData WireguardConfigurator::prepareWireguardCon } QString WireguardConfigurator::createConfig(const ServerCredentials &credentials, DockerContainer container, - const QJsonObject &containerConfig, ErrorCode errorCode) + const QJsonObject &containerConfig, ErrorCode &errorCode) { QString scriptData = amnezia::scriptData(m_configTemplate, container); QString config = diff --git a/client/configurators/wireguard_configurator.h b/client/configurators/wireguard_configurator.h index 5a3a8d1f..22e8a8be 100644 --- a/client/configurators/wireguard_configurator.h +++ b/client/configurators/wireguard_configurator.h @@ -27,7 +27,7 @@ public: }; QString createConfig(const ServerCredentials &credentials, DockerContainer container, const QJsonObject &containerConfig, - ErrorCode errorCode); + ErrorCode &errorCode); QString processConfigWithLocalSettings(const QPair &dns, const bool isApiConfig, QString &protocolConfigString); QString processConfigWithExportSettings(const QPair &dns, const bool isApiConfig, QString &protocolConfigString); @@ -36,7 +36,7 @@ public: private: ConnectionData prepareWireguardConfig(const ServerCredentials &credentials, DockerContainer container, - const QJsonObject &containerConfig, ErrorCode errorCode); + const QJsonObject &containerConfig, ErrorCode &errorCode); bool m_isAwg; QString m_serverConfigPath; diff --git a/client/configurators/xray_configurator.cpp b/client/configurators/xray_configurator.cpp index a1469184..786da47c 100644 --- a/client/configurators/xray_configurator.cpp +++ b/client/configurators/xray_configurator.cpp @@ -14,7 +14,7 @@ XrayConfigurator::XrayConfigurator(std::shared_ptr settings, const QSh } QString XrayConfigurator::createConfig(const ServerCredentials &credentials, DockerContainer container, const QJsonObject &containerConfig, - ErrorCode errorCode) + ErrorCode &errorCode) { QString config = m_serverController->replaceVars(amnezia::scriptData(ProtocolScriptType::xray_template, container), m_serverController->genVarsForScript(credentials, container, containerConfig)); diff --git a/client/configurators/xray_configurator.h b/client/configurators/xray_configurator.h index 62aa13b9..2acfdf71 100644 --- a/client/configurators/xray_configurator.h +++ b/client/configurators/xray_configurator.h @@ -13,7 +13,7 @@ public: XrayConfigurator(std::shared_ptr settings, const QSharedPointer &serverController, QObject *parent = nullptr); QString createConfig(const ServerCredentials &credentials, DockerContainer container, const QJsonObject &containerConfig, - ErrorCode errorCode); + ErrorCode &errorCode); }; #endif // XRAY_CONFIGURATOR_H diff --git a/client/core/controllers/serverController.cpp b/client/core/controllers/serverController.cpp index 2cb914ec..b66ef5c5 100644 --- a/client/core/controllers/serverController.cpp +++ b/client/core/controllers/serverController.cpp @@ -173,7 +173,7 @@ ErrorCode ServerController::uploadTextFileToContainer(DockerContainer container, } QByteArray ServerController::getTextFileFromContainer(DockerContainer container, const ServerCredentials &credentials, const QString &path, - ErrorCode errorCode) + ErrorCode &errorCode) { errorCode = ErrorCode::NoError; @@ -618,7 +618,7 @@ ServerController::Vars ServerController::genVarsForScript(const ServerCredential return vars; } -QString ServerController::checkSshConnection(const ServerCredentials &credentials, ErrorCode errorCode) +QString ServerController::checkSshConnection(const ServerCredentials &credentials, ErrorCode &errorCode) { QString stdOut; auto cbReadStdOut = [&](const QString &data, libssh::Client &) { diff --git a/client/core/controllers/serverController.h b/client/core/controllers/serverController.h index 9830a395..c87d1523 100644 --- a/client/core/controllers/serverController.h +++ b/client/core/controllers/serverController.h @@ -36,7 +36,7 @@ public: const QString &path, libssh::ScpOverwriteMode overwriteMode = libssh::ScpOverwriteMode::ScpOverwriteExisting); QByteArray getTextFileFromContainer(DockerContainer container, const ServerCredentials &credentials, const QString &path, - ErrorCode errorCode); + ErrorCode &errorCode); QString replaceVars(const QString &script, const Vars &vars); Vars genVarsForScript(const ServerCredentials &credentials, DockerContainer container = DockerContainer::None, @@ -50,7 +50,7 @@ public: const std::function &cbReadStdOut = nullptr, const std::function &cbReadStdErr = nullptr); - QString checkSshConnection(const ServerCredentials &credentials, ErrorCode errorCode); + QString checkSshConnection(const ServerCredentials &credentials, ErrorCode &errorCode); void cancelInstallation(); diff --git a/client/core/controllers/vpnConfigurationController.cpp b/client/core/controllers/vpnConfigurationController.cpp index f84919e7..23ed0804 100644 --- a/client/core/controllers/vpnConfigurationController.cpp +++ b/client/core/controllers/vpnConfigurationController.cpp @@ -77,7 +77,7 @@ ErrorCode VpnConfigurationsController::createProtocolConfigString(const bool isA QJsonObject VpnConfigurationsController::createVpnConfiguration(const QPair &dns, const QJsonObject &serverConfig, const QJsonObject &containerConfig, const DockerContainer container, - ErrorCode errorCode) + ErrorCode &errorCode) { QJsonObject vpnConfiguration {}; diff --git a/client/core/controllers/vpnConfigurationController.h b/client/core/controllers/vpnConfigurationController.h index d0328ec5..1b10d448 100644 --- a/client/core/controllers/vpnConfigurationController.h +++ b/client/core/controllers/vpnConfigurationController.h @@ -21,7 +21,7 @@ public slots: const DockerContainer container, const QJsonObject &containerConfig, const Proto protocol, QString &protocolConfigString); QJsonObject createVpnConfiguration(const QPair &dns, const QJsonObject &serverConfig, - const QJsonObject &containerConfig, const DockerContainer container, ErrorCode errorCode); + const QJsonObject &containerConfig, const DockerContainer container, ErrorCode &errorCode); static void updateContainerConfigAfterInstallation(const DockerContainer container, QJsonObject &containerConfig, const QString &stdOut); signals: