Small cleanup

This commit is contained in:
Joseph Milazzo 2025-06-13 19:08:04 -05:00
parent 17f9328c8a
commit 07d3932bdc
4 changed files with 4 additions and 15 deletions

View file

@ -80,7 +80,7 @@ public class PersonController : BaseApiController
/// <param name="userParams"></param> /// <param name="userParams"></param>
/// <returns></returns> /// <returns></returns>
[HttpPost("all")] [HttpPost("all")]
public async Task<ActionResult<PagedList<BrowsePersonDto>>> GetAuthorsForBrowse(BrowsePersonFilterDto filter, [FromQuery] UserParams? userParams) public async Task<ActionResult<PagedList<BrowsePersonDto>>> GetPeopleForBrowse(BrowsePersonFilterDto filter, [FromQuery] UserParams? userParams)
{ {
userParams ??= UserParams.Default; userParams ??= UserParams.Default;
@ -90,17 +90,6 @@ public class PersonController : BaseApiController
return Ok(list); return Ok(list);
} }
// [HttpPost("all-v2")]
// public async Task<ActionResult<PagedList<BrowsePersonDto>>> GetAuthorsForBrowse(FilterV2Dto filter, [FromQuery] UserParams? userParams)
// {
// userParams ??= UserParams.Default;
//
// // var list = await _unitOfWork.PersonRepository.GetBrowsePersonDtos(User.GetUserId(), filter, userParams);
// // Response.AddPaginationHeader(list.CurrentPage, list.PageSize, list.TotalCount, list.TotalPages);
//
// return Ok([]);
// }
/// <summary> /// <summary>
/// Updates the Person /// Updates the Person
/// </summary> /// </summary>

View file

@ -267,7 +267,7 @@ public class PersonRepository : IPersonRepository
PersonFilterField.Role => query.HasPersonRole(true, statement.Comparison, (IList<PersonRole>)value), PersonFilterField.Role => query.HasPersonRole(true, statement.Comparison, (IList<PersonRole>)value),
PersonFilterField.SeriesCount => query.HasPersonSeriesCount(true, statement.Comparison, (int)value), PersonFilterField.SeriesCount => query.HasPersonSeriesCount(true, statement.Comparison, (int)value),
PersonFilterField.ChapterCount => query.HasPersonChapterCount(true, statement.Comparison, (int)value), PersonFilterField.ChapterCount => query.HasPersonChapterCount(true, statement.Comparison, (int)value),
_ => throw new ArgumentOutOfRangeException() _ => throw new ArgumentOutOfRangeException(nameof(statement.Field), $"Unexpected value for field: {statement.Field}")
}; };
} }

View file

@ -1290,7 +1290,7 @@ public class SeriesRepository : ISeriesRepository
FilterField.ReadingDate => query.HasReadingDate(true, statement.Comparison, (DateTime) value, userId), FilterField.ReadingDate => query.HasReadingDate(true, statement.Comparison, (DateTime) value, userId),
FilterField.ReadLast => query.HasReadLast(true, statement.Comparison, (int) value, userId), FilterField.ReadLast => query.HasReadLast(true, statement.Comparison, (int) value, userId),
FilterField.AverageRating => query.HasAverageRating(true, statement.Comparison, (float) value), FilterField.AverageRating => query.HasAverageRating(true, statement.Comparison, (float) value),
_ => throw new ArgumentOutOfRangeException() _ => throw new ArgumentOutOfRangeException(nameof(statement.Field), $"Unexpected value for field: {statement.Field}")
}; };
} }

View file

@ -22,7 +22,7 @@ public static class PersonFilterFieldValueConverter
private static IList<PersonRole> ParsePersonRoles(string value) private static IList<PersonRole> ParsePersonRoles(string value)
{ {
if (string.IsNullOrEmpty(value)) return new List<PersonRole>(); if (string.IsNullOrEmpty(value)) return [];
return value.Split(',', StringSplitOptions.RemoveEmptyEntries) return value.Split(',', StringSplitOptions.RemoveEmptyEntries)
.Select(v => Enum.Parse<PersonRole>(v.Trim())) .Select(v => Enum.Parse<PersonRole>(v.Trim()))