AZEN-SGG/Kavita
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SonarCube stuff

Browse source
This commit is contained in:
Joseph Milazzo 2025-04-26 07:39:22 -05:00
parent 484529dadd
commit 17955eb9f6
2 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

1
API/Helpers/PersonHelper.cs
View file

@ -80,7 +80,6 @@ public static class PersonHelper
// If not, create a new Person entity using the real name // If not, create a new Person entity using the real name
dbPerson = new PersonBuilder(personName).Build(); dbPerson = new PersonBuilder(personName).Build();
peopleToAttach.Add(dbPerson); // Add new person to the list to be attached peopleToAttach.Add(dbPerson); // Add new person to the list to be attached
modification = true;
} }
// Add the person to the SeriesMetadataPeople collection // Add the person to the SeriesMetadataPeople collection

8
API/Services/Plus/ExternalMetadataService.cs
View file

@ -113,7 +113,7 @@ public class ExternalMetadataService : IExternalMetadataService
public async Task FetchExternalDataTask() public async Task FetchExternalDataTask()
{ {
// Find all Series that are eligible and limit // Find all Series that are eligible and limit
var ids = await _unitOfWork.ExternalSeriesMetadataRepository.GetSeriesThatNeedExternalMetadata(25, false); var ids = await _unitOfWork.ExternalSeriesMetadataRepository.GetSeriesThatNeedExternalMetadata(25);
if (ids.Count == 0) return; if (ids.Count == 0) return;
ids = await _unitOfWork.ExternalSeriesMetadataRepository.GetSeriesThatNeedExternalMetadata(25, true); ids = await _unitOfWork.ExternalSeriesMetadataRepository.GetSeriesThatNeedExternalMetadata(25, true);
@ -444,7 +444,7 @@ public class ExternalMetadataService : IExternalMetadataService
{ {
if (errorMessage.Contains("Too many Requests")) if (errorMessage.Contains("Too many Requests"))
{ {
_logger.LogInformation("Hit rate limit, will retry in 3 seconds"); _logger.LogDebug("Hit rate limit, will retry in 3 seconds");
await Task.Delay(3000); await Task.Delay(3000);
result = await (Configuration.KavitaPlusApiUrl + "/api/metadata/v2/series-detail") result = await (Configuration.KavitaPlusApiUrl + "/api/metadata/v2/series-detail")
@ -673,7 +673,7 @@ public class ExternalMetadataService : IExternalMetadataService
foreach (var relation in externalMetadataRelations.Where(r => r.Relation != RelationKind.Parent)) foreach (var relation in externalMetadataRelations.Where(r => r.Relation != RelationKind.Parent))
{ {
var names = new [] {relation.SeriesName.PreferredTitle, relation.SeriesName.RomajiTitle, relation.SeriesName.EnglishTitle, relation.SeriesName.NativeTitle}; List<string> names = new [] {relation.SeriesName.PreferredTitle, relation.SeriesName.RomajiTitle, relation.SeriesName.EnglishTitle, relation.SeriesName.NativeTitle}.Where(s => !string.IsNullOrEmpty(s)).ToList()!;
var relatedSeries = await _unitOfWork.SeriesRepository.GetSeriesByAnyName( var relatedSeries = await _unitOfWork.SeriesRepository.GetSeriesByAnyName(
names, names,
relation.PlusMediaFormat.GetMangaFormats(), relation.PlusMediaFormat.GetMangaFormats(),
@ -1232,7 +1232,7 @@ public class ExternalMetadataService : IExternalMetadataService
.DistinctBy(p => Parser.Normalize(p.Name)) .DistinctBy(p => Parser.Normalize(p.Name))
.ToList(); .ToList();
await PersonHelper.UpdateChapterPeopleAsync(chapter, staff, role, _unitOfWork); await PersonHelper.UpdateChapterPeopleAsync(chapter, staff ?? [], role, _unitOfWork);
foreach (var person in chapter.People.Where(p => p.Role == role)) foreach (var person in chapter.People.Where(p => p.Role == role))
{ {