AZEN-SGG/Kavita
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix empty filters after clicking on know for, don't filter on roles for known for Fixes #3858

Browse source
This commit is contained in:
Amelia 2025-06-20 12:13:33 +02:00
parent 145d74cd6f
commit 5c8b124b70
2 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
API/Data/Repositories/PersonRepository.cs
View file

@ -315,10 +315,9 @@ public class PersonRepository : IPersonRepository
public async Task<IEnumerable<SeriesDto>> GetSeriesKnownFor(int personId) public async Task<IEnumerable<SeriesDto>> GetSeriesKnownFor(int personId)
{ {
List<PersonRole> notValidRoles = [PersonRole.Location, PersonRole.Team, PersonRole.Other, PersonRole.Publisher, PersonRole.Translator];
return await _context.Person return await _context.Person
.Where(p => p.Id == personId) .Where(p => p.Id == personId)
.SelectMany(p => p.SeriesMetadataPeople.Where(smp => !notValidRoles.Contains(smp.Role))) .SelectMany(p => p.SeriesMetadataPeople)
.Select(smp => smp.SeriesMetadata) .Select(smp => smp.SeriesMetadata)
.Select(sm => sm.Series) .Select(sm => sm.Series)
.Distinct() .Distinct()

5
UI/Web/src/app/person-detail/person-detail.component.ts
View file

@ -187,9 +187,8 @@ export class PersonDetailComponent implements OnInit {
filter.combination = FilterCombination.Or; filter.combination = FilterCombination.Or;
filter.limitTo = 20; filter.limitTo = 20;
// I might want to use roles$ to do all this roles.forEach(pr => {
allPeople.forEach(f => { filter.statements.push({comparison: FilterComparison.Contains, value: this.person!.id + '', field: personRoleForFilterField(pr)});
filter.statements.push({comparison: FilterComparison.Contains, value: this.person!.id + '', field: f});
}); });
return filter; return filter;